Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126632/?format=api
{ "id": 126632, "url": "http://patches.dpdk.org/api/patches/126632/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230428144647.1072-6-ktejasree@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230428144647.1072-6-ktejasree@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230428144647.1072-6-ktejasree@marvell.com", "date": "2023-04-28T14:46:45", "name": "[5/7] crypto/cnxk: set local variables to template value", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f9cfba6aea41108bb9ef5f0e458d779d2704c2ed", "submitter": { "id": 1789, "url": "http://patches.dpdk.org/api/people/1789/?format=api", "name": "Tejasree Kondoj", "email": "ktejasree@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230428144647.1072-6-ktejasree@marvell.com/mbox/", "series": [ { "id": 27901, "url": "http://patches.dpdk.org/api/series/27901/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27901", "date": "2023-04-28T14:46:40", "name": "fixes and improvements to CNXK crypto PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/27901/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126632/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/126632/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C7D7142A12;\n\tFri, 28 Apr 2023 16:47:32 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B26DE42FA6;\n\tFri, 28 Apr 2023 16:47:15 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 40B5042FA0\n for <dev@dpdk.org>; Fri, 28 Apr 2023 16:47:14 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 33SEOJaV007109 for <dev@dpdk.org>; Fri, 28 Apr 2023 07:47:13 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3q781hydy2-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Fri, 28 Apr 2023 07:47:13 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Fri, 28 Apr 2023 07:47:11 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Fri, 28 Apr 2023 07:47:11 -0700", "from HY-LT1085.marvell.com (unknown [10.193.84.114])\n by maili.marvell.com (Postfix) with ESMTP id 660575B692C;\n Fri, 28 Apr 2023 07:47:08 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=bJ1XhQIYmOZ+vVE4afW/N7JBYfDVj2zj3KGgUeAT+IE=;\n b=ZJaU0Nj1w4dsPLLlIGwKv69bZglQdKxEarnX7Q8YvzO/8q7T+/lw0RQ37bUsWL0Ka6O8\n 0eMYT7oVn7FWK+MzLPfD8W05A9M8c+aS7mTv2gXkdlEoE3JIFZRat6nS9/tH1Qgg32ZP\n QqzPTQbW9iJxvhN3FiWTPMtDPkiZyGMh9kPhaXZvUqIiZ6Q2VteX0wxyRFqtzPOhIrI+\n ia7dv63WZXu37m4FSJFo8L0eMiwD6BF+5KnQiUSYUWFleO1p3QqY+J84ShCiCew4QeuV\n 7cf4V4YVJgR7wSA2+DghjmPmOTWXUoQ8No8ECDcUYRj6KykOmWgXD7bxVDu71+WdppRf Sg==", "From": "Tejasree Kondoj <ktejasree@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>", "CC": "Anoob Joseph <anoobj@marvell.com>, Jerin Jacob <jerinj@marvell.com>,\n Aakash Sasidharan <asasidharan@marvell.com>, Gowrishankar Muthukrishnan\n <gmuthukrishn@marvell.com>,\n Vidya Sagar Velumuri <vvelumuri@marvell.com>, <dev@dpdk.org>", "Subject": "[PATCH 5/7] crypto/cnxk: set local variables to template value", "Date": "Fri, 28 Apr 2023 20:16:45 +0530", "Message-ID": "<20230428144647.1072-6-ktejasree@marvell.com>", "X-Mailer": "git-send-email 2.40.1.windows.1", "In-Reply-To": "<20230428144647.1072-1-ktejasree@marvell.com>", "References": "<20230428144647.1072-1-ktejasree@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "AnS_0JWt7pJ2MbIxmHkQEeaFw98EMLEs", "X-Proofpoint-ORIG-GUID": "AnS_0JWt7pJ2MbIxmHkQEeaFw98EMLEs", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22\n definitions=2023-04-28_04,2023-04-27_01,2023-02-09_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Initializing local variable from the template populated\nin control path.\n\nSigned-off-by: Tejasree Kondoj <ktejasree@marvell.com>\n---\n drivers/crypto/cnxk/cnxk_se.h | 25 ++++++++++++-------------\n 1 file changed, 12 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h\nindex 2c465a5ab9..8715493cae 100644\n--- a/drivers/crypto/cnxk/cnxk_se.h\n+++ b/drivers/crypto/cnxk/cnxk_se.h\n@@ -607,8 +607,7 @@ cpt_digest_gen_sg_ver1_prep(uint32_t flags, uint64_t d_lens, struct roc_se_fc_pa\n \tkey_len = ctx->auth_key_len;\n \tdata_len = ROC_SE_AUTH_DLEN(d_lens);\n \n-\t/*GP op header */\n-\tcpt_inst_w4.s.opcode_minor = 0;\n+\tcpt_inst_w4.u64 = ctx->template_w4.u64;\n \tcpt_inst_w4.s.param2 = ((uint16_t)hash_type << 8) | mac_len;\n \tif (ctx->hmac) {\n \t\tcpt_inst_w4.s.opcode_major = ROC_SE_MAJOR_OP_HMAC | ROC_DMA_MODE_SG;\n@@ -724,8 +723,7 @@ cpt_digest_gen_sg_ver2_prep(uint32_t flags, uint64_t d_lens, struct roc_se_fc_pa\n \tkey_len = ctx->auth_key_len;\n \tdata_len = ROC_SE_AUTH_DLEN(d_lens);\n \n-\t/*GP op header */\n-\tcpt_inst_w4.s.opcode_minor = 0;\n+\tcpt_inst_w4.u64 = ctx->template_w4.u64;\n \tcpt_inst_w4.s.param2 = ((uint16_t)hash_type << 8) | mac_len;\n \tif (ctx->hmac) {\n \t\tcpt_inst_w4.s.opcode_major = ROC_SE_MAJOR_OP_HMAC;\n@@ -1049,7 +1047,8 @@ cpt_enc_hmac_prep(uint32_t flags, uint64_t d_offs, uint64_t d_lens,\n \tcipher_type = se_ctx->enc_cipher;\n \thash_type = se_ctx->hash_type;\n \tmac_len = se_ctx->mac_len;\n-\top_minor = se_ctx->template_w4.s.opcode_minor;\n+\tcpt_inst_w4.u64 = se_ctx->template_w4.u64;\n+\top_minor = cpt_inst_w4.s.opcode_minor;\n \n \tif (unlikely(!(flags & ROC_SE_VALID_IV_BUF))) {\n \t\tiv_len = 0;\n@@ -1080,8 +1079,7 @@ cpt_enc_hmac_prep(uint32_t flags, uint64_t d_offs, uint64_t d_lens,\n \n \t/* Encryption */\n \tcpt_inst_w4.s.opcode_major = ROC_SE_MAJOR_OP_FC;\n-\tcpt_inst_w4.s.opcode_minor = ROC_SE_FC_MINOR_OP_ENCRYPT;\n-\tcpt_inst_w4.s.opcode_minor |= (uint64_t)op_minor;\n+\tcpt_inst_w4.s.opcode_minor |= ROC_SE_FC_MINOR_OP_ENCRYPT;\n \n \tif (hash_type == ROC_SE_GMAC_TYPE) {\n \t\tencr_offset = 0;\n@@ -1112,7 +1110,6 @@ cpt_enc_hmac_prep(uint32_t flags, uint64_t d_offs, uint64_t d_lens,\n \tif (op_minor & ROC_SE_FC_MINOR_OP_HMAC_FIRST)\n \t\toutputlen = enc_dlen;\n \n-\t/* GP op header */\n \tcpt_inst_w4.s.param1 = encr_data_len;\n \tcpt_inst_w4.s.param2 = auth_data_len;\n \n@@ -1219,7 +1216,8 @@ cpt_dec_hmac_prep(uint32_t flags, uint64_t d_offs, uint64_t d_lens,\n \tse_ctx = fc_params->ctx;\n \thash_type = se_ctx->hash_type;\n \tmac_len = se_ctx->mac_len;\n-\top_minor = se_ctx->template_w4.s.opcode_minor;\n+\tcpt_inst_w4.u64 = se_ctx->template_w4.u64;\n+\top_minor = cpt_inst_w4.s.opcode_minor;\n \n \tif (unlikely(!(flags & ROC_SE_VALID_IV_BUF))) {\n \t\tiv_len = 0;\n@@ -1390,8 +1388,8 @@ cpt_pdcp_chain_alg_prep(uint32_t req_flags, uint64_t d_offs, uint64_t d_lens,\n \t\treturn -1;\n \t}\n \n+\tcpt_inst_w4.u64 = se_ctx->template_w4.u64;\n \tcpt_inst_w4.s.opcode_major = ROC_SE_MAJOR_OP_PDCP_CHAIN;\n-\tcpt_inst_w4.s.opcode_minor = se_ctx->template_w4.s.opcode_minor;\n \n \tcpt_inst_w4.s.param1 = auth_data_len;\n \tcpt_inst_w4.s.param2 = 0;\n@@ -1475,8 +1473,8 @@ cpt_pdcp_alg_prep(uint32_t req_flags, uint64_t d_offs, uint64_t d_lens,\n \tflags = se_ctx->zsk_flags;\n \tmac_len = se_ctx->mac_len;\n \n+\tcpt_inst_w4.u64 = se_ctx->template_w4.u64;\n \tcpt_inst_w4.s.opcode_major = ROC_SE_MAJOR_OP_PDCP;\n-\tcpt_inst_w4.s.opcode_minor = se_ctx->template_w4.s.opcode_minor;\n \n \tif (flags == 0x1) {\n \t\tiv_s = params->auth_iv_buf;\n@@ -1563,7 +1561,7 @@ cpt_pdcp_alg_prep(uint32_t req_flags, uint64_t d_offs, uint64_t d_lens,\n \t}\n \n \t/*\n-\t * GP op header, lengths are expected in bits.\n+\t * Lengths are expected in bits.\n \t */\n \tcpt_inst_w4.s.param1 = encr_data_len;\n \tcpt_inst_w4.s.param2 = auth_data_len;\n@@ -1637,6 +1635,7 @@ cpt_kasumi_enc_prep(uint32_t req_flags, uint64_t d_offs, uint64_t d_lens,\n \tmac_len = se_ctx->mac_len;\n \n \tdir = iv_s[8] & 0x1;\n+\tcpt_inst_w4.u64 = se_ctx->template_w4.u64;\n \n \tif (flags == 0x0) {\n \t\t/* Consider IV len */\n@@ -1712,7 +1711,7 @@ cpt_kasumi_dec_prep(uint64_t d_offs, uint64_t d_lens, struct roc_se_fc_params *p\n \t\t((1 << 6) | (se_ctx->k_ecb << 5) | (dir << 4) | (0 << 3) | (flags & 0x7));\n \n \t/*\n-\t * GP op header, lengths are expected in bits.\n+\t * Lengths are expected in bits.\n \t */\n \tcpt_inst_w4.s.param1 = encr_data_len;\n \n", "prefixes": [ "5/7" ] }