Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126554/?format=api
{ "id": 126554, "url": "http://patches.dpdk.org/api/patches/126554/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230426190415.28239-6-doshir@vmware.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230426190415.28239-6-doshir@vmware.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230426190415.28239-6-doshir@vmware.com", "date": "2023-04-26T19:04:12", "name": "[v2,next,5/7] net/vmxnet3: limit number of TXDs used for TSO packet", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "32b5edbd85bb73589ea46faf6db26b16575c3199", "submitter": { "id": 3045, "url": "http://patches.dpdk.org/api/people/3045/?format=api", "name": "Ronak Doshi", "email": "doshir@vmware.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230426190415.28239-6-doshir@vmware.com/mbox/", "series": [ { "id": 27877, "url": "http://patches.dpdk.org/api/series/27877/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27877", "date": "2023-04-26T19:04:07", "name": "net/vmxnet3: upgrade to version 7", "version": 2, "mbox": "http://patches.dpdk.org/series/27877/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126554/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/126554/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 50C1742A0A;\n\tWed, 26 Apr 2023 21:30:48 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D5B6342D52;\n\tWed, 26 Apr 2023 21:30:09 +0200 (CEST)", "from EX-PRD-EDGE01.vmware.com (EX-PRD-EDGE01.vmware.com\n [208.91.3.33]) by mails.dpdk.org (Postfix) with ESMTP id 45D284068E\n for <dev@dpdk.org>; Wed, 26 Apr 2023 21:04:35 +0200 (CEST)", "from sc9-mailhost1.vmware.com (10.113.161.71) by\n EX-PRD-EDGE01.vmware.com (10.188.245.6) with Microsoft SMTP Server id\n 15.1.2375.34; Wed, 26 Apr 2023 12:04:31 -0700", "from htb-1n-eng-dhcp122.eng.vmware.com (unknown [10.20.114.216])\n by sc9-mailhost1.vmware.com (Postfix) with ESMTP id 3139320160;\n Wed, 26 Apr 2023 12:04:34 -0700 (PDT)", "by htb-1n-eng-dhcp122.eng.vmware.com (Postfix, from userid 0)\n id 14647A83B8; Wed, 26 Apr 2023 12:04:34 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; s=s1024; d=vmware.com;\n h=from:to:cc:subject:date:message-id:in-reply-to:mime-version:\n content-type; bh=am+89PS/HJGdtII8YmqMh6hZAID3jtRz4wlveSWbYJU=;\n b=NKr3Apvkot/vQN18BgwZylVvIMwmvcAE3cm6w4Br/PL2iVRGMPrMwVxwJbBEsH\n x8EULjK5MW47RQ1LOhyCeKF7sn5Dxujn9KCvQLmHLZFVdSE7loAGczMzv+VMon\n OMAlYixp20cHtnxa+7wvpDgbE6b7fAKa6X/mwV8jO6GMhzk=", "From": "Ronak Doshi <doshir@vmware.com>", "To": "Jochen Behrens <jbehrens@vmware.com>", "CC": "<dev@dpdk.org>, Ronak Doshi <doshir@vmware.com>", "Subject": "[PATCH v2 next 5/7] net/vmxnet3: limit number of TXDs used for TSO\n packet", "Date": "Wed, 26 Apr 2023 12:04:12 -0700", "Message-ID": "<20230426190415.28239-6-doshir@vmware.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20230426190415.28239-1-doshir@vmware.com>", "References": "<20230426190415.28239-1-doshir@vmware.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "Received-SPF": "None (EX-PRD-EDGE01.vmware.com: doshir@vmware.com does not\n designate permitted sender hosts)", "X-Mailman-Approved-At": "Wed, 26 Apr 2023 21:30:01 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Currently, vmxnet3 does not have a limit on number of descriptors\nused for a TSO packet. However, with UPT, for hardware performance\nreasons, this patch limits the number of transmit descriptors to 24\nfor a TSO packet.\n\nSigned-off-by: Ronak Doshi <doshir@vmware.com>\nAcked-by: Jochen Behrens <jbehrens@vmware.com>\n---\n drivers/net/vmxnet3/base/vmxnet3_defs.h | 2 ++\n drivers/net/vmxnet3/vmxnet3_rxtx.c | 18 ++++++++++++++----\n 2 files changed, 16 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/vmxnet3/base/vmxnet3_defs.h b/drivers/net/vmxnet3/base/vmxnet3_defs.h\nindex d8cc295b08..24c235876e 100644\n--- a/drivers/net/vmxnet3/base/vmxnet3_defs.h\n+++ b/drivers/net/vmxnet3/base/vmxnet3_defs.h\n@@ -419,6 +419,8 @@ typedef union Vmxnet3_GenericDesc {\n \n /* max # of tx descs for a non-tso pkt */\n #define VMXNET3_MAX_TXD_PER_PKT 16\n+/* max # of tx descs for a tso pkt */\n+#define VMXNET3_MAX_TSO_TXD_PER_PKT 24\n \n /* Max size of a single rx buffer */\n #define VMXNET3_MAX_RX_BUF_SIZE ((1 << 14) - 1)\ndiff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c\nindex e31878ecab..7bbae4177e 100644\n--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c\n+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c\n@@ -364,6 +364,14 @@ vmxnet3_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\trte_errno = EINVAL;\n \t\t\treturn i;\n \t\t}\n+\t\t/* TSO packet cannot occupy more than\n+\t\t * VMXNET3_MAX_TSO_TXD_PER_PKT TX descriptors.\n+\t\t */\n+\t\tif ((ol_flags & RTE_MBUF_F_TX_TCP_SEG) != 0 &&\n+\t\t\t\tm->nb_segs > VMXNET3_MAX_TSO_TXD_PER_PKT) {\n+\t\t\trte_errno = EINVAL;\n+\t\t\treturn i;\n+\t\t}\n \n \t\t/* check that only supported TX offloads are requested. */\n \t\tif ((ol_flags & VMXNET3_TX_OFFLOAD_NOTSUP_MASK) != 0 ||\n@@ -444,10 +452,12 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\tcontinue;\n \t\t}\n \n-\t\t/* Drop non-TSO packet that is excessively fragmented */\n-\t\tif (unlikely(!tso && count > VMXNET3_MAX_TXD_PER_PKT)) {\n-\t\t\tPMD_TX_LOG(ERR, \"Non-TSO packet cannot occupy more than %d tx \"\n-\t\t\t\t \"descriptors. Packet dropped.\", VMXNET3_MAX_TXD_PER_PKT);\n+\t\t/* Drop non-TSO or TSO packet that is excessively fragmented */\n+\t\tif (unlikely((!tso && count > VMXNET3_MAX_TXD_PER_PKT) ||\n+\t\t\t (tso && count > VMXNET3_MAX_TSO_TXD_PER_PKT))) {\n+\t\t\tPMD_TX_LOG(ERR, \"Non-TSO or TSO packet cannot occupy more than \"\n+\t\t\t\t \"%d or %d tx descriptors respectively. Packet dropped.\",\n+\t\t\t\t VMXNET3_MAX_TXD_PER_PKT, VMXNET3_MAX_TSO_TXD_PER_PKT);\n \t\t\ttxq->stats.drop_too_many_segs++;\n \t\t\ttxq->stats.drop_total++;\n \t\t\trte_pktmbuf_free(txm);\n", "prefixes": [ "v2", "next", "5/7" ] }