Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126464/?format=api
{ "id": 126464, "url": "http://patches.dpdk.org/api/patches/126464/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230424122835.39493-9-sedara@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230424122835.39493-9-sedara@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230424122835.39493-9-sedara@marvell.com", "date": "2023-04-24T12:28:31", "name": "[v3,08/11] net/octeon_ep: update queue size checks", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "77d8136f8034d803b06ad5de27338c32ab4e23b0", "submitter": { "id": 2729, "url": "http://patches.dpdk.org/api/people/2729/?format=api", "name": "Sathesh B Edara", "email": "sedara@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230424122835.39493-9-sedara@marvell.com/mbox/", "series": [ { "id": 27844, "url": "http://patches.dpdk.org/api/series/27844/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27844", "date": "2023-04-24T12:28:24", "name": "extend octeon ep driver functionality", "version": 3, "mbox": "http://patches.dpdk.org/series/27844/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126464/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/126464/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 58430429DB;\n\tMon, 24 Apr 2023 14:29:17 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 77C4742D2F;\n\tMon, 24 Apr 2023 14:29:02 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 5FA3242D1A\n for <dev@dpdk.org>; Mon, 24 Apr 2023 14:28:59 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 33O7WIl6027380 for <dev@dpdk.org>; Mon, 24 Apr 2023 05:28:58 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3q5nfb0xqk-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Mon, 24 Apr 2023 05:28:58 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Mon, 24 Apr 2023 05:28:56 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Mon, 24 Apr 2023 05:28:56 -0700", "from localhost.marvell.com (unknown [10.106.27.249])\n by maili.marvell.com (Postfix) with ESMTP id 70B233F70A0;\n Mon, 24 Apr 2023 05:28:56 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=0zIrGu02qlw+oyZcrPANTO1y+6s4v+eZG0xfg6kBfbQ=;\n b=HqJTsQ2c0IVVsVrNvvnyyO1GAqO/K6znD2YzB7bCBHVFNA2nC2dOTGLd6R/hVp7CiHcx\n tPfu8qzsRyEevLcFyhyMhdjQYnUWS3dgFl2Lo9z7o4JC16G+5GrbUgoQXV9ZB3kX5qTn\n 4N/nAh9HDrSAQgiBKMCS0CkRzBY8Phi4X9Gwb0feJxd56tkHBXYOzS4wl0xtkdZyYjgJ\n fJhu3ZFIO+3ryXyW8Se8gMFJQIGpbJUWdgkJZDjxVasX7mV5SSQr2r62jsfHdxI8I0sg\n 3tzVMlX9Pa3fpGA6gdR9mBoqNKROMhTZjNs71LqR2Zcv1g4tG7HUX/BfSh6pdeyXysHV DQ==", "From": "Sathesh Edara <sedara@marvell.com>", "To": "<sburla@marvell.com>, <jerinj@marvell.com>, <sedara@marvell.com>, \"Radha\n Mohan Chintakuntla\" <radhac@marvell.com>, Veerasenareddy Burru\n <vburru@marvell.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH v3 08/11] net/octeon_ep: update queue size checks", "Date": "Mon, 24 Apr 2023 05:28:31 -0700", "Message-ID": "<20230424122835.39493-9-sedara@marvell.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20230424122835.39493-1-sedara@marvell.com>", "References": "<20230405142537.1899973-2-sedara@marvell.com>\n <20230424122835.39493-1-sedara@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "VDBTNVjqlH98e60oB4D1WYL6nQmUv2K4", "X-Proofpoint-GUID": "VDBTNVjqlH98e60oB4D1WYL6nQmUv2K4", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22\n definitions=2023-04-24_07,2023-04-21_01,2023-02-09_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Updates the output queue size checks to ensure\nthat queue is larger than backpressure watermark.\nAdd setting of default queue sizes to the minimum\nso that applications like testpmd can be started\nwithout explicit queue size arguments.\n\nSigned-off-by: Sathesh Edara <sedara@marvell.com>\n---\n drivers/net/octeon_ep/otx_ep_common.h | 9 +++++++--\n drivers/net/octeon_ep/otx_ep_ethdev.c | 12 ++++++++++--\n drivers/net/octeon_ep/otx_ep_rxtx.h | 4 ++--\n 3 files changed, 19 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/octeon_ep/otx_ep_common.h b/drivers/net/octeon_ep/otx_ep_common.h\nindex 444136923f..3582f3087b 100644\n--- a/drivers/net/octeon_ep/otx_ep_common.h\n+++ b/drivers/net/octeon_ep/otx_ep_common.h\n@@ -11,8 +11,13 @@\n #define OTX_EP_MAX_RINGS_PER_VF (8)\n #define OTX_EP_CFG_IO_QUEUES OTX_EP_MAX_RINGS_PER_VF\n #define OTX_EP_64BYTE_INSTR (64)\n-#define OTX_EP_MIN_IQ_DESCRIPTORS (128)\n-#define OTX_EP_MIN_OQ_DESCRIPTORS (128)\n+/*\n+ * Backpressure for SDP is configured on Octeon, and the minimum queue sizes\n+ * must be much larger than the backpressure watermark configured in the Octeon\n+ * SDP driver. IQ and OQ backpressure configurations are separate.\n+ */\n+#define OTX_EP_MIN_IQ_DESCRIPTORS (2048)\n+#define OTX_EP_MIN_OQ_DESCRIPTORS (2048)\n #define OTX_EP_MAX_IQ_DESCRIPTORS (8192)\n #define OTX_EP_MAX_OQ_DESCRIPTORS (8192)\n #define OTX_EP_OQ_BUF_SIZE (2048)\ndiff --git a/drivers/net/octeon_ep/otx_ep_ethdev.c b/drivers/net/octeon_ep/otx_ep_ethdev.c\nindex 30a7a450fb..0f710b1ffa 100644\n--- a/drivers/net/octeon_ep/otx_ep_ethdev.c\n+++ b/drivers/net/octeon_ep/otx_ep_ethdev.c\n@@ -48,6 +48,9 @@ otx_ep_dev_info_get(struct rte_eth_dev *eth_dev,\n \tdevinfo->rx_desc_lim = otx_ep_rx_desc_lim;\n \tdevinfo->tx_desc_lim = otx_ep_tx_desc_lim;\n \n+\tdevinfo->default_rxportconf.ring_size = OTX_EP_MIN_OQ_DESCRIPTORS;\n+\tdevinfo->default_txportconf.ring_size = OTX_EP_MIN_IQ_DESCRIPTORS;\n+\n \treturn 0;\n }\n \n@@ -274,8 +277,8 @@ otx_ep_rx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t q_no,\n \t\treturn -EINVAL;\n \t}\n \tif (num_rx_descs < (SDP_GBL_WMARK * 8)) {\n-\t\totx_ep_err(\"Invalid rx desc number should at least be greater than 8xwmark %u\\n\",\n-\t\t\t num_rx_descs);\n+\t\totx_ep_err(\"Invalid rx desc number(%u) should at least be greater than 8xwmark %u\\n\",\n+\t\t\t num_rx_descs, (SDP_GBL_WMARK * 8));\n \t\treturn -EINVAL;\n \t}\n \n@@ -357,6 +360,11 @@ otx_ep_tx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t q_no,\n \t\t\t num_tx_descs);\n \t\treturn -EINVAL;\n \t}\n+\tif (num_tx_descs < (SDP_GBL_WMARK * 8)) {\n+\t\totx_ep_err(\"Invalid tx desc number(%u) should at least be greater than 8*wmark(%u)\\n\",\n+\t\t\t num_tx_descs, (SDP_GBL_WMARK * 8));\n+\t\treturn -EINVAL;\n+\t}\n \n \tretval = otx_ep_setup_iqs(otx_epvf, q_no, num_tx_descs, socket_id);\n \ndiff --git a/drivers/net/octeon_ep/otx_ep_rxtx.h b/drivers/net/octeon_ep/otx_ep_rxtx.h\nindex 1527d350b5..7012888100 100644\n--- a/drivers/net/octeon_ep/otx_ep_rxtx.h\n+++ b/drivers/net/octeon_ep/otx_ep_rxtx.h\n@@ -7,8 +7,8 @@\n \n #include <rte_byteorder.h>\n \n-#define OTX_EP_RXD_ALIGN 1\n-#define OTX_EP_TXD_ALIGN 1\n+#define OTX_EP_RXD_ALIGN 2\n+#define OTX_EP_TXD_ALIGN 2\n \n #define OTX_EP_IQ_SEND_FAILED (-1)\n #define OTX_EP_IQ_SEND_SUCCESS (0)\n", "prefixes": [ "v3", "08/11" ] }