Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126374/?format=api
{ "id": 126374, "url": "http://patches.dpdk.org/api/patches/126374/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230421084043.135503-11-wenjing.qiao@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230421084043.135503-11-wenjing.qiao@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230421084043.135503-11-wenjing.qiao@intel.com", "date": "2023-04-21T08:40:38", "name": "[v2,10/15] common/idpf: fix memory leaks on ctrlq functions", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "f93c3ea327b23ab29b6a5b62632058c523fbb5ff", "submitter": { "id": 2680, "url": "http://patches.dpdk.org/api/people/2680/?format=api", "name": "Wenjing Qiao", "email": "wenjing.qiao@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230421084043.135503-11-wenjing.qiao@intel.com/mbox/", "series": [ { "id": 27813, "url": "http://patches.dpdk.org/api/series/27813/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27813", "date": "2023-04-21T08:40:28", "name": "update idpf shared code", "version": 2, "mbox": "http://patches.dpdk.org/series/27813/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126374/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/126374/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B4F5B429AA;\n\tFri, 21 Apr 2023 10:47:04 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1432B42D16;\n\tFri, 21 Apr 2023 10:46:21 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id A4D4142D50;\n Fri, 21 Apr 2023 10:46:18 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Apr 2023 01:46:18 -0700", "from dpdk-wenjing-01.sh.intel.com ([10.67.118.239])\n by fmsmga004.fm.intel.com with ESMTP; 21 Apr 2023 01:46:16 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1682066779; x=1713602779;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Ah9vgoVDJaO1ih3yu8myzr6iCvuVkAMldnLcmp3bdvw=;\n b=C3maMEuJRBViRPnv4qUlKDzg9+dNrthWUu+pgHCtwuRdXWoAgVteypQq\n n7ypc4iVhlPc3KriPBApkV9aQi7SXo0vhZDTrQyANXUL4sXyi0IibDyVm\n NGiUxny12PMNHuWb+BFV5wMBDcGZPN8JpJJyDYjAmIhXL5n8L1HQNTUD/\n 1/+gGPgNoaaTaKV9/zJH/1HHGnkIogeS5Z7xy/pzR503WcbzSU3w0FZAP\n 95MOsndsRlqfmEY3EZ0GKWE31INRxREMVV/lyKSPZBZpwiSS7veisjuw1\n 9T0vgOialgOovFNymojm8IouNtrBr19w/i64MIgawQx6WlrqEz6QC+Aw8 g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10686\"; a=\"334822898\"", "E=Sophos;i=\"5.99,214,1677571200\"; d=\"scan'208\";a=\"334822898\"", "E=McAfee;i=\"6600,9927,10686\"; a=\"761501502\"", "E=Sophos;i=\"5.99,214,1677571200\"; d=\"scan'208\";a=\"761501502\"" ], "X-ExtLoop1": "1", "From": "Wenjing Qiao <wenjing.qiao@intel.com>", "To": "jingjing.wu@intel.com,\n\tbeilei.xing@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "dev@dpdk.org, Wenjing Qiao <wenjing.qiao@intel.com>, stable@dpdk.org,\n Christopher Pau <christopher.pau@intel.com>", "Subject": "[PATCH v2 10/15] common/idpf: fix memory leaks on ctrlq functions", "Date": "Fri, 21 Apr 2023 04:40:38 -0400", "Message-Id": "<20230421084043.135503-11-wenjing.qiao@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230421084043.135503-1-wenjing.qiao@intel.com>", "References": "<20230413094502.1714755-2-wenjing.qiao@intel.com>\n <20230421084043.135503-1-wenjing.qiao@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "idpf_init_hw needs to free it's q_info.\nidpf_clean_arq_element needs to return buffers via post_rx_buffs\n\nFixes: fb4ac04e9bfa (\"common/idpf: introduce common library\")\nCc: stable@dpdk.org\n\nSigned-off-by: Christopher Pau <christopher.pau@intel.com>\nSigned-off-by: Wenjing Qiao <wenjing.qiao@intel.com>\n---\n drivers/common/idpf/base/idpf_common.c | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/drivers/common/idpf/base/idpf_common.c b/drivers/common/idpf/base/idpf_common.c\nindex 69e3b32f85..de82c3458f 100644\n--- a/drivers/common/idpf/base/idpf_common.c\n+++ b/drivers/common/idpf/base/idpf_common.c\n@@ -130,6 +130,8 @@ int idpf_init_hw(struct idpf_hw *hw, struct idpf_ctlq_size ctlq_size)\n \thw->mac.addr[4] = 0x03;\n \thw->mac.addr[5] = 0x14;\n \n+\tidpf_free(hw, q_info);\n+\n \treturn 0;\n }\n \n@@ -219,6 +221,7 @@ bool idpf_check_asq_alive(struct idpf_hw *hw)\n int idpf_clean_arq_element(struct idpf_hw *hw,\n \t\t\t struct idpf_arq_event_info *e, u16 *pending)\n {\n+\tstruct idpf_dma_mem *dma_mem = NULL;\n \tstruct idpf_ctlq_msg msg = { 0 };\n \tint status;\n \tu16 msg_data_len;\n@@ -226,6 +229,8 @@ int idpf_clean_arq_element(struct idpf_hw *hw,\n \t*pending = 1;\n \n \tstatus = idpf_ctlq_recv(hw->arq, pending, &msg);\n+\tif (status == -ENOMSG)\n+\t\tgoto exit;\n \n \t/* ctlq_msg does not align to ctlq_desc, so copy relevant data here */\n \te->desc.opcode = msg.opcode;\n@@ -240,7 +245,14 @@ int idpf_clean_arq_element(struct idpf_hw *hw,\n \t\tmsg_data_len = msg.data_len;\n \t\tidpf_memcpy(e->msg_buf, msg.ctx.indirect.payload->va, msg_data_len,\n \t\t\t IDPF_DMA_TO_NONDMA);\n+\t\tdma_mem = msg.ctx.indirect.payload;\n+\t} else {\n+\t\t*pending = 0;\n \t}\n+\n+\tstatus = idpf_ctlq_post_rx_buffs(hw, hw->arq, pending, &dma_mem);\n+\n+exit:\n \treturn status;\n }\n \n", "prefixes": [ "v2", "10/15" ] }