Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126368/?format=api
{ "id": 126368, "url": "http://patches.dpdk.org/api/patches/126368/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230421084043.135503-5-wenjing.qiao@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230421084043.135503-5-wenjing.qiao@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230421084043.135503-5-wenjing.qiao@intel.com", "date": "2023-04-21T08:40:32", "name": "[v2,04/15] common/idpf: remove qregion struct variables", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "ab0859732091e17d27d4aa8f6d9b0be189aefbd3", "submitter": { "id": 2680, "url": "http://patches.dpdk.org/api/people/2680/?format=api", "name": "Wenjing Qiao", "email": "wenjing.qiao@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230421084043.135503-5-wenjing.qiao@intel.com/mbox/", "series": [ { "id": 27813, "url": "http://patches.dpdk.org/api/series/27813/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27813", "date": "2023-04-21T08:40:28", "name": "update idpf shared code", "version": 2, "mbox": "http://patches.dpdk.org/series/27813/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126368/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/126368/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8E19D429AA;\n\tFri, 21 Apr 2023 10:46:27 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 06B0642D31;\n\tFri, 21 Apr 2023 10:46:11 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 20B1F42BD9\n for <dev@dpdk.org>; Fri, 21 Apr 2023 10:46:06 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Apr 2023 01:46:06 -0700", "from dpdk-wenjing-01.sh.intel.com ([10.67.118.239])\n by fmsmga004.fm.intel.com with ESMTP; 21 Apr 2023 01:46:04 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1682066767; x=1713602767;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=AcPd/43caLnE6wVp3OdqTJotit7vuunfCEQFbuk6iNA=;\n b=e1rwkb6h7aKSHXhRd2W27PRZAAMXd0BLOPlgxV45bHu+hlxQA0iaJCCG\n ZXU+3QdD1lnxANpz7SA9t08qdWs8fR2h5NzWvHzc2OWYJRKQBanlry2kZ\n YgcH9CjyGALNeYR5iAxtKacsgNwZNLj91/euHJDYdg7KBsRAavRuUl601\n cLHG9XPMdKaXZz9+ZduCqqKT3u0dkJhe+S6edLj0zKily6Z+1VW5ZQvL8\n pv3+4N9ShTxi0LA6eI7QY6H+In1th39UMcBVCONBcYmFk/g4U3t3/H1+K\n H8BHFh6s2EGSUqwB8fRegEmw4p+qVFzf3SlobSr+XOPOAwadEi7rlXDmx g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10686\"; a=\"334822840\"", "E=Sophos;i=\"5.99,214,1677571200\"; d=\"scan'208\";a=\"334822840\"", "E=McAfee;i=\"6600,9927,10686\"; a=\"761501410\"", "E=Sophos;i=\"5.99,214,1677571200\"; d=\"scan'208\";a=\"761501410\"" ], "X-ExtLoop1": "1", "From": "Wenjing Qiao <wenjing.qiao@intel.com>", "To": "jingjing.wu@intel.com,\n\tbeilei.xing@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "dev@dpdk.org, Wenjing Qiao <wenjing.qiao@intel.com>,\n Pavan Kumar Linga <pavan.kumar.linga@intel.com>", "Subject": "[PATCH v2 04/15] common/idpf: remove qregion struct variables", "Date": "Fri, 21 Apr 2023 04:40:32 -0400", "Message-Id": "<20230421084043.135503-5-wenjing.qiao@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230421084043.135503-1-wenjing.qiao@intel.com>", "References": "<20230413094502.1714755-2-wenjing.qiao@intel.com>\n <20230421084043.135503-1-wenjing.qiao@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Existing qregion variables are not well defined and cannot be\nused for TC related stuff. Remove them from create vport\nstruct and add those freed bytes to a new reserved field.\n\nAdd appropriate comments on how to use the dynctl and itrn\nregister spacing variables.\n\nOnly VF reference was used in get version comments where it\nshould be PF/VF.\n\nNote: qregion variables will be added once the requirements\nare defined properly.\n\nSigned-off-by: Pavan Kumar Linga <pavan.kumar.linga@intel.com>\nSigned-off-by: Wenjing Qiao <wenjing.qiao@intel.com>\n---\n drivers/common/idpf/base/virtchnl2.h | 27 +++++++++++----------------\n 1 file changed, 11 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/common/idpf/base/virtchnl2.h b/drivers/common/idpf/base/virtchnl2.h\nindex d496f2388e..5c01734b65 100644\n--- a/drivers/common/idpf/base/virtchnl2.h\n+++ b/drivers/common/idpf/base/virtchnl2.h\n@@ -426,13 +426,13 @@\n \n \n /* VIRTCHNL2_OP_VERSION\n- * VF posts its version number to the CP. CP responds with its version number\n+ * PF/VF posts its version number to the CP. CP responds with its version number\n * in the same format, along with a return code.\n- * If there is a major version mismatch, then the VF cannot operate.\n- * If there is a minor version mismatch, then the VF can operate but should\n+ * If there is a major version mismatch, then the PF/VF cannot operate.\n+ * If there is a minor version mismatch, then the PF/VF can operate but should\n * add a warning to the system log.\n *\n- * This version opcode MUST always be specified as == 1, regardless of other\n+ * This version opcode MUST always be specified as == 1, regardless of other\n * changes in the API. The CP must always respond to this message without\n * error regardless of version mismatch.\n */\n@@ -598,11 +598,7 @@ struct virtchnl2_create_vport {\n \t/* see VIRTCHNL2_TX_DESC_IDS definitions */\n \t__le64 tx_desc_ids;\n \n-#define MAX_Q_REGIONS 16\n-\t__le32 max_qs_per_qregion[MAX_Q_REGIONS];\n-\t__le32 qregion_total_qs;\n-\t__le16 qregion_type;\n-\t__le16 pad2;\n+\tu8 reserved1[72];\n \n \t/* see VIRTCHNL2_RSS_ALGORITHM definitions */\n \t__le32 rss_algorithm;\n@@ -665,9 +661,7 @@ struct virtchnl2_txq_info {\n \t */\n \t__le16 peer_rx_queue_id;\n \n-\t/* value ranges from 0 to 15 */\n-\t__le16 qregion_id;\n-\tu8 pad[2];\n+\tu8 pad[4];\n \n \t/* Egress pasid is used for SIOV use case */\n \t__le32 egress_pasid;\n@@ -734,10 +728,7 @@ struct virtchnl2_rxq_info {\n \t * if this field is set\n \t */\n \tu8 bufq2_ena;\n-\tu8 pad2;\n-\n-\t/* value ranges from 0 to 15 */\n-\t__le16 qregion_id;\n+\tu8 pad2[3];\n \n \t/* Ingress pasid is used for SIOV use case */\n \t__le32 ingress_pasid;\n@@ -801,9 +792,13 @@ struct virtchnl2_vector_chunk {\n \t * interrupt indices without modifying the state of the interrupt.\n \t */\n \t__le32 dynctl_reg_start;\n+\t/* register spacing to find the next dynctl and itrn register offset\n+\t * from the provided dynctl_reg_start and itrn_reg_start respectively\n+\t */\n \t__le32 dynctl_reg_spacing;\n \n \t__le32 itrn_reg_start;\n+\t/* register spacing to find the individual itrn register where n=0..2 */\n \t__le32 itrn_reg_spacing;\n \tu8 reserved[8];\n };\n", "prefixes": [ "v2", "04/15" ] }