Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126340/?format=api
{ "id": 126340, "url": "http://patches.dpdk.org/api/patches/126340/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230421060245.3136217-3-vattunuru@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230421060245.3136217-3-vattunuru@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230421060245.3136217-3-vattunuru@marvell.com", "date": "2023-04-21T06:02:43", "name": "[2/4] node: add a node to receive pkts from kernel", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "30ab6f2a86a0c2772b8e7f6b7d5dddaf9a38ce86", "submitter": { "id": 1277, "url": "http://patches.dpdk.org/api/people/1277/?format=api", "name": "Vamsi Krishna Attunuru", "email": "vattunuru@marvell.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230421060245.3136217-3-vattunuru@marvell.com/mbox/", "series": [ { "id": 27808, "url": "http://patches.dpdk.org/api/series/27808/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27808", "date": "2023-04-21T06:02:41", "name": "app: introduce testgraph application", "version": 1, "mbox": "http://patches.dpdk.org/series/27808/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126340/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/126340/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C483A429A6;\n\tFri, 21 Apr 2023 08:03:09 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3E2D142C76;\n\tFri, 21 Apr 2023 08:03:02 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id ED17F42B71\n for <dev@dpdk.org>; Fri, 21 Apr 2023 08:03:00 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 33L330CA008176 for <dev@dpdk.org>; Thu, 20 Apr 2023 23:03:00 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3q3djpjemc-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 20 Apr 2023 23:02:59 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Thu, 20 Apr 2023 23:02:57 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Thu, 20 Apr 2023 23:02:57 -0700", "from localhost.localdomain (unknown [10.28.36.156])\n by maili.marvell.com (Postfix) with ESMTP id E03CD3F707C;\n Thu, 20 Apr 2023 23:02:55 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=2GOxSM7+tXFkdmQwFLke/S8sPAw7JjOUxBli8a2Avvc=;\n b=PHJNvBVJ5Iq+UmmQlk7UuTYAOT6TOcKWhgx3e8IyunTEE7N/UlhroKsFFZZJyZcROpoV\n VKhZ+SfSEq1/aoPXds90ZD6Mm7+DXMoxsNYhRlfQMPFx6ZB0jX+BVB9hi4m5rlf96z8U\n DYsC5QIYKlfeSvWgBktCTPhfmZJSXnlTLcwejdyXi2WVMJKHUC+1r3eIkQruDcvLj8wl\n fCcklgpxoNAC1E3JgrAMahxl+YcQMZmWS3MskTDWYJOMGlrwKaFCsYLIHnNAPuqnV6iI\n dvpDoRPWoLzgotsgtsXZQuKY3LK0DMqgNxMp8WYskVYMYF++2U1n3tEnt23OTl11Jhz1 Lg==", "From": "Vamsi Attunuru <vattunuru@marvell.com>", "To": "<dev@dpdk.org>, <jerinj@marvell.com>", "CC": "<vattunuru@marvell.com>, <ndabilpuram@marvell.com>", "Subject": "[PATCH 2/4] node: add a node to receive pkts from kernel", "Date": "Thu, 20 Apr 2023 23:02:43 -0700", "Message-ID": "<20230421060245.3136217-3-vattunuru@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230421060245.3136217-1-vattunuru@marvell.com>", "References": "<20230421060245.3136217-1-vattunuru@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "6A6nhBwX0cuQUHOjjKf7rODfNxsF_bpv", "X-Proofpoint-ORIG-GUID": "6A6nhBwX0cuQUHOjjKf7rODfNxsF_bpv", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22\n definitions=2023-04-20_17,2023-04-20_01,2023-02-09_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Patch adds a node to receive packets from kernel\nover a raw socket.\n\nSigned-off-by: Vamsi Attunuru <vattunuru@marvell.com>\n---\n doc/guides/prog_guide/graph_lib.rst | 7 +\n lib/node/kernel_recv.c | 277 ++++++++++++++++++++++++++++\n lib/node/kernel_recv_priv.h | 74 ++++++++\n lib/node/meson.build | 1 +\n 4 files changed, 359 insertions(+)", "diff": "diff --git a/doc/guides/prog_guide/graph_lib.rst b/doc/guides/prog_guide/graph_lib.rst\nindex b3b5b14827..1057f16de8 100644\n--- a/doc/guides/prog_guide/graph_lib.rst\n+++ b/doc/guides/prog_guide/graph_lib.rst\n@@ -402,3 +402,10 @@ on the raw socket.\n \n Aftering sending the burst of packets to kernel, this node redirects the same\n objects to pkt_drop node to free up the packet buffers.\n+\n+kernel_recv\n+~~~~~~~~~~~\n+This node receives packets from kernel over a raw socket interface. Uses ``poll``\n+function to poll on the socket fd for ``POLLIN`` events to read the packets from\n+raw socket to stream buffer and does ``rte_node_next_stream_move()`` when there\n+are received packets.\ndiff --git a/lib/node/kernel_recv.c b/lib/node/kernel_recv.c\nnew file mode 100644\nindex 0000000000..361dcc3b5f\n--- /dev/null\n+++ b/lib/node/kernel_recv.c\n@@ -0,0 +1,277 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2023 Marvell International Ltd.\n+ */\n+\n+#include <fcntl.h>\n+#include <poll.h>\n+#include <stdlib.h>\n+#include <sys/ioctl.h>\n+#include <sys/socket.h>\n+#include <unistd.h>\n+\n+#include <rte_debug.h>\n+#include <rte_ethdev.h>\n+#include <rte_graph.h>\n+#include <rte_graph_worker.h>\n+#include <rte_ip.h>\n+#include <rte_malloc.h>\n+#include <rte_mbuf.h>\n+#include <rte_mempool.h>\n+#include <rte_net.h>\n+\n+#include \"ethdev_rx_priv.h\"\n+#include \"kernel_recv_priv.h\"\n+#include \"node_private.h\"\n+\n+static struct kernel_recv_node_main kernel_recv_main;\n+\n+static inline struct rte_mbuf *\n+alloc_rx_mbuf(kernel_recv_node_ctx_t *ctx)\n+{\n+\tkernel_recv_info_t *rx = ctx->recv_info;\n+\n+\tif (rx->idx >= rx->cnt) {\n+\t\tuint16_t cnt;\n+\n+\t\trx->idx = 0;\n+\t\trx->cnt = 0;\n+\n+\t\tcnt = rte_pktmbuf_alloc_bulk(ctx->pktmbuf_pool, rx->rx_bufs, KERN_RECV_CACHE_COUNT);\n+\t\tif (cnt <= 0)\n+\t\t\treturn NULL;\n+\n+\t\trx->cnt = cnt;\n+\t}\n+\n+\treturn rx->rx_bufs[rx->idx++];\n+}\n+\n+static inline void\n+mbuf_update(struct rte_mbuf **mbufs, uint16_t nb_pkts)\n+{\n+\tstruct rte_net_hdr_lens hdr_lens;\n+\tstruct rte_mbuf *m;\n+\tint i;\n+\n+\tfor (i = 0; i < nb_pkts; i++) {\n+\t\tm = mbufs[i];\n+\n+\t\tm->packet_type = rte_net_get_ptype(m, &hdr_lens, RTE_PTYPE_ALL_MASK);\n+\n+\t\tm->ol_flags = 0;\n+\t\tm->tx_offload = 0;\n+\n+\t\tm->l2_len = hdr_lens.l2_len;\n+\t\tm->l3_len = hdr_lens.l3_len;\n+\t\tm->l4_len = hdr_lens.l4_len;\n+\t}\n+}\n+\n+static uint16_t\n+recv_pkt_parse(void **objs, uint16_t nb_pkts)\n+{\n+\tuint16_t pkts_left = nb_pkts;\n+\tstruct rte_mbuf **pkts;\n+\tint i;\n+\n+\tpkts = (struct rte_mbuf **)objs;\n+\n+\tif (pkts_left >= 4) {\n+\t\tfor (i = 0; i < 4; i++)\n+\t\t\trte_prefetch0(rte_pktmbuf_mtod(pkts[i], void *));\n+\t}\n+\n+\twhile (pkts_left >= 12) {\n+\t\t/* Prefetch next-next mbufs */\n+\t\trte_prefetch0(pkts[8]);\n+\t\trte_prefetch0(pkts[9]);\n+\t\trte_prefetch0(pkts[10]);\n+\t\trte_prefetch0(pkts[11]);\n+\n+\t\t/* Prefetch next mbuf data */\n+\t\trte_prefetch0(rte_pktmbuf_mtod(pkts[4], void *));\n+\t\trte_prefetch0(rte_pktmbuf_mtod(pkts[5], void *));\n+\t\trte_prefetch0(rte_pktmbuf_mtod(pkts[6], void *));\n+\t\trte_prefetch0(rte_pktmbuf_mtod(pkts[7], void *));\n+\n+\t\t/* Extract ptype of mbufs */\n+\t\tmbuf_update(pkts, 4);\n+\n+\t\tpkts += 4;\n+\t\tpkts_left -= 4;\n+\t}\n+\n+\tif (pkts_left > 0)\n+\t\tmbuf_update(pkts, pkts_left);\n+\n+\treturn nb_pkts;\n+}\n+\n+static uint16_t\n+kernel_recv_node_do(struct rte_graph *graph, struct rte_node *node, kernel_recv_node_ctx_t *ctx)\n+{\n+\tkernel_recv_info_t *rx;\n+\tuint16_t next_index;\n+\tint fd;\n+\n+\trx = ctx->recv_info;\n+\tnext_index = rx->cls_next;\n+\n+\tfd = rx->sock;\n+\tif (fd > 0) {\n+\t\tstruct rte_mbuf **mbufs;\n+\t\tuint16_t len = 0, count = 0;\n+\t\tint nb_cnt, i;\n+\n+\t\tnb_cnt = (node->size >= RTE_GRAPH_BURST_SIZE) ? RTE_GRAPH_BURST_SIZE : node->size;\n+\n+\t\tmbufs = (struct rte_mbuf **)node->objs;\n+\t\tfor (i = 0; i < nb_cnt; i++) {\n+\t\t\tstruct rte_mbuf *m = alloc_rx_mbuf(ctx);\n+\n+\t\t\tif (!m)\n+\t\t\t\tbreak;\n+\n+\t\t\tlen = read(fd, rte_pktmbuf_mtod(m, char *), rte_pktmbuf_tailroom(m));\n+\t\t\tif (len == 0 || len == 0xFFFF) {\n+\t\t\t\trte_pktmbuf_free(m);\n+\t\t\t\tif (rx->idx <= 0)\n+\t\t\t\t\tnode_dbg(\"kernel_recv\", \"rx_mbuf array is empty\\n\");\n+\t\t\t\trx->idx--;\n+\t\t\t\tbreak;\n+\t\t\t}\n+\t\t\t*mbufs++ = m;\n+\n+\t\t\tm->port = node->id;\n+\t\t\trte_pktmbuf_data_len(m) = len;\n+\n+\t\t\tcount++;\n+\t\t}\n+\n+\t\tif (count) {\n+\t\t\trecv_pkt_parse(node->objs, count);\n+\t\t\tnode->idx = count;\n+\n+\t\t\t/* Enqueue to next node */\n+\t\t\trte_node_next_stream_move(graph, node, next_index);\n+\t\t}\n+\n+\t\treturn count;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static uint16_t\n+kernel_recv_node_process(struct rte_graph *graph, struct rte_node *node, void **objs,\n+\t\t\t uint16_t nb_objs)\n+{\n+\tkernel_recv_node_ctx_t *ctx = (kernel_recv_node_ctx_t *)node->ctx;\n+\tint fd;\n+\n+\tRTE_SET_USED(objs);\n+\tRTE_SET_USED(nb_objs);\n+\n+\tif (!ctx)\n+\t\treturn 0;\n+\n+\tfd = ctx->recv_info->sock;\n+\tif (fd > 0) {\n+\t\tstruct pollfd fds = {.fd = fd, .events = POLLIN};\n+\n+\t\tif (poll(&fds, 1, 0) > 0) {\n+\t\t\tif (fds.revents & POLLIN)\n+\t\t\t\treturn kernel_recv_node_do(graph, node, ctx);\n+\t\t}\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+kernel_recv_node_init(const struct rte_graph *graph, struct rte_node *node)\n+{\n+\tkernel_recv_node_ctx_t *ctx = (kernel_recv_node_ctx_t *)node->ctx;\n+\tkernel_recv_node_elem_t *elem = kernel_recv_main.head;\n+\tkernel_recv_info_t *recv_info;\n+\tint sock;\n+\n+\twhile (elem) {\n+\t\tif (elem->nid == node->id) {\n+\t\t\t/* Update node specific context */\n+\t\t\tmemcpy(ctx, &elem->ctx, sizeof(kernel_recv_node_ctx_t));\n+\t\t\tbreak;\n+\t\t}\n+\t\telem = elem->next;\n+\t}\n+\n+\tRTE_VERIFY(elem != NULL);\n+\n+\tif (ctx->pktmbuf_pool == NULL) {\n+\t\tnode_err(\"kernel_recv\", \"Invalid mbuf pool on graph %s\\n\", graph->name);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\trecv_info =\n+\t\trte_zmalloc(\"kernel_recv_info\", sizeof(kernel_recv_info_t), RTE_CACHE_LINE_SIZE);\n+\tif (!recv_info) {\n+\t\tnode_err(\"kernel_recv\", \"Kernel recv_info is NULL\\n\");\n+\t\treturn -ENOMEM;\n+\t}\n+\n+\tsock = socket(AF_INET, SOCK_RAW, IPPROTO_RAW);\n+\tif (sock < 0) {\n+\t\tnode_err(\"kernel_recv\", \"Unable to open RAW socket\\n\");\n+\t\treturn sock;\n+\t}\n+\n+\trecv_info->cls_next = ETHDEV_RX_NEXT_PKT_CLS;\n+\trecv_info->sock = sock;\n+\tctx->recv_info = recv_info;\n+\n+\treturn 0;\n+}\n+\n+static void\n+kernel_recv_node_fini(const struct rte_graph *graph __rte_unused, struct rte_node *node)\n+{\n+\tkernel_recv_node_ctx_t *ctx = (kernel_recv_node_ctx_t *)node->ctx;\n+\n+\tif (ctx->recv_info) {\n+\t\tclose(ctx->recv_info->sock);\n+\t\tctx->recv_info->sock = -1;\n+\t\trte_free(ctx->recv_info);\n+\t}\n+\n+\tctx->recv_info = NULL;\n+}\n+\n+struct kernel_recv_node_main *\n+kernel_recv_node_data_get(void)\n+{\n+\treturn &kernel_recv_main;\n+}\n+\n+static struct rte_node_register kernel_recv_node_base = {\n+\t.process = kernel_recv_node_process,\n+\t.flags = RTE_NODE_SOURCE_F,\n+\t.name = \"kernel_recv\",\n+\n+\t.init = kernel_recv_node_init,\n+\t.fini = kernel_recv_node_fini,\n+\n+\t.nb_edges = KERNEL_RECV_NEXT_MAX,\n+\t.next_nodes = {\n+\t\t\t/* Default pkt classification node */\n+\t\t\t[KERNEL_RECV_NEXT_PKT_CLS] = \"pkt_cls\",\n+\t\t\t[KERNEL_RECV_NEXT_IP4_LOOKUP] = \"ip4_lookup\",\n+\t},\n+};\n+\n+struct rte_node_register *\n+kernel_recv_node_get(void)\n+{\n+\treturn &kernel_recv_node_base;\n+}\n+\n+RTE_NODE_REGISTER(kernel_recv_node_base);\ndiff --git a/lib/node/kernel_recv_priv.h b/lib/node/kernel_recv_priv.h\nnew file mode 100644\nindex 0000000000..c2bfbf40bd\n--- /dev/null\n+++ b/lib/node/kernel_recv_priv.h\n@@ -0,0 +1,74 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2023 Marvell International Ltd.\n+ */\n+\n+#ifndef __INCLUDE_KERNEL_RECV_PRIV_H__\n+#define __INCLUDE_KERNEL_RECV_PRIV_H__\n+\n+#define KERN_RECV_CACHE_COUNT 64\n+\n+typedef struct kernel_recv_info {\n+\tstruct rte_mbuf *rx_bufs[KERN_RECV_CACHE_COUNT];\n+\tuint16_t cls_next;\n+\tuint16_t idx;\n+\tuint16_t cnt;\n+\tint sock;\n+} kernel_recv_info_t;\n+\n+/**\n+ * @internal\n+ *\n+ * Kernel Recv node context structure.\n+ */\n+typedef struct kernel_recv_node_ctx {\n+\tstruct rte_mempool *pktmbuf_pool;\n+\tkernel_recv_info_t *recv_info;\n+} kernel_recv_node_ctx_t;\n+\n+/**\n+ * @internal\n+ *\n+ * Kernel Recv node list element structure.\n+ */\n+typedef struct kernel_recv_node_elem {\n+\tstruct kernel_recv_node_elem *next; /**< Pointer to the next node element. */\n+\tstruct kernel_recv_node_ctx ctx; /**< Kernel Recv node context. */\n+\trte_node_t nid;\t\t\t /**< Node identifier of the Kernel Recv node. */\n+} kernel_recv_node_elem_t;\n+\n+enum kernel_recv_next_nodes {\n+\tKERNEL_RECV_NEXT_IP4_LOOKUP,\n+\tKERNEL_RECV_NEXT_PKT_CLS,\n+\tKERNEL_RECV_NEXT_MAX,\n+};\n+\n+/**\n+ * @internal\n+ *\n+ * Kernel Recv node main structure.\n+ */\n+struct kernel_recv_node_main {\n+\tkernel_recv_node_elem_t *head; /**< Pointer to the head node element. */\n+};\n+\n+/**\n+ * @internal\n+ *\n+ * Get the Kernel Recv node data.\n+ *\n+ * @return\n+ * Pointer to Kernel Recv node data.\n+ */\n+struct kernel_recv_node_main *kernel_recv_node_data_get(void);\n+\n+/**\n+ * @internal\n+ *\n+ * Get the Kernel Recv node.\n+ *\n+ * @return\n+ * Pointer to the Kernel Recv node.\n+ */\n+struct rte_node_register *kernel_recv_node_get(void);\n+\n+#endif /* __INCLUDE_KERNEL_RECV_PRIV_H__ */\ndiff --git a/lib/node/meson.build b/lib/node/meson.build\nindex 48c2da73f7..8b1b024f61 100644\n--- a/lib/node/meson.build\n+++ b/lib/node/meson.build\n@@ -13,6 +13,7 @@ sources = files(\n 'ethdev_tx.c',\n 'ip4_lookup.c',\n 'ip4_rewrite.c',\n+ 'kernel_recv.c',\n 'log.c',\n 'null.c',\n 'pkt_cls.c',\n", "prefixes": [ "2/4" ] }