Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126326/?format=api
{ "id": 126326, "url": "http://patches.dpdk.org/api/patches/126326/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230420100803.494-4-viacheslavo@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230420100803.494-4-viacheslavo@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230420100803.494-4-viacheslavo@nvidia.com", "date": "2023-04-20T10:08:01", "name": "[RFC,3/5] net/mlx5: add Tx datapath tracing", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "428f8aab2d3c374f98351c0436bb7fdec75819e4", "submitter": { "id": 1926, "url": "http://patches.dpdk.org/api/people/1926/?format=api", "name": "Slava Ovsiienko", "email": "viacheslavo@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230420100803.494-4-viacheslavo@nvidia.com/mbox/", "series": [ { "id": 27800, "url": "http://patches.dpdk.org/api/series/27800/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27800", "date": "2023-04-20T10:07:58", "name": "net/mlx5: introduce Tx datapath tracing", "version": 1, "mbox": "http://patches.dpdk.org/series/27800/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126326/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/126326/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ED26242996;\n\tThu, 20 Apr 2023 12:09:00 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 57A9742D29;\n\tThu, 20 Apr 2023 12:08:46 +0200 (CEST)", "from NAM04-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam04on2049.outbound.protection.outlook.com [40.107.102.49])\n by mails.dpdk.org (Postfix) with ESMTP id E06AE42BD9\n for <dev@dpdk.org>; Thu, 20 Apr 2023 12:08:43 +0200 (CEST)", "from BN9PR03CA0425.namprd03.prod.outlook.com (2603:10b6:408:113::10)\n by IA0PR12MB8838.namprd12.prod.outlook.com (2603:10b6:208:483::17)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.22; Thu, 20 Apr\n 2023 10:08:41 +0000", "from BN8NAM11FT063.eop-nam11.prod.protection.outlook.com\n (2603:10b6:408:113:cafe::e3) by BN9PR03CA0425.outlook.office365.com\n (2603:10b6:408:113::10) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.25 via Frontend\n Transport; Thu, 20 Apr 2023 10:08:41 +0000", "from mail.nvidia.com (216.228.117.160) by\n BN8NAM11FT063.mail.protection.outlook.com (10.13.177.110) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6319.25 via Frontend Transport; Thu, 20 Apr 2023 10:08:40 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 20 Apr 2023\n 03:08:30 -0700", "from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 20 Apr\n 2023 03:08:29 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=NiLVzBZJ7tVoJpldd9UVlu3t0TSoT5JX80RbDr6C6VGnXQC7ygfvSPozse+jIgNXdMi/2Zbn842/Npa7mN1JSQueF/1ysOHHtDXnVQVhmEFZFvf4DofQ1EQ3XeMwuE1S14H5ug9tcm3bBUjui73j6IgRAcWdFOi9vBZKJbog9Au3X3U/+idaop0xHjB7C9cTJAvHIW+4hFSvab2yfpQhKYtaVcOBo1r2KFflnoQYiIFVS9iUh4BnxjCtKvmsgldbc6dj7Y7UplZ6QNijekDg1bttCWndBEmwniNgw0jQqRGYJxIvTl3BBHGKL4gX8i1G+Yw2cXq5nACNLkjtPvgESw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=FB8vGRWbhwWEfePpI3Uxpw1wEnGsMG8LTZGq2E7w3WM=;\n b=glHcnfXX2c9cPLQ2NeyNwEl+ZS1Fz0emu+q+MPEl+Cx+7aT3F0gjv5yrMVfCAjeO3aHbKtr8FXI6bHh78smhw/W6NS1QDDIOLRYugya3R/3Kvez8kkoJghLr/1KA7QOOWuc7jvI4b7nGjUfN1pIs60Gkp4RmId4mmXXIWMtAwQMmGWFaznIMLYr2oi/KWfYDMUAn7F5Voep/TLqME3aREh7iJ9ehQ4uKWQ8rnPU0DCUheTlymamfEKpr2I4Wuyr+WCB0+X6TDxPl+H8j6fzTCOtqqp2CdCwW7Dg+Tz3ZH0hTB6LlFs3Sat78phKoFowV3YPSxZRlxN5intK3+9r4/g==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=FB8vGRWbhwWEfePpI3Uxpw1wEnGsMG8LTZGq2E7w3WM=;\n b=FfSvoaxiS0H8krdcffeQF1pH6TK0DvmyZ0i5cTvf6mQfIbrRyiHCmhAciBS/lQw/KNJtFBQlEsKTwoyfBmxFmU9sz87IB7bnQeSWPv5J4YXKgXyA18O1OGZa4gHgnIWlvJ1fyrV1Z95Kmon58jfyALAUS1r5ZLgAF0I85kGa8tT6QSiv3iuk0dc3K5lnJF1YzyqzlfqPxiyA8tFiqmrbQLvHHEBv5Z9bbwilG+N2MNC3sZ7daXzMNCL0jKjoy5aUexHw8UGA8/7An0ezYaQzyrY2o4rFWV8U4Kho+wbjnmMS+DQPE78kk+SPif8C3bAMUkm5n1ZNkVajg4bSNUF0wQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "To": "<dev@dpdk.org>", "Subject": "[RFC 3/5] net/mlx5: add Tx datapath tracing", "Date": "Thu, 20 Apr 2023 13:08:01 +0300", "Message-ID": "<20230420100803.494-4-viacheslavo@nvidia.com>", "X-Mailer": "git-send-email 2.18.1", "In-Reply-To": "<20230420100803.494-1-viacheslavo@nvidia.com>", "References": "<20230420100803.494-1-viacheslavo@nvidia.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.37]", "X-ClientProxiedBy": "rnnvmail201.nvidia.com (10.129.68.8) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BN8NAM11FT063:EE_|IA0PR12MB8838:EE_", "X-MS-Office365-Filtering-Correlation-Id": "13a5583b-93bc-4b13-d113-08db41873782", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n OnGCAP2Ra0wFTxfuHOKJU2lntyOj1lCLvJfnZN/DnFooifa/TEkSJWFnUYC1rvL4hSDV5rl4tdZHgJZPBkFx6aBKBuhAb9RF/5w7L7re/VbmA5Pj8SbifPFLSqh+0nBcNZMM0fbfZMVBe4jCLwyGZclN4npsv3S0SGb0a1YGeSmHsrqu9hXX3/qkXLADk2lM2+PcTkYrR5tsQRFRHB+/FPxKj5POBFvwHBpw4I9fbpekJd8tYQRoJWluAWhzfWMQJfMQJAMneZZ2PPiTfB0HWCgPyk+yk2rw1NMSctDSDKAZ5bGdiYgqn+WfTqhZjyRdG/GE9XreO9Daa4SH7YgOiEDLK7JsG8UoaUpwGHMls+xHrOD8uJCEE6a5gO37g/TpOqni0LtlR9BTBMLBcJ0ajS0uNsGST5AXCXvKPhA7pHXuzK8/JmkhXPlyyW0RcbbRIhoR78fY6U5TALW2rJLlbPXF3+ipzDeVhNB9o7gFsL3CfH3QtAv0SF0BM5hwNmbDzJM/k3ZSGA/JbFR2Sz+9FKkf1nYYmg+m0uyuD8TK4m+rgU3zVPhERongzIMtbDKIkim2kcQYSoEumzKxAxkZe88CeQHlJwZqIUj+MfaDANVwsKRhJ+0Liq63nwD4DM8IFgzy6wjTpNEPJ2ox0oeyA/JEtpZRuFvr6zPYrvT2OJtiiqfMmzfij4/yy8Pj2TrcdFZfUlDsZnIBiNsVvF1BRmMqS26/L4qGRHSBxVJImlqkymAM+RV02mjUTPiPcBHpRaDpCUszM0AaRrrpMAgzeDqSdv0MsN0Cj7sFEqv2KTk=", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230028)(4636009)(396003)(136003)(39860400002)(376002)(346002)(451199021)(46966006)(36840700001)(40470700004)(34020700004)(83380400001)(47076005)(478600001)(2616005)(36860700001)(40480700001)(55016003)(86362001)(26005)(1076003)(7696005)(6666004)(316002)(70206006)(70586007)(6916009)(82740400003)(186003)(6286002)(426003)(336012)(16526019)(8676002)(8936002)(2906002)(356005)(41300700001)(5660300002)(40460700003)(7636003)(36756003)(82310400005);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "20 Apr 2023 10:08:40.8580 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 13a5583b-93bc-4b13-d113-08db41873782", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT063.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "IA0PR12MB8838", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The patch adds tracing capability to Tx datapath.\nTo engage this tracing capability the following steps\nshould be taken:\n\n- meson option -Denable_trace_fp=true\n- meson option -Dc_args='-DALLOW_EXPERIMENTAL_API'\n- EAL command line parameter --trace=pmd.net.mlx5.tx.*\n\nThe Tx datapath tracing allows to get information how packets\nare pushed into hardware descriptors, time stamping for\nscheduled wait and send completions, etc.\n\nTo provide the human readable form of trace results the\ndedicated post-processing script is presumed.\n\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\n---\n drivers/net/mlx5/mlx5_rx.h | 19 -------------------\n drivers/net/mlx5/mlx5_rxtx.h | 19 +++++++++++++++++++\n drivers/net/mlx5/mlx5_tx.c | 9 +++++++++\n drivers/net/mlx5/mlx5_tx.h | 25 +++++++++++++++++++++++--\n 4 files changed, 51 insertions(+), 21 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rx.h b/drivers/net/mlx5/mlx5_rx.h\nindex 8b87adad36..1b5f110ccc 100644\n--- a/drivers/net/mlx5/mlx5_rx.h\n+++ b/drivers/net/mlx5/mlx5_rx.h\n@@ -376,25 +376,6 @@ mlx5_rx_mb2mr(struct mlx5_rxq_data *rxq, struct rte_mbuf *mb)\n \treturn mlx5_mr_mempool2mr_bh(mr_ctrl, mb->pool, addr);\n }\n \n-/**\n- * Convert timestamp from HW format to linear counter\n- * from Packet Pacing Clock Queue CQE timestamp format.\n- *\n- * @param sh\n- * Pointer to the device shared context. Might be needed\n- * to convert according current device configuration.\n- * @param ts\n- * Timestamp from CQE to convert.\n- * @return\n- * UTC in nanoseconds\n- */\n-static __rte_always_inline uint64_t\n-mlx5_txpp_convert_rx_ts(struct mlx5_dev_ctx_shared *sh, uint64_t ts)\n-{\n-\tRTE_SET_USED(sh);\n-\treturn (ts & UINT32_MAX) + (ts >> 32) * NS_PER_S;\n-}\n-\n /**\n * Set timestamp in mbuf dynamic field.\n *\ndiff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h\nindex 876aa14ae6..b109d50758 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.h\n+++ b/drivers/net/mlx5/mlx5_rxtx.h\n@@ -43,4 +43,23 @@ int mlx5_queue_state_modify_primary(struct rte_eth_dev *dev,\n int mlx5_queue_state_modify(struct rte_eth_dev *dev,\n \t\t\t struct mlx5_mp_arg_queue_state_modify *sm);\n \n+/**\n+ * Convert timestamp from HW format to linear counter\n+ * from Packet Pacing Clock Queue CQE timestamp format.\n+ *\n+ * @param sh\n+ * Pointer to the device shared context. Might be needed\n+ * to convert according current device configuration.\n+ * @param ts\n+ * Timestamp from CQE to convert.\n+ * @return\n+ * UTC in nanoseconds\n+ */\n+static __rte_always_inline uint64_t\n+mlx5_txpp_convert_rx_ts(struct mlx5_dev_ctx_shared *sh, uint64_t ts)\n+{\n+\tRTE_SET_USED(sh);\n+\treturn (ts & UINT32_MAX) + (ts >> 32) * NS_PER_S;\n+}\n+\n #endif /* RTE_PMD_MLX5_RXTX_H_ */\ndiff --git a/drivers/net/mlx5/mlx5_tx.c b/drivers/net/mlx5/mlx5_tx.c\nindex 14e1487e59..1fe9521dfc 100644\n--- a/drivers/net/mlx5/mlx5_tx.c\n+++ b/drivers/net/mlx5/mlx5_tx.c\n@@ -232,6 +232,15 @@ mlx5_tx_handle_completion(struct mlx5_txq_data *__rte_restrict txq,\n \t\tMLX5_ASSERT((txq->fcqs[txq->cq_ci & txq->cqe_m] >> 16) ==\n \t\t\t cqe->wqe_counter);\n #endif\n+\t\tif (__rte_trace_point_fp_is_enabled()) {\n+\t\t\tuint64_t ts = rte_be_to_cpu_64(cqe->timestamp);\n+\t\t\tuint16_t wqe_id = rte_be_to_cpu_16(cqe->wqe_counter);\n+\n+\t\t\tif (txq->rt_timestamp)\n+\t\t\t\tts = mlx5_txpp_convert_rx_ts(NULL, ts);\n+\t\t\trte_pmd_mlx5_trace_tx_complete(txq->port_id, txq->idx,\n+\t\t\t\t\t\t wqe_id, ts);\n+\t\t}\n \t\tring_doorbell = true;\n \t\t++txq->cq_ci;\n \t\tlast_cqe = cqe;\ndiff --git a/drivers/net/mlx5/mlx5_tx.h b/drivers/net/mlx5/mlx5_tx.h\nindex cc8f7e98aa..7f624de58e 100644\n--- a/drivers/net/mlx5/mlx5_tx.h\n+++ b/drivers/net/mlx5/mlx5_tx.h\n@@ -19,6 +19,8 @@\n \n #include \"mlx5.h\"\n #include \"mlx5_autoconf.h\"\n+#include \"mlx5_trace.h\"\n+#include \"mlx5_rxtx.h\"\n \n /* TX burst subroutines return codes. */\n enum mlx5_txcmp_code {\n@@ -764,6 +766,9 @@ mlx5_tx_cseg_init(struct mlx5_txq_data *__rte_restrict txq,\n \tcs->flags = RTE_BE32(MLX5_COMP_ONLY_FIRST_ERR <<\n \t\t\t MLX5_COMP_MODE_OFFSET);\n \tcs->misc = RTE_BE32(0);\n+\tif (__rte_trace_point_fp_is_enabled() && !loc->pkts_sent)\n+\t\trte_pmd_mlx5_trace_tx_entry(txq->port_id, txq->idx);\n+\trte_pmd_mlx5_trace_tx_wqe((txq->wqe_ci << 8) | opcode);\n }\n \n /**\n@@ -1692,6 +1697,7 @@ mlx5_tx_schedule_send(struct mlx5_txq_data *restrict txq,\n \t\tif (txq->wait_on_time) {\n \t\t\t/* The wait on time capability should be used. */\n \t\t\tts -= sh->txpp.skew;\n+\t\t\trte_pmd_mlx5_trace_tx_wait(ts);\n \t\t\tmlx5_tx_cseg_init(txq, loc, wqe,\n \t\t\t\t\t 1 + sizeof(struct mlx5_wqe_wseg) /\n \t\t\t\t\t MLX5_WSEG_SIZE,\n@@ -1706,6 +1712,7 @@ mlx5_tx_schedule_send(struct mlx5_txq_data *restrict txq,\n \t\t\tif (unlikely(wci < 0))\n \t\t\t\treturn MLX5_TXCMP_CODE_SINGLE;\n \t\t\t/* Build the WAIT WQE with specified completion. */\n+\t\t\trte_pmd_mlx5_trace_tx_wait(ts - sh->txpp.skew);\n \t\t\tmlx5_tx_cseg_init(txq, loc, wqe,\n \t\t\t\t\t 1 + sizeof(struct mlx5_wqe_qseg) /\n \t\t\t\t\t MLX5_WSEG_SIZE,\n@@ -1810,6 +1817,7 @@ mlx5_tx_packet_multi_tso(struct mlx5_txq_data *__rte_restrict txq,\n \twqe = txq->wqes + (txq->wqe_ci & txq->wqe_m);\n \tloc->wqe_last = wqe;\n \tmlx5_tx_cseg_init(txq, loc, wqe, 0, MLX5_OPCODE_TSO, olx);\n+\trte_pmd_mlx5_trace_tx_push(loc->mbuf, txq->wqe_ci);\n \tds = mlx5_tx_mseg_build(txq, loc, wqe, vlan, inlen, 1, olx);\n \twqe->cseg.sq_ds = rte_cpu_to_be_32(txq->qp_num_8s | ds);\n \ttxq->wqe_ci += (ds + 3) / 4;\n@@ -1892,6 +1900,7 @@ mlx5_tx_packet_multi_send(struct mlx5_txq_data *__rte_restrict txq,\n \twqe = txq->wqes + (txq->wqe_ci & txq->wqe_m);\n \tloc->wqe_last = wqe;\n \tmlx5_tx_cseg_init(txq, loc, wqe, ds, MLX5_OPCODE_SEND, olx);\n+\trte_pmd_mlx5_trace_tx_push(loc->mbuf, txq->wqe_ci);\n \tmlx5_tx_eseg_none(txq, loc, wqe, olx);\n \tdseg = &wqe->dseg[0];\n \tdo {\n@@ -2115,6 +2124,7 @@ mlx5_tx_packet_multi_inline(struct mlx5_txq_data *__rte_restrict txq,\n \twqe = txq->wqes + (txq->wqe_ci & txq->wqe_m);\n \tloc->wqe_last = wqe;\n \tmlx5_tx_cseg_init(txq, loc, wqe, 0, MLX5_OPCODE_SEND, olx);\n+\trte_pmd_mlx5_trace_tx_push(loc->mbuf, txq->wqe_ci);\n \tds = mlx5_tx_mseg_build(txq, loc, wqe, vlan, inlen, 0, olx);\n \twqe->cseg.sq_ds = rte_cpu_to_be_32(txq->qp_num_8s | ds);\n \ttxq->wqe_ci += (ds + 3) / 4;\n@@ -2318,8 +2328,8 @@ mlx5_tx_burst_tso(struct mlx5_txq_data *__rte_restrict txq,\n \t\t */\n \t\twqe = txq->wqes + (txq->wqe_ci & txq->wqe_m);\n \t\tloc->wqe_last = wqe;\n-\t\tmlx5_tx_cseg_init(txq, loc, wqe, ds,\n-\t\t\t\t MLX5_OPCODE_TSO, olx);\n+\t\tmlx5_tx_cseg_init(txq, loc, wqe, ds, MLX5_OPCODE_TSO, olx);\n+\t\trte_pmd_mlx5_trace_tx_push(loc->mbuf, txq->wqe_ci);\n \t\tdseg = mlx5_tx_eseg_data(txq, loc, wqe, vlan, hlen, 1, olx);\n \t\tdptr = rte_pktmbuf_mtod(loc->mbuf, uint8_t *) + hlen - vlan;\n \t\tdlen -= hlen - vlan;\n@@ -2688,6 +2698,7 @@ mlx5_tx_burst_empw_simple(struct mlx5_txq_data *__rte_restrict txq,\n \t\t\t/* Update sent data bytes counter. */\n \t\t\tslen += dlen;\n #endif\n+\t\t\trte_pmd_mlx5_trace_tx_push(loc->mbuf, txq->wqe_ci);\n \t\t\tmlx5_tx_dseg_ptr\n \t\t\t\t(txq, loc, dseg,\n \t\t\t\t rte_pktmbuf_mtod(loc->mbuf, uint8_t *),\n@@ -2926,6 +2937,7 @@ mlx5_tx_burst_empw_inline(struct mlx5_txq_data *__rte_restrict txq,\n \t\t\t\ttlen += sizeof(struct rte_vlan_hdr);\n \t\t\t\tif (room < tlen)\n \t\t\t\t\tbreak;\n+\t\t\t\trte_pmd_mlx5_trace_tx_push(loc->mbuf, txq->wqe_ci);\n \t\t\t\tdseg = mlx5_tx_dseg_vlan(txq, loc, dseg,\n \t\t\t\t\t\t\t dptr, dlen, olx);\n #ifdef MLX5_PMD_SOFT_COUNTERS\n@@ -2935,6 +2947,7 @@ mlx5_tx_burst_empw_inline(struct mlx5_txq_data *__rte_restrict txq,\n \t\t\t} else {\n \t\t\t\tif (room < tlen)\n \t\t\t\t\tbreak;\n+\t\t\t\trte_pmd_mlx5_trace_tx_push(loc->mbuf, txq->wqe_ci);\n \t\t\t\tdseg = mlx5_tx_dseg_empw(txq, loc, dseg,\n \t\t\t\t\t\t\t dptr, dlen, olx);\n \t\t\t}\n@@ -2980,6 +2993,7 @@ mlx5_tx_burst_empw_inline(struct mlx5_txq_data *__rte_restrict txq,\n \t\t\tif (MLX5_TXOFF_CONFIG(VLAN))\n \t\t\t\tMLX5_ASSERT(!(loc->mbuf->ol_flags &\n \t\t\t\t\t RTE_MBUF_F_TX_VLAN));\n+\t\t\trte_pmd_mlx5_trace_tx_push(loc->mbuf, txq->wqe_ci);\n \t\t\tmlx5_tx_dseg_ptr(txq, loc, dseg, dptr, dlen, olx);\n \t\t\t/* We have to store mbuf in elts.*/\n \t\t\ttxq->elts[txq->elts_head++ & txq->elts_m] = loc->mbuf;\n@@ -3194,6 +3208,7 @@ mlx5_tx_burst_single_send(struct mlx5_txq_data *__rte_restrict txq,\n \t\t\t\tloc->wqe_last = wqe;\n \t\t\t\tmlx5_tx_cseg_init(txq, loc, wqe, seg_n,\n \t\t\t\t\t\t MLX5_OPCODE_SEND, olx);\n+\t\t\t\trte_pmd_mlx5_trace_tx_push(loc->mbuf, txq->wqe_ci);\n \t\t\t\tmlx5_tx_eseg_data(txq, loc, wqe,\n \t\t\t\t\t\t vlan, inlen, 0, olx);\n \t\t\t\ttxq->wqe_ci += wqe_n;\n@@ -3256,6 +3271,7 @@ mlx5_tx_burst_single_send(struct mlx5_txq_data *__rte_restrict txq,\n \t\t\t\tloc->wqe_last = wqe;\n \t\t\t\tmlx5_tx_cseg_init(txq, loc, wqe, ds,\n \t\t\t\t\t\t MLX5_OPCODE_SEND, olx);\n+\t\t\t\trte_pmd_mlx5_trace_tx_push(loc->mbuf, txq->wqe_ci);\n \t\t\t\tdseg = mlx5_tx_eseg_data(txq, loc, wqe, vlan,\n \t\t\t\t\t\t\t txq->inlen_mode,\n \t\t\t\t\t\t\t 0, olx);\n@@ -3297,6 +3313,7 @@ mlx5_tx_burst_single_send(struct mlx5_txq_data *__rte_restrict txq,\n \t\t\t\tloc->wqe_last = wqe;\n \t\t\t\tmlx5_tx_cseg_init(txq, loc, wqe, 4,\n \t\t\t\t\t\t MLX5_OPCODE_SEND, olx);\n+\t\t\t\trte_pmd_mlx5_trace_tx_push(loc->mbuf, txq->wqe_ci);\n \t\t\t\tmlx5_tx_eseg_dmin(txq, loc, wqe, vlan, olx);\n \t\t\t\tdptr = rte_pktmbuf_mtod(loc->mbuf, uint8_t *) +\n \t\t\t\t MLX5_ESEG_MIN_INLINE_SIZE - vlan;\n@@ -3338,6 +3355,7 @@ mlx5_tx_burst_single_send(struct mlx5_txq_data *__rte_restrict txq,\n \t\t\tloc->wqe_last = wqe;\n \t\t\tmlx5_tx_cseg_init(txq, loc, wqe, 3,\n \t\t\t\t\t MLX5_OPCODE_SEND, olx);\n+\t\t\trte_pmd_mlx5_trace_tx_push(loc->mbuf, txq->wqe_ci);\n \t\t\tmlx5_tx_eseg_none(txq, loc, wqe, olx);\n \t\t\tmlx5_tx_dseg_ptr\n \t\t\t\t(txq, loc, &wqe->dseg[0],\n@@ -3707,6 +3725,9 @@ mlx5_tx_burst_tmpl(struct mlx5_txq_data *__rte_restrict txq,\n #endif\n \tif (MLX5_TXOFF_CONFIG(INLINE) && loc.mbuf_free)\n \t\t__mlx5_tx_free_mbuf(txq, pkts, loc.mbuf_free, olx);\n+\t/* Trace productive bursts only. */\n+\tif (__rte_trace_point_fp_is_enabled() && loc.pkts_sent)\n+\t\trte_pmd_mlx5_trace_tx_exit(loc.pkts_sent, pkts_n);\n \treturn loc.pkts_sent;\n }\n \n", "prefixes": [ "RFC", "3/5" ] }