Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 126115,
    "url": "http://patches.dpdk.org/api/patches/126115/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230414174512.642-16-anoobj@marvell.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230414174512.642-16-anoobj@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230414174512.642-16-anoobj@marvell.com",
    "date": "2023-04-14T17:45:05",
    "name": "[v2,15/22] pdcp: add timer callback handlers",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "9f9d00acd1af399cc3bd3ab2cd60319b8eb04715",
    "submitter": {
        "id": 1205,
        "url": "http://patches.dpdk.org/api/people/1205/?format=api",
        "name": "Anoob Joseph",
        "email": "anoobj@marvell.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230414174512.642-16-anoobj@marvell.com/mbox/",
    "series": [
        {
            "id": 27723,
            "url": "http://patches.dpdk.org/api/series/27723/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27723",
            "date": "2023-04-14T17:44:50",
            "name": "lib: add pdcp protocol",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/27723/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/126115/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/126115/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4220342943;\n\tFri, 14 Apr 2023 19:47:39 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5047642B8E;\n\tFri, 14 Apr 2023 19:47:36 +0200 (CEST)",
            "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 4B43C42D0E\n for <dev@dpdk.org>; Fri, 14 Apr 2023 19:47:35 +0200 (CEST)",
            "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 33E906vC011272; Fri, 14 Apr 2023 10:47:33 -0700",
            "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3py3tk2ejv-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Fri, 14 Apr 2023 10:47:33 -0700",
            "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Fri, 14 Apr 2023 10:47:31 -0700",
            "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Fri, 14 Apr 2023 10:47:31 -0700",
            "from BG-LT92004.corp.innovium.com (unknown [10.28.161.183])\n by maili.marvell.com (Postfix) with ESMTP id CE99D3F707F;\n Fri, 14 Apr 2023 10:47:25 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=b0/x7cWkgsUghz0TosrEX8yQElBhGJ6iNgPQSFf7pzg=;\n b=gvAeQ55nYdJrdHuwPK1CvUqEoGL+TTPrucGgqeRMrJnB+MjmXcnC/4kZV/VPlrG3TxOC\n AI2OCxjRR/sw7AS8VZC9tQcXx/fIf/QQzQTdwukVLTh9mB9QcHP1JAY/KCphjTJseEzc\n 8uFoRinc4Y3HtDlCXzvOomF7ZyqpXDywtCHA5g79zUP9Qm5fZ2AesyPy10Q/9Zy8fu6m\n uTOchD7ShjGcdpHpT2LDFWfg11O+8Luo3DQBHWIySXeZo2M8h7QcPrJGvB6ISE/B/M8H\n 2xw2GCxG4HmQOtXpMeJQwlKlOT+R+Y31xE3oJjHaJIOSCBCCjDGwUEA3t8s4zl36tYTE ew==",
        "From": "Anoob Joseph <anoobj@marvell.com>",
        "To": "Thomas Monjalon <thomas@monjalon.net>, Akhil Goyal <gakhil@marvell.com>,\n Jerin Jacob <jerinj@marvell.com>, Konstantin Ananyev\n <konstantin.v.ananyev@yandex.ru>, Bernard Iremonger\n <bernard.iremonger@intel.com>",
        "CC": "Volodymyr Fialko <vfialko@marvell.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n =?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n Kiran Kumar K <kirankumark@marvell.com>, <dev@dpdk.org>,\n Olivier Matz <olivier.matz@6wind.com>",
        "Subject": "[PATCH v2 15/22] pdcp: add timer callback handlers",
        "Date": "Fri, 14 Apr 2023 23:15:05 +0530",
        "Message-ID": "<20230414174512.642-16-anoobj@marvell.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20230414174512.642-1-anoobj@marvell.com>",
        "References": "<20221222092522.1628-1-anoobj@marvell.com>\n <20230414174512.642-1-anoobj@marvell.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-GUID": "Luyf5lG2l6O3NEhD6RIPmdBg2ypGUnqN",
        "X-Proofpoint-ORIG-GUID": "Luyf5lG2l6O3NEhD6RIPmdBg2ypGUnqN",
        "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22\n definitions=2023-04-14_10,2023-04-14_01,2023-02-09_01",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "From: Volodymyr Fialko <vfialko@marvell.com>\n\nPDCP has a windowing mechanism which allows only packets that fall in a\nreception window. The pivot point for this window is RX_REORD which\nhappens to be the first missing or next expected packet. If the missing\npacket is not received after a specified time, then the RX_REORD state\nvariable needs to be moved up to slide the reception window. PDCP relies\non timers for such operations.\n\nThe timer needs to be armed when PDCP library doesn't receive all\npackets in-order and starts buffering packets that arrived after a\nmissing packet. The timer needs to be cancelled when a missing packet\nis received.\n\nTo avoid dependency on particular timer implementation, PDCP library\nallows application to register two callbacks, timer_start() and\ntimer_stop() that will be called later by library.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\nSigned-off-by: Volodymyr Fialko <vfialko@marvell.com>\n---\n lib/pdcp/pdcp_entity.h  |  2 ++\n lib/pdcp/pdcp_process.c |  2 ++\n lib/pdcp/rte_pdcp.c     |  1 +\n lib/pdcp/rte_pdcp.h     | 47 +++++++++++++++++++++++++++++++++++++++++\n 4 files changed, 52 insertions(+)",
    "diff": "diff --git a/lib/pdcp/pdcp_entity.h b/lib/pdcp/pdcp_entity.h\nindex 71962d7279..ca98a1d0f7 100644\n--- a/lib/pdcp/pdcp_entity.h\n+++ b/lib/pdcp/pdcp_entity.h\n@@ -120,6 +120,8 @@ enum timer_state {\n struct pdcp_t_reordering {\n \t/** Represent timer state */\n \tenum timer_state state;\n+\t/** User defined callback handles */\n+\tstruct rte_pdcp_t_reordering handle;\n };\n \n struct pdcp_cnt_bitmap {\ndiff --git a/lib/pdcp/pdcp_process.c b/lib/pdcp/pdcp_process.c\nindex 16d22cbe14..9ba07d5255 100644\n--- a/lib/pdcp/pdcp_process.c\n+++ b/lib/pdcp/pdcp_process.c\n@@ -874,6 +874,7 @@ pdcp_post_process_update_entity_state(const struct rte_pdcp_entity *entity,\n \tif (t_reorder->state == TIMER_RUNNING &&\n \t\t\ten_priv->state.rx_deliv >= en_priv->state.rx_reord) {\n \t\tt_reorder->state = TIMER_STOP;\n+\t\tt_reorder->handle.stop(t_reorder->handle.timer, t_reorder->handle.args);\n \t\t/* Stop reorder buffer, only if it's empty */\n \t\tif (en_priv->state.rx_deliv == en_priv->state.rx_next)\n \t\t\tpdcp_reorder_stop(reorder);\n@@ -888,6 +889,7 @@ pdcp_post_process_update_entity_state(const struct rte_pdcp_entity *entity,\n \t\ten_priv->state.rx_reord = en_priv->state.rx_next;\n \t\t/* Start t-Reordering */\n \t\tt_reorder->state = TIMER_RUNNING;\n+\t\tt_reorder->handle.start(t_reorder->handle.timer, t_reorder->handle.args);\n \t}\n \n \treturn processed;\ndiff --git a/lib/pdcp/rte_pdcp.c b/lib/pdcp/rte_pdcp.c\nindex c9d44ca539..755d592578 100644\n--- a/lib/pdcp/rte_pdcp.c\n+++ b/lib/pdcp/rte_pdcp.c\n@@ -36,6 +36,7 @@ pdcp_dl_establish(struct rte_pdcp_entity *entity, const struct rte_pdcp_entity_c\n \tstruct entity_priv_dl_part *dl = entity_dl_part_get(entity);\n \n \tentity->max_pkt_cache = RTE_MAX(entity->max_pkt_cache, window_size);\n+\tdl->t_reorder.handle = conf->t_reordering;\n \n \treturn pdcp_reorder_create(&dl->reorder, window_size);\n }\ndiff --git a/lib/pdcp/rte_pdcp.h b/lib/pdcp/rte_pdcp.h\nindex 0d2f4fe7c1..55e57c3b9b 100644\n--- a/lib/pdcp/rte_pdcp.h\n+++ b/lib/pdcp/rte_pdcp.h\n@@ -66,6 +66,51 @@ struct rte_pdcp_entity {\n \tuint64_t user_area[2];\n } __rte_cache_aligned;\n \n+/**\n+ * Callback function type for t-Reordering timer start, set during PDCP entity establish.\n+ * This callback is invoked by PDCP library, during t-Reordering timer start event.\n+ * Only one t-Reordering per receiving PDCP entity would be running at a given time.\n+ *\n+ * @see struct rte_pdcp_timer\n+ * @see rte_pdcp_entity_establish()\n+ *\n+ * @param timer\n+ *   Pointer to timer.\n+ * @param args\n+ *   Pointer to timer arguments.\n+ */\n+typedef void (*rte_pdcp_t_reordering_start_cb_t)(void *timer, void *args);\n+\n+/**\n+ * Callback function type for t-Reordering timer stop, set during PDCP entity establish.\n+ * This callback will be invoked by PDCP library, during t-Reordering timer stop event.\n+ *\n+ * @see struct rte_pdcp_timer\n+ * @see rte_pdcp_entity_establish()\n+ *\n+ * @param timer\n+ *   Pointer to timer.\n+ * @param args\n+ *   Pointer to timer arguments.\n+ */\n+typedef void (*rte_pdcp_t_reordering_stop_cb_t)(void *timer, void *args);\n+\n+/**\n+ * PDCP t-Reordering timer interface\n+ *\n+ * Configuration provided by user, that PDCP library will invoke according to timer behaviour.\n+ */\n+struct rte_pdcp_t_reordering {\n+\t/** Timer pointer, stored for later use in callback functions */\n+\tvoid *timer;\n+\t/** Timer arguments, stored for later use in callback functions */\n+\tvoid *args;\n+\t/** Timer start callback handle */\n+\trte_pdcp_t_reordering_start_cb_t start;\n+\t/** Timer start callback handle */\n+\trte_pdcp_t_reordering_stop_cb_t stop;\n+};\n+\n /**\n  * PDCP entity configuration to be used for establishing an entity.\n  */\n@@ -105,6 +150,8 @@ struct rte_pdcp_entity_conf {\n \tbool status_report_required;\n \t/** Enable out of order delivery. */\n \tbool out_of_order_delivery;\n+\t/** t-Reordering timer configuration */\n+\tstruct rte_pdcp_t_reordering t_reordering;\n };\n /* >8 End of structure rte_pdcp_entity_conf. */\n \n",
    "prefixes": [
        "v2",
        "15/22"
    ]
}