Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126104/?format=api
{ "id": 126104, "url": "http://patches.dpdk.org/api/patches/126104/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230414174512.642-5-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230414174512.642-5-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230414174512.642-5-anoobj@marvell.com", "date": "2023-04-14T17:44:54", "name": "[v2,04/22] pdcp: add packet group", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "5ad0509c23a67363374bd9d40bccf0bacf2e259e", "submitter": { "id": 1205, "url": "http://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230414174512.642-5-anoobj@marvell.com/mbox/", "series": [ { "id": 27723, "url": "http://patches.dpdk.org/api/series/27723/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27723", "date": "2023-04-14T17:44:50", "name": "lib: add pdcp protocol", "version": 2, "mbox": "http://patches.dpdk.org/series/27723/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126104/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/126104/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0EC1C42943;\n\tFri, 14 Apr 2023 19:45:53 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 95DD442D2F;\n\tFri, 14 Apr 2023 19:45:46 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 0EBCE42D2D\n for <dev@dpdk.org>; Fri, 14 Apr 2023 19:45:44 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 33E908w8011308; Fri, 14 Apr 2023 10:45:43 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3py3tk2ea9-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Fri, 14 Apr 2023 10:45:43 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Fri, 14 Apr 2023 10:45:41 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Fri, 14 Apr 2023 10:45:41 -0700", "from BG-LT92004.corp.innovium.com (unknown [10.28.161.183])\n by maili.marvell.com (Postfix) with ESMTP id E30AA3F7080;\n Fri, 14 Apr 2023 10:45:36 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=YUAoKhBZJd8w5Tuthz7VNwLpFX3dMhXnTf2RJfaErFE=;\n b=jWP5zFs0bR2izlGigX+Y8bmS6dwarvIzXNwtcRMA+utcziPrRiQ3ILLS5uWVJ/97Fx33\n CnH6r2VjFeCVUfwOaGcfX7qFDsaQb+F77rsGZJRZQYzcF8Bhx1G9e69wz/WFxv0rmZHF\n jSOeBo4e4PcL/gbjxVNnaV/8CF6/by+mqaZQ/cHXDSCgH630CvXkcoM1eeHhRx1+swSU\n RM0+Lz5eGOXVN5aNJze9U2A8WhAbvIfWN9FN1dBcQT+MAS/dU1hafGvddiwHYg7RtxS5\n xM+Laa+4ymWmc5HhjkKSJK9qFWal/By7OZBNnmM0Va/iYtl5BItMujvkFSFm7M48ZVJn FQ==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Thomas Monjalon <thomas@monjalon.net>, Akhil Goyal <gakhil@marvell.com>,\n Jerin Jacob <jerinj@marvell.com>, Konstantin Ananyev\n <konstantin.v.ananyev@yandex.ru>, Bernard Iremonger\n <bernard.iremonger@intel.com>", "CC": "Hemant Agrawal <hemant.agrawal@nxp.com>,\n =?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n \"Kiran Kumar K\" <kirankumark@marvell.com>,\n Volodymyr Fialko <vfialko@marvell.com>, <dev@dpdk.org>,\n Olivier Matz <olivier.matz@6wind.com>", "Subject": "[PATCH v2 04/22] pdcp: add packet group", "Date": "Fri, 14 Apr 2023 23:14:54 +0530", "Message-ID": "<20230414174512.642-5-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230414174512.642-1-anoobj@marvell.com>", "References": "<20221222092522.1628-1-anoobj@marvell.com>\n <20230414174512.642-1-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "pjO6vyFj2IG_AA8ZNpMoWBL57BhU6uqw", "X-Proofpoint-ORIG-GUID": "pjO6vyFj2IG_AA8ZNpMoWBL57BhU6uqw", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22\n definitions=2023-04-14_10,2023-04-14_01,2023-02-09_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Crypto processing in PDCP is performed asynchronously by\nrte_cryptodev_enqueue_burst() and rte_cryptodev_dequeue_burst(). Since\ncryptodev dequeue can return crypto operations belonging to multiple\nentities, rte_pdcp_pkt_crypto_group() is added to help grouping crypto\noperations belonging to same entity.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\nSigned-off-by: Kiran Kumar K <kirankumark@marvell.com>\nSigned-off-by: Volodymyr Fialko <vfialko@marvell.com>\n---\n lib/pdcp/meson.build | 1 +\n lib/pdcp/rte_pdcp.h | 2 +\n lib/pdcp/rte_pdcp_group.h | 125 ++++++++++++++++++++++++++++++++++++++\n 3 files changed, 128 insertions(+)\n create mode 100644 lib/pdcp/rte_pdcp_group.h", "diff": "diff --git a/lib/pdcp/meson.build b/lib/pdcp/meson.build\nindex ccaf426240..08679b743a 100644\n--- a/lib/pdcp/meson.build\n+++ b/lib/pdcp/meson.build\n@@ -13,5 +13,6 @@ sources = files(\n 'rte_pdcp.c',\n )\n headers = files('rte_pdcp.h')\n+indirect_headers += files('rte_pdcp_group.h')\n \n deps += ['mbuf', 'net', 'cryptodev', 'security']\ndiff --git a/lib/pdcp/rte_pdcp.h b/lib/pdcp/rte_pdcp.h\nindex 75dc569f66..54f88e3fd3 100644\n--- a/lib/pdcp/rte_pdcp.h\n+++ b/lib/pdcp/rte_pdcp.h\n@@ -247,6 +247,8 @@ rte_pdcp_pkt_post_process(const struct rte_pdcp_entity *entity,\n \treturn entity->post_process(entity, in_mb, out_mb, num, nb_err);\n }\n \n+#include <rte_pdcp_group.h>\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/pdcp/rte_pdcp_group.h b/lib/pdcp/rte_pdcp_group.h\nnew file mode 100644\nindex 0000000000..cb322f55c7\n--- /dev/null\n+++ b/lib/pdcp/rte_pdcp_group.h\n@@ -0,0 +1,125 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2023 Marvell.\n+ */\n+\n+#ifndef RTE_PDCP_GROUP_H\n+#define RTE_PDCP_GROUP_H\n+\n+/**\n+ * @file rte_pdcp_group.h\n+ *\n+ * RTE PDCP grouping support.\n+ * It is not recommended to include this file directly, include <rte_pdcp.h>\n+ * instead.\n+ * Provides helper functions to process completed crypto-ops and group related\n+ * packets by sessions they belong to.\n+ */\n+\n+#include <rte_common.h>\n+#include <rte_crypto.h>\n+#include <rte_cryptodev.h>\n+\n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n+/**\n+ * Group packets belonging to same PDCP entity.\n+ */\n+struct rte_pdcp_group {\n+\tunion {\n+\t\tuint64_t val;\n+\t\tvoid *ptr;\n+\t} id; /**< Grouped by value */\n+\tstruct rte_mbuf **m; /**< Start of the group */\n+\tuint32_t cnt; /**< Number of entries in the group */\n+\tint32_t rc; /**< Status code associated with the group */\n+};\n+\n+/**\n+ * Take crypto-op as an input and extract pointer to related PDCP entity.\n+ * @param cop\n+ * The address of an input *rte_crypto_op* structure.\n+ * @return\n+ * The pointer to the related *rte_pdcp_entity* structure.\n+ */\n+static inline struct rte_pdcp_entity *\n+rte_pdcp_en_from_cop(const struct rte_crypto_op *cop)\n+{\n+\tvoid *sess = cop->sym[0].session;\n+\n+\treturn (struct rte_pdcp_entity *)\n+\t\trte_cryptodev_sym_session_opaque_data_get(sess);\n+}\n+\n+/**\n+ * Take as input completed crypto ops, extract related mbufs and group them by\n+ * *rte_pdcp_entity* they belong to. Mbuf for which the crypto operation has\n+ * failed would be flagged using *RTE_MBUF_F_RX_SEC_OFFLOAD_FAILED* flag\n+ * in rte_mbuf.ol_flags. The crypto_ops would be freed after the grouping.\n+ *\n+ * Note that application must ensure only crypto-ops prepared by lib_pdcp is\n+ * provided back to @see rte_pdcp_pkt_crypto_group().\n+ *\n+ * @param cop\n+ * The address of an array of *num* pointers to the input *rte_crypto_op*\n+ * structures.\n+ * @param[out] mb\n+ * The address of an array of *num* pointers to output *rte_mbuf* structures.\n+ * @param[out] grp\n+ * The address of an array of *num* to output *rte_pdcp_group* structures.\n+ * @param num\n+ * The maximum number of crypto-ops to process.\n+ * @return\n+ * Number of filled elements in *grp* array.\n+ *\n+ */\n+static inline uint16_t\n+rte_pdcp_pkt_crypto_group(struct rte_crypto_op *cop[], struct rte_mbuf *mb[],\n+\t\t\t struct rte_pdcp_group grp[], uint16_t num)\n+{\n+\tuint32_t i, j = 0, n = 0;\n+\tvoid *ns, *ps = NULL;\n+\tstruct rte_mbuf *m;\n+\n+\tfor (i = 0; i != num; i++) {\n+\t\tm = cop[i]->sym[0].m_src;\n+\t\tns = cop[i]->sym[0].session;\n+\n+\t\tm->ol_flags |= RTE_MBUF_F_RX_SEC_OFFLOAD;\n+\t\tif (cop[i]->status != RTE_CRYPTO_OP_STATUS_SUCCESS)\n+\t\t\tm->ol_flags |= RTE_MBUF_F_RX_SEC_OFFLOAD_FAILED;\n+\n+\t\t/* Different entity */\n+\t\tif (ps != ns) {\n+\n+\t\t\t/* Finalize open group and start a new one */\n+\t\t\tif (ps != NULL) {\n+\t\t\t\tgrp[n].cnt = mb + j - grp[n].m;\n+\t\t\t\tn++;\n+\t\t\t}\n+\n+\t\t\t/* Start new group */\n+\t\t\tgrp[n].m = mb + j;\n+\t\t\tps = ns;\n+\t\t\tgrp[n].id.ptr =\trte_pdcp_en_from_cop(cop[i]);\n+\t\t}\n+\n+\t\tmb[j++] = m;\n+\t\trte_crypto_op_free(cop[i]);\n+\t}\n+\n+\t/* Finalize last group */\n+\tif (ps != NULL) {\n+\t\tgrp[n].cnt = mb + j - grp[n].m;\n+\t\tn++;\n+\t}\n+\n+\treturn n;\n+}\n+\n+#ifdef __cplusplus\n+}\n+#endif\n+\n+#endif /* RTE_PDCP_GROUP_H */\n", "prefixes": [ "v2", "04/22" ] }