Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126003/?format=api
{ "id": 126003, "url": "http://patches.dpdk.org/api/patches/126003/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230413094502.1714755-2-wenjing.qiao@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230413094502.1714755-2-wenjing.qiao@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230413094502.1714755-2-wenjing.qiao@intel.com", "date": "2023-04-13T09:44:45", "name": "[01/18] common/idpf: support flow subscription", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3f2d339dc77a7df9e013a2d8d018ea71aa09f1db", "submitter": { "id": 2680, "url": "http://patches.dpdk.org/api/people/2680/?format=api", "name": "Wenjing Qiao", "email": "wenjing.qiao@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230413094502.1714755-2-wenjing.qiao@intel.com/mbox/", "series": [ { "id": 27692, "url": "http://patches.dpdk.org/api/series/27692/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27692", "date": "2023-04-13T09:44:44", "name": "update idpf shared code", "version": 1, "mbox": "http://patches.dpdk.org/series/27692/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126003/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/126003/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D7E8342931;\n\tThu, 13 Apr 2023 11:50:17 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9CE8D41138;\n\tThu, 13 Apr 2023 11:50:15 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 2D65E4021F\n for <dev@dpdk.org>; Thu, 13 Apr 2023 11:50:10 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2023 02:50:09 -0700", "from dpdk-wenjing-01.sh.intel.com ([10.67.119.244])\n by FMSMGA003.fm.intel.com with ESMTP; 13 Apr 2023 02:50:07 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1681379411; x=1712915411;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=373QxvP2q6x+nCTNvD2s+xR0zLnz5dw4sHp/J63RI2Y=;\n b=iovAosGh0uAecF/7ftoOqFo58kUWA9KxbTkmyVSqL5c3BhdkvveXvBtT\n tD4AutWjJtZR8o4eirzwOfu/fQ5hjmDxl81NprV67WR8ltptAlQipkAw1\n NgxXB0G4al83WwWer9lPyvoB9s9jkj0ogkfyscOsRF+y0sIOG1xMqGShx\n eH/SKWqASWEjWDE/pnK/fmb96N5vCu7P5+0MZb5dRvd+yZx3ScMYSirAQ\n jUzsykbI0hQYxjbKw2+/dZF+6t+FGNEdS6TCvQKksqvzlka2mSKj7QyWf\n WdOV26derZerXG0b+0vMT2cTVA1k3WV6K9EAi4Zc6YyN3e2cX31LuMCT0 A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10678\"; a=\"409290344\"", "E=Sophos;i=\"5.98,341,1673942400\"; d=\"scan'208\";a=\"409290344\"", "E=McAfee;i=\"6600,9927,10678\"; a=\"778699239\"", "E=Sophos;i=\"5.98,341,1673942400\"; d=\"scan'208\";a=\"778699239\"" ], "X-ExtLoop1": "1", "From": "Wenjing Qiao <wenjing.qiao@intel.com>", "To": "jingjing.wu@intel.com,\n\tbeilei.xing@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "dev@dpdk.org, Wenjing Qiao <wenjing.qiao@intel.com>,\n Jie Wang <jie1x.wang@intel.com>", "Subject": "[PATCH 01/18] common/idpf: support flow subscription", "Date": "Thu, 13 Apr 2023 05:44:45 -0400", "Message-Id": "<20230413094502.1714755-2-wenjing.qiao@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230413094502.1714755-1-wenjing.qiao@intel.com>", "References": "<20230413094502.1714755-1-wenjing.qiao@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "VF is able to subscribe a flow from PF by VIRTCHNL_FLOW_SUBSCRIBE.\n\nPF is expected to offload a rule to hardware which will redirect\nthe packet that matching the required pattern to this VF.\n\nOnly a flow with dst mac address as PF's mac address can be subscribed.\n\nVIRTCHNL_VF_OFFLOAD_FSUB_PF is used for Flow subscription capability\nnegotiation and only a trusted VF can be granted with this capability.\n\nA flow can be unsubscribed by VIRTCHNL_FLOW_UNSUBSCRIBE.\n\nSigned-off-by: Jie Wang <jie1x.wang@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\nSigned-off-by: Wenjing Qiao <wenjing.qiao@intel.com>\n---\n drivers/common/idpf/base/virtchnl.h | 102 +++++++++++++++++++++++++++-\n 1 file changed, 99 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/common/idpf/base/virtchnl.h b/drivers/common/idpf/base/virtchnl.h\nindex ea798e3971..3008802c4a 100644\n--- a/drivers/common/idpf/base/virtchnl.h\n+++ b/drivers/common/idpf/base/virtchnl.h\n@@ -182,6 +182,8 @@ enum virtchnl_ops {\n \tVIRTCHNL_OP_MAP_QUEUE_VECTOR = 111,\n \tVIRTCHNL_OP_CONFIG_QUEUE_BW = 112,\n \tVIRTCHNL_OP_CONFIG_QUANTA = 113,\n+\tVIRTCHNL_OP_FLOW_SUBSCRIBE = 114,\n+\tVIRTCHNL_OP_FLOW_UNSUBSCRIBE = 115,\n \tVIRTCHNL_OP_MAX,\n };\n \n@@ -298,6 +300,10 @@ static inline const char *virtchnl_op_str(enum virtchnl_ops v_opcode)\n \t\treturn \"VIRTCHNL_OP_DISABLE_QUEUES_V2\";\n \tcase VIRTCHNL_OP_MAP_QUEUE_VECTOR:\n \t\treturn \"VIRTCHNL_OP_MAP_QUEUE_VECTOR\";\n+\tcase VIRTCHNL_OP_FLOW_SUBSCRIBE:\n+\t\treturn \"VIRTCHNL_OP_FLOW_SUBSCRIBE\";\n+\tcase VIRTCHNL_OP_FLOW_UNSUBSCRIBE:\n+\t\treturn \"VIRTCHNL_OP_FLOW_UNSUBSCRIBE\";\n \tcase VIRTCHNL_OP_MAX:\n \t\treturn \"VIRTCHNL_OP_MAX\";\n \tdefault:\n@@ -434,6 +440,7 @@ VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_vsi_resource);\n \t/* BIT(8) is reserved */\n #define VIRTCHNL_VF_LARGE_NUM_QPAIRS\t\tBIT(9)\n #define VIRTCHNL_VF_OFFLOAD_CRC\t\t\tBIT(10)\n+#define VIRTCHNL_VF_OFFLOAD_FSUB_PF\t\tBIT(14)\n #define VIRTCHNL_VF_OFFLOAD_VLAN_V2\t\tBIT(15)\n #define VIRTCHNL_VF_OFFLOAD_VLAN\t\tBIT(16)\n #define VIRTCHNL_VF_OFFLOAD_RX_POLLING\t\tBIT(17)\n@@ -1451,6 +1458,7 @@ enum virtchnl_vfr_states {\n };\n \n #define VIRTCHNL_MAX_NUM_PROTO_HDRS\t32\n+#define VIRTCHNL_MAX_NUM_PROTO_HDRS_W_MSK 16\n #define VIRTCHNL_MAX_SIZE_RAW_PACKET\t1024\n #define PROTO_HDR_SHIFT\t\t\t5\n #define PROTO_HDR_FIELD_START(proto_hdr_type) \\\n@@ -1643,6 +1651,22 @@ struct virtchnl_proto_hdr {\n \n VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_proto_hdr);\n \n+struct virtchnl_proto_hdr_w_msk {\n+\t/* see enum virtchnl_proto_hdr_type */\n+\ts32 type;\n+\tu32 pad;\n+\t/**\n+\t * binary buffer in network order for specific header type.\n+\t * For example, if type = VIRTCHNL_PROTO_HDR_IPV4, a IPv4\n+\t * header is expected to be copied into the buffer.\n+\t */\n+\tu8 buffer_spec[64];\n+\t/* binary buffer for bit-mask applied to specific header type */\n+\tu8 buffer_mask[64];\n+};\n+\n+VIRTCHNL_CHECK_STRUCT_LEN(136, virtchnl_proto_hdr_w_msk);\n+\n struct virtchnl_proto_hdrs {\n \tu8 tunnel_level;\n \t/**\n@@ -1655,12 +1679,18 @@ struct virtchnl_proto_hdrs {\n \t */\n \tint count;\n \t/**\n-\t * number of proto layers, must < VIRTCHNL_MAX_NUM_PROTO_HDRS\n-\t * must be 0 for a raw packet request.\n+\t * count must <=\n+\t * VIRTCHNL_MAX_NUM_PROTO_HDRS + VIRTCHNL_MAX_NUM_PROTO_HDRS_W_MSK\n+\t * count = 0 :\t\t\t\t\tselect raw\n+\t * 1 < count <= VIRTCHNL_MAX_NUM_PROTO_HDRS :\tselect proto_hdr\n+\t * count > VIRTCHNL_MAX_NUM_PROTO_HDRS :\tselect proto_hdr_w_msk\n+\t * last valid index = count - VIRTCHNL_MAX_NUM_PROTO_HDRS\n \t */\n \tunion {\n \t\tstruct virtchnl_proto_hdr\n \t\t\tproto_hdr[VIRTCHNL_MAX_NUM_PROTO_HDRS];\n+\t\tstruct virtchnl_proto_hdr_w_msk\n+\t\t\tproto_hdr_w_msk[VIRTCHNL_MAX_NUM_PROTO_HDRS_W_MSK];\n \t\tstruct {\n \t\t\tu16 pkt_len;\n \t\t\tu8 spec[VIRTCHNL_MAX_SIZE_RAW_PACKET];\n@@ -1681,7 +1711,7 @@ struct virtchnl_rss_cfg {\n \n VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);\n \n-/* action configuration for FDIR */\n+/* action configuration for FDIR and FSUB */\n struct virtchnl_filter_action {\n \t/* see enum virtchnl_action type */\n \ts32 type;\n@@ -1799,6 +1829,66 @@ struct virtchnl_fdir_del {\n \n VIRTCHNL_CHECK_STRUCT_LEN(12, virtchnl_fdir_del);\n \n+/* Status returned to VF after VF requests FSUB commands\n+ * VIRTCHNL_FSUB_SUCCESS\n+ * VF FLOW related request is successfully done by PF\n+ * The request can be OP_FLOW_SUBSCRIBE/UNSUBSCRIBE.\n+ *\n+ * VIRTCHNL_FSUB_FAILURE_RULE_NORESOURCE\n+ * OP_FLOW_SUBSCRIBE request is failed due to no Hardware resource.\n+ *\n+ * VIRTCHNL_FSUB_FAILURE_RULE_EXIST\n+ * OP_FLOW_SUBSCRIBE request is failed due to the rule is already existed.\n+ *\n+ * VIRTCHNL_FSUB_FAILURE_RULE_NONEXIST\n+ * OP_FLOW_UNSUBSCRIBE request is failed due to this rule doesn't exist.\n+ *\n+ * VIRTCHNL_FSUB_FAILURE_RULE_INVALID\n+ * OP_FLOW_SUBSCRIBE request is failed due to parameters validation\n+ * or HW doesn't support.\n+ */\n+enum virtchnl_fsub_prgm_status {\n+\tVIRTCHNL_FSUB_SUCCESS = 0,\n+\tVIRTCHNL_FSUB_FAILURE_RULE_NORESOURCE,\n+\tVIRTCHNL_FSUB_FAILURE_RULE_EXIST,\n+\tVIRTCHNL_FSUB_FAILURE_RULE_NONEXIST,\n+\tVIRTCHNL_FSUB_FAILURE_RULE_INVALID,\n+};\n+\n+/* VIRTCHNL_OP_FLOW_SUBSCRIBE\n+ * VF sends this request to PF by filling out vsi_id,\n+ * validate_only, priority, proto_hdrs and actions.\n+ * PF will return flow_id\n+ * if the request is successfully done and return status to VF.\n+ */\n+struct virtchnl_flow_sub {\n+\tu16 vsi_id; /* INPUT */\n+\tu8 validate_only; /* INPUT */\n+\t/* 0 is the highest priority; INPUT */\n+\tu8 priority;\n+\tu32 flow_id; /* OUTPUT */\n+\tstruct virtchnl_proto_hdrs proto_hdrs; /* INPUT */\n+\tstruct virtchnl_filter_action_set actions; /* INPUT */\n+\t/* see enum virtchnl_fsub_prgm_status; OUTPUT */\n+\ts32 status;\n+};\n+\n+VIRTCHNL_CHECK_STRUCT_LEN(2616, virtchnl_flow_sub);\n+\n+/* VIRTCHNL_OP_FLOW_UNSUBSCRIBE\n+ * VF sends this request to PF by filling out vsi_id\n+ * and flow_id. PF will return status to VF.\n+ */\n+struct virtchnl_flow_unsub {\n+\tu16 vsi_id; /* INPUT */\n+\tu16 pad;\n+\tu32 flow_id; /* INPUT */\n+\t/* see enum virtchnl_fsub_prgm_status; OUTPUT */\n+\ts32 status;\n+};\n+\n+VIRTCHNL_CHECK_STRUCT_LEN(12, virtchnl_flow_unsub);\n+\n /* VIRTCHNL_OP_GET_QOS_CAPS\n * VF sends this message to get its QoS Caps, such as\n * TC number, Arbiter and Bandwidth.\n@@ -2731,6 +2821,12 @@ virtchnl_vc_validate_vf_msg(struct virtchnl_version_info *ver, u32 v_opcode,\n \tcase VIRTCHNL_OP_DEL_FDIR_FILTER:\n \t\tvalid_len = sizeof(struct virtchnl_fdir_del);\n \t\tbreak;\n+\tcase VIRTCHNL_OP_FLOW_SUBSCRIBE:\n+\t\tvalid_len = sizeof(struct virtchnl_flow_sub);\n+\t\tbreak;\n+\tcase VIRTCHNL_OP_FLOW_UNSUBSCRIBE:\n+\t\tvalid_len = sizeof(struct virtchnl_flow_unsub);\n+\t\tbreak;\n \tcase VIRTCHNL_OP_GET_QOS_CAPS:\n \t\tbreak;\n \tcase VIRTCHNL_OP_CONFIG_QUEUE_TC_MAP:\n", "prefixes": [ "01/18" ] }