Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125924/?format=api
{ "id": 125924, "url": "http://patches.dpdk.org/api/patches/125924/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230411091144.1087887-19-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230411091144.1087887-19-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230411091144.1087887-19-ndabilpuram@marvell.com", "date": "2023-04-11T09:11:42", "name": "[19/21] common/cnxk: access valid pass value", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "7856503b159bd12b505e848c5f6fe618d397d313", "submitter": { "id": 1202, "url": "http://patches.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230411091144.1087887-19-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 27660, "url": "http://patches.dpdk.org/api/series/27660/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27660", "date": "2023-04-11T09:11:24", "name": "[01/21] common/cnxk: allocate dynamic BPIDs", "version": 1, "mbox": "http://patches.dpdk.org/series/27660/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125924/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125924/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F34FB4291B;\n\tTue, 11 Apr 2023 11:14:05 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 335AB42D56;\n\tTue, 11 Apr 2023 11:13:00 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 207A042D69\n for <dev@dpdk.org>; Tue, 11 Apr 2023 11:12:59 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 33B8g548014916 for <dev@dpdk.org>; Tue, 11 Apr 2023 02:12:58 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3purfs94kg-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Tue, 11 Apr 2023 02:12:58 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Tue, 11 Apr 2023 02:12:56 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Tue, 11 Apr 2023 02:12:56 -0700", "from hyd1588t430.caveonetworks.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id C86B83F706F;\n Tue, 11 Apr 2023 02:12:53 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=MmzjvofCfDTdP1mzh3IUkLuC154Th14guOmTM5PDxzs=;\n b=Q47IdfjG1hUVvh/+4rvx5Zp+bPmlC5EESEKZfHZYAn9iegVOfUxagjNN0aD0dw9DeB1W\n K8aLSPs8uxA1njpRwnhYCgz1P4lwUt0TXDZuo9rtlnm2Xla/NOR6jcWr1Gx1BRrzoiEk\n mTZPkbrxnez87bnxYlmQ2x75EdT5OsOdxMf/zpG3Y0EpOUyobfs+BJEe0pyic2Ch68FA\n n9eask71pORPt8qqKhr5lClLVNBBsFU+ORvsfMP1NRFXPf/QMbksKUz/vLKW1o4zz5B7\n 53pDBCqyu1GwNB5RASuizCr5IsBE73Mm+rfbdN9zEGjcxngQJtpe6aaSvcqO4sYX9uhC Jw==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<jerinj@marvell.com>, <dev@dpdk.org>, Hanumanth Pothula\n <hpothula@marvell.com>", "Subject": "[PATCH 19/21] common/cnxk: access valid pass value", "Date": "Tue, 11 Apr 2023 14:41:42 +0530", "Message-ID": "<20230411091144.1087887-19-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230411091144.1087887-1-ndabilpuram@marvell.com>", "References": "<20230411091144.1087887-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "TeDcfO68N8PgOI-4beyGlZhzq_DONNda", "X-Proofpoint-GUID": "TeDcfO68N8PgOI-4beyGlZhzq_DONNda", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22\n definitions=2023-04-11_05,2023-04-06_03,2023-02-09_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Hanumanth Pothula <hpothula@marvell.com>\n\nThere is a possibility of accessing an invalid pass value on\nrvu device look up failure, as the return value is dropped.\n\nHence pass through the return value of rvu device look, to make\nsure valid pass value is accessed.\n\nSigned-off-by: Hanumanth Pothula <hpothula@marvell.com>\n---\n drivers/common/cnxk/roc_model.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_model.c b/drivers/common/cnxk/roc_model.c\nindex f4f2a38e70..6dc2afe7f0 100644\n--- a/drivers/common/cnxk/roc_model.c\n+++ b/drivers/common/cnxk/roc_model.c\n@@ -148,6 +148,7 @@ cn10k_part_pass_get(uint32_t *part, uint32_t *pass)\n #define SYSFS_PCI_DEVICES \"/sys/bus/pci/devices\"\n \tchar dirname[PATH_MAX];\n \tstruct dirent *e;\n+\tint ret = -1;\n \tDIR *dir;\n \n \tdir = opendir(SYSFS_PCI_DEVICES);\n@@ -165,18 +166,19 @@ cn10k_part_pass_get(uint32_t *part, uint32_t *pass)\n \t\t\t e->d_name);\n \n \t\t/* Lookup for rvu device and get part pass information */\n-\t\tif (!rvu_device_lookup(dirname, part, pass))\n+\t\tret = rvu_device_lookup(dirname, part, pass);\n+\t\tif (!ret)\n \t\t\tbreak;\n \t}\n \n \tclosedir(dir);\n-\treturn 0;\n+\treturn ret;\n }\n \n static bool\n populate_model(struct roc_model *model, uint32_t midr)\n {\n-\tuint32_t impl, major, part, minor, pass;\n+\tuint32_t impl, major, part, minor, pass = 0;\n \tbool found = false;\n \tsize_t i;\n \n", "prefixes": [ "19/21" ] }