Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125908/?format=api
{ "id": 125908, "url": "http://patches.dpdk.org/api/patches/125908/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230411091144.1087887-3-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230411091144.1087887-3-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230411091144.1087887-3-ndabilpuram@marvell.com", "date": "2023-04-11T09:11:26", "name": "[03/21] common/cnxk: skip flow ctrl set on non-existent meta aura", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "3b546391c87cbf1aefff3a167b3b64ee2aa9fc93", "submitter": { "id": 1202, "url": "http://patches.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230411091144.1087887-3-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 27660, "url": "http://patches.dpdk.org/api/series/27660/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27660", "date": "2023-04-11T09:11:24", "name": "[01/21] common/cnxk: allocate dynamic BPIDs", "version": 1, "mbox": "http://patches.dpdk.org/series/27660/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125908/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125908/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4C8914291B;\n\tTue, 11 Apr 2023 11:12:20 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D1DBE42BC9;\n\tTue, 11 Apr 2023 11:12:12 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id DA0BE42BAC\n for <dev@dpdk.org>; Tue, 11 Apr 2023 11:12:11 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 33B8SvlB021524; Tue, 11 Apr 2023 02:12:11 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3pvt73b1s2-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 11 Apr 2023 02:12:10 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Tue, 11 Apr 2023 02:12:09 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Tue, 11 Apr 2023 02:12:08 -0700", "from hyd1588t430.caveonetworks.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id 97EF73F706A;\n Tue, 11 Apr 2023 02:12:06 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=MqQdwTqy2PyVS7AEduFc1KUQCE64n3oo+dglHHUn+MU=;\n b=eDvFKaUvr+s/phcipqL3caAKt4h07/bpyGcFKGGCDaNqgFZwQfidf60W7GQ71A3VQb01\n 9VzzPMPRMYpzIy3BkfwvoqlajXKW/CJKthDz4QzkwStMVQXUrKB6QIubeXbbXtUGZOWn\n UYEF4cIIz+G32CNePcl2pnx6ZQiWSNrKMxndzAqxKC3szGbOgSNE+NoG3tDUilD1fE8I\n QegcJu0mn61x8sy4iujvhs8JQHXkKHz6nhXJPbjX2s9ZHN4gG2aTAkbwM83gngIkcmIh\n jHLjqYSqi9uVzI4DQur2apP62t6zrDrjXcVfnPmHLl4BroIKgOpcrZutptsAxL70j+rr 0g==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "Thomas Monjalon <thomas@monjalon.net>, Nithin Kumar Dabilpuram\n <ndabilpuram@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>, \"Sunil\n Kumar Kori\" <skori@marvell.com>, Satha Rao <skoteshwar@marvell.com>", "CC": "<jerinj@marvell.com>, <dev@dpdk.org>", "Subject": "[PATCH 03/21] common/cnxk: skip flow ctrl set on non-existent meta\n aura", "Date": "Tue, 11 Apr 2023 14:41:26 +0530", "Message-ID": "<20230411091144.1087887-3-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230411091144.1087887-1-ndabilpuram@marvell.com>", "References": "<20230411091144.1087887-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "JxoVK_YqsN2Wj2G63dvr4R5QiyHrjs2l", "X-Proofpoint-ORIG-GUID": "JxoVK_YqsN2Wj2G63dvr4R5QiyHrjs2l", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22\n definitions=2023-04-11_05,2023-04-06_03,2023-02-09_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Skip setting flow control on local meta aura if it is not yet\ncreated. Also in flow control mode set, do get to confirm\nif it is in same state to avoid a set and unnecessary mbox\nfailures.\n\nSigned-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>\n---\n .mailmap | 1 +\n drivers/common/cnxk/roc_dev.c | 1 +\n drivers/common/cnxk/roc_nix_fc.c | 4 ++--\n drivers/common/cnxk/roc_nix_inl.c | 3 +++\n drivers/net/cnxk/cnxk_ethdev.c | 5 +++--\n drivers/net/cnxk/cnxk_ethdev_ops.c | 4 ++++\n 6 files changed, 14 insertions(+), 4 deletions(-)", "diff": "diff --git a/.mailmap b/.mailmap\nindex 0859104404..be2eddf1b3 100644\n--- a/.mailmap\n+++ b/.mailmap\n@@ -988,6 +988,7 @@ Nipun Gupta <nipun.gupta@nxp.com>\n Nir Efrati <nir.efrati@intel.com>\n Nirmoy Das <ndas@suse.de>\n Nithin Dabilpuram <ndabilpuram@marvell.com> <nithin.dabilpuram@caviumnetworks.com>\n+Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>\n Nitin Saxena <nitin.saxena@caviumnetworks.com>\n Nitzan Weller <nitzanwe@mellanox.com>\n Noa Ezra <noae@mellanox.com>\ndiff --git a/drivers/common/cnxk/roc_dev.c b/drivers/common/cnxk/roc_dev.c\nindex 2388237186..5e4e564ebe 100644\n--- a/drivers/common/cnxk/roc_dev.c\n+++ b/drivers/common/cnxk/roc_dev.c\n@@ -421,6 +421,7 @@ process_msgs(struct dev *dev, struct mbox *mbox)\n \t\t\tdev->pf_func = msg->pcifunc;\n \t\t\tbreak;\n \t\tcase MBOX_MSG_CGX_PRIO_FLOW_CTRL_CFG:\n+\t\tcase MBOX_MSG_CGX_CFG_PAUSE_FRM:\n \t\t\t/* Handling the case where one VF tries to disable PFC\n \t\t\t * while PFC already configured on other VFs. This is\n \t\t\t * not an error but a warning which can be ignored.\ndiff --git a/drivers/common/cnxk/roc_nix_fc.c b/drivers/common/cnxk/roc_nix_fc.c\nindex 8b7659fb9a..3618d2920b 100644\n--- a/drivers/common/cnxk/roc_nix_fc.c\n+++ b/drivers/common/cnxk/roc_nix_fc.c\n@@ -311,7 +311,7 @@ nix_fc_rq_config_set(struct roc_nix *roc_nix, struct roc_nix_fc_cfg *fc_cfg)\n \t\t\t\t fc_cfg->rq_cfg.enable, true,\n \t\t\t\t fc_cfg->rq_cfg.tc);\n \n-\t\tif (roc_nix->local_meta_aura_ena)\n+\t\tif (roc_nix->local_meta_aura_ena && roc_nix->meta_aura_handle)\n \t\t\troc_nix_fc_npa_bp_cfg(roc_nix, roc_nix->meta_aura_handle,\n \t\t\t\t\t fc_cfg->rq_cfg.enable, true, fc_cfg->rq_cfg.tc);\n \t}\n@@ -409,6 +409,7 @@ roc_nix_fc_mode_set(struct roc_nix *roc_nix, enum roc_nix_fc_mode mode)\n \t\tgoto exit;\n \t}\n \n+\t/* Set new config */\n \treq = mbox_alloc_msg_cgx_cfg_pause_frm(mbox);\n \tif (req == NULL)\n \t\tgoto exit;\n@@ -422,7 +423,6 @@ roc_nix_fc_mode_set(struct roc_nix *roc_nix, enum roc_nix_fc_mode mode)\n \n \tnix->rx_pause = rx_pause;\n \tnix->tx_pause = tx_pause;\n-\n exit:\n \tmbox_put(mbox);\n \treturn rc;\ndiff --git a/drivers/common/cnxk/roc_nix_inl.c b/drivers/common/cnxk/roc_nix_inl.c\nindex 9485bba099..b16756d642 100644\n--- a/drivers/common/cnxk/roc_nix_inl.c\n+++ b/drivers/common/cnxk/roc_nix_inl.c\n@@ -131,6 +131,9 @@ nix_inl_meta_aura_create(struct idev_cfg *idev, struct roc_nix *roc_nix, uint16_\n \t}\n \troc_nix->meta_mempool = mp;\n \n+\tplt_nix_dbg(\"Created meta aura %p(%s)for port %d\", (void *)*meta_aura, mp_name,\n+\t\t roc_nix->port_id);\n+\n \tif (!roc_nix->local_meta_aura_ena) {\n \t\tinl_cfg->buf_sz = buf_sz;\n \t\tinl_cfg->nb_bufs = nb_bufs;\ndiff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c\nindex 1cae3084e1..3bccc34d79 100644\n--- a/drivers/net/cnxk/cnxk_ethdev.c\n+++ b/drivers/net/cnxk/cnxk_ethdev.c\n@@ -378,8 +378,9 @@ nix_init_flow_ctrl_config(struct rte_eth_dev *eth_dev)\n \tif (rc)\n \t\treturn rc;\n \n-\tfc->mode = (fc_mode == ROC_NIX_FC_FULL) ? RTE_ETH_FC_FULL :\n-\t\t\t\t\t\t RTE_ETH_FC_TX_PAUSE;\n+\tfc->mode = (fc_mode == ROC_NIX_FC_FULL) ? RTE_ETH_FC_FULL : RTE_ETH_FC_TX_PAUSE;\n+\tfc->rx_pause = (fc->mode == RTE_ETH_FC_FULL) || (fc->mode == RTE_ETH_FC_RX_PAUSE);\n+\tfc->tx_pause = (fc->mode == RTE_ETH_FC_FULL) || (fc->mode == RTE_ETH_FC_TX_PAUSE);\n \treturn rc;\n }\n \ndiff --git a/drivers/net/cnxk/cnxk_ethdev_ops.c b/drivers/net/cnxk/cnxk_ethdev_ops.c\nindex 068b7c3502..bce6d59bbc 100644\n--- a/drivers/net/cnxk/cnxk_ethdev_ops.c\n+++ b/drivers/net/cnxk/cnxk_ethdev_ops.c\n@@ -342,6 +342,10 @@ cnxk_nix_flow_ctrl_set(struct rte_eth_dev *eth_dev,\n \t\t\treturn rc;\n \t}\n \n+\t/* Skip mode set if it is we are in same state */\n+\tif (fc->rx_pause == rx_pause && fc->tx_pause == tx_pause)\n+\t\treturn 0;\n+\n \trc = roc_nix_fc_mode_set(nix, mode_map[fc_conf->mode]);\n \tif (rc)\n \t\treturn rc;\n", "prefixes": [ "03/21" ] }