Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125859/?format=api
{ "id": 125859, "url": "http://patches.dpdk.org/api/patches/125859/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230407085041.3966259-1-zhoumin@loongson.cn/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230407085041.3966259-1-zhoumin@loongson.cn>", "list_archive_url": "https://inbox.dpdk.org/dev/20230407085041.3966259-1-zhoumin@loongson.cn", "date": "2023-04-07T08:50:41", "name": "[1/1] net/ixgbe: add a proper memory barrier for LoongArch", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c2f427090a283fdeb32bb131c4956a3255acbed6", "submitter": { "id": 2394, "url": "http://patches.dpdk.org/api/people/2394/?format=api", "name": "zhoumin", "email": "zhoumin@loongson.cn" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230407085041.3966259-1-zhoumin@loongson.cn/mbox/", "series": [ { "id": 27644, "url": "http://patches.dpdk.org/api/series/27644/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27644", "date": "2023-04-07T08:50:41", "name": "[1/1] net/ixgbe: add a proper memory barrier for LoongArch", "version": 1, "mbox": "http://patches.dpdk.org/series/27644/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125859/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125859/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 22692428E5;\n\tFri, 7 Apr 2023 10:50:53 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EF55A40E03;\n\tFri, 7 Apr 2023 10:50:52 +0200 (CEST)", "from loongson.cn (mail.loongson.cn [114.242.206.163])\n by mails.dpdk.org (Postfix) with ESMTP id 9D0A940150\n for <dev@dpdk.org>; Fri, 7 Apr 2023 10:50:51 +0200 (CEST)", "from loongson.cn (unknown [10.2.5.185])\n by gateway (Coremail) with SMTP id _____8DxUOVo2S9kUskXAA--.36832S3;\n Fri, 07 Apr 2023 16:50:48 +0800 (CST)", "from localhost.localdomain (unknown [10.2.5.185])\n by localhost.localdomain (Coremail) with SMTP id\n AQAAf8Dxhbxi2S9kuyIYAA--.21696S2;\n Fri, 07 Apr 2023 16:50:47 +0800 (CST)" ], "From": "Min Zhou <zhoumin@loongson.cn>", "To": "qiming.yang@intel.com,\n\twenjun1.wu@intel.com,\n\tzhoumin@loongson.cn", "Cc": "dev@dpdk.org,\n\tmaobibo@loongson.cn", "Subject": "[PATCH 1/1] net/ixgbe: add a proper memory barrier for LoongArch", "Date": "Fri, 7 Apr 2023 16:50:41 +0800", "Message-Id": "<20230407085041.3966259-1-zhoumin@loongson.cn>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "AQAAf8Dxhbxi2S9kuyIYAA--.21696S2", "X-CM-SenderInfo": "52kr3ztlq6z05rqj20fqof0/", "X-Coremail-Antispam": "1Uk129KBjvJXoW7Zr45AFy3uw1UAw1fKrW3Jrb_yoW8GrW7pF\n s8Gr1I9ryUXw47C3s2q395ur9xCF4SqryUWrZ2y3s0934qq3yjqwn0qFyYvryDtr4UuF1f\n ZF47Zw45Ga9xZrUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUj1kv1TuYvTs0mT0YCTnIWj\n qI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUU\n b0kFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wA2ocxC64kIII0Yj41l84x0c7CEw4\n AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF\n 7I0E14v26r4j6F4UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x\n 0267AKxVWxJr0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE\n 44I27wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E74AGY7Cv6cx26rWlOx8S6xCaFVCjc4\n AY6r1j6r4UM4x0Y48IcxkI7VAKI48JMxAIw28IcxkI7VAKI48JMxAIw28IcVCjz48v1sIE\n Y20_WwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E74\n 80Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0\n I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04\n k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7Cj\n xVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7xRE6wZ7UUUUU==", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Segmentation fault has been observed while running the\nixgbe_recv_pkts_lro() function to receive packets on the Loongson\n3C5000 processor which has 64 cores and 4 NUMA nodes.\n\nReason is the read ordering of the status and the rest of the\ndescriptor fields in this function may not be correct on the\nLoongArch processor. We should add rte_rmb() to ensure the read\nordering be correct.\n\nWe also did the same thing in the ixgbe_recv_pkts() function.\n\nSigned-off-by: Min Zhou <zhoumin@loongson.cn>\n---\n drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c\nindex c9d6ca9efe..16391a42f9 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx.c\n@@ -1823,6 +1823,9 @@ ixgbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\tstaterr = rxdp->wb.upper.status_error;\n \t\tif (!(staterr & rte_cpu_to_le_32(IXGBE_RXDADV_STAT_DD)))\n \t\t\tbreak;\n+#if defined(RTE_ARCH_LOONGARCH)\n+\t\trte_rmb();\n+#endif\n \t\trxd = *rxdp;\n \n \t\t/*\n@@ -2122,6 +2125,9 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts,\n \t\tif (!(staterr & IXGBE_RXDADV_STAT_DD))\n \t\t\tbreak;\n \n+#if defined(RTE_ARCH_LOONGARCH)\n+\t\trte_rmb();\n+#endif\n \t\trxd = *rxdp;\n \n \t\tPMD_RX_LOG(DEBUG, \"port_id=%u queue_id=%u rx_id=%u \"\n", "prefixes": [ "1/1" ] }