Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 12584,
    "url": "http://patches.dpdk.org/api/patches/12584/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1462562780-47991-40-git-send-email-stephen.hurd@broadcom.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1462562780-47991-40-git-send-email-stephen.hurd@broadcom.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1462562780-47991-40-git-send-email-stephen.hurd@broadcom.com",
    "date": "2016-05-06T19:26:20",
    "name": "[dpdk-dev,40/40] bnxt: cleanup null pointer checks",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "e526a15750322cbe9fecac9f78fd2a6dbf31cdc1",
    "submitter": {
        "id": 438,
        "url": "http://patches.dpdk.org/api/people/438/?format=api",
        "name": "Stephen Hurd",
        "email": "stephen.hurd@broadcom.com"
    },
    "delegate": {
        "id": 10,
        "url": "http://patches.dpdk.org/api/users/10/?format=api",
        "username": "bruce",
        "first_name": "Bruce",
        "last_name": "Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1462562780-47991-40-git-send-email-stephen.hurd@broadcom.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/12584/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/12584/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 24E256CA3;\n\tFri,  6 May 2016 21:27:22 +0200 (CEST)",
            "from mail-gw2-out.broadcom.com (mail-gw2-out.broadcom.com\n\t[216.31.210.63]) by dpdk.org (Postfix) with ESMTP id 62D565AB9\n\tfor <dev@dpdk.org>; Fri,  6 May 2016 21:27:10 +0200 (CEST)",
            "from mail-irv-18.broadcom.com ([10.15.198.37])\n\tby mail-gw2-out.broadcom.com with ESMTP; 06 May 2016 12:41:06 -0700",
            "from mail-irva-12.broadcom.com (mail-irva-12.broadcom.com\n\t[10.11.16.101])\n\tby mail-irv-18.broadcom.com (Postfix) with ESMTP id DE56F82023\n\tfor <dev@dpdk.org>; Fri,  6 May 2016 12:26:56 -0700 (PDT)",
            "from DPDK-C1.broadcom.com (dhcp-10-13-115-104.irv.broadcom.com\n\t[10.13.115.104])\n\tby mail-irva-12.broadcom.com (Postfix) with ESMTP id 84D3012762E\n\tfor <dev@dpdk.org>; Fri,  6 May 2016 12:26:53 -0700 (PDT)"
        ],
        "X-IronPort-AV": "E=Sophos;i=\"5.24,587,1455004800\"; d=\"scan'208\";a=\"94860669\"",
        "From": "Stephen Hurd <stephen.hurd@broadcom.com>",
        "To": "dev@dpdk.org",
        "Date": "Fri,  6 May 2016 12:26:20 -0700",
        "Message-Id": "<1462562780-47991-40-git-send-email-stephen.hurd@broadcom.com>",
        "X-Mailer": "git-send-email 1.9.1",
        "In-Reply-To": "<1462562780-47991-1-git-send-email-stephen.hurd@broadcom.com>",
        "References": "<20160421100005.GA976@bricha3-MOBL3>\n\t<1462562780-47991-1-git-send-email-stephen.hurd@broadcom.com>",
        "Subject": "[dpdk-dev] [PATCH 40/40] bnxt: cleanup null pointer checks",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Prefer !ptr to ptr == NULL\n\nSigned-off-by: Stephen Hurd <stephen.hurd@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 10 +++++-----\n drivers/net/bnxt/bnxt_filter.c |  2 +-\n drivers/net/bnxt/bnxt_hwrm.c   |  6 +++---\n drivers/net/bnxt/bnxt_ring.c   |  2 +-\n drivers/net/bnxt/bnxt_vnic.c   |  2 +-\n 5 files changed, 11 insertions(+), 11 deletions(-)",
    "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 93dac7a..2f1a85a 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -535,7 +535,7 @@ static void bnxt_promiscuous_enable_op(struct rte_eth_dev *eth_dev)\n \tstruct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;\n \tstruct bnxt_vnic_info *vnic;\n \n-\tif (bp->vnic_info == NULL)\n+\tif (!bp->vnic_info)\n \t\treturn;\n \n \tvnic = &bp->vnic_info[0];\n@@ -549,7 +549,7 @@ static void bnxt_promiscuous_disable_op(struct rte_eth_dev *eth_dev)\n \tstruct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;\n \tstruct bnxt_vnic_info *vnic;\n \n-\tif (bp->vnic_info == NULL)\n+\tif (!bp->vnic_info)\n \t\treturn;\n \n \tvnic = &bp->vnic_info[0];\n@@ -563,7 +563,7 @@ static void bnxt_allmulticast_enable_op(struct rte_eth_dev *eth_dev)\n \tstruct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;\n \tstruct bnxt_vnic_info *vnic;\n \n-\tif (bp->vnic_info == NULL)\n+\tif (!bp->vnic_info)\n \t\treturn;\n \n \tvnic = &bp->vnic_info[0];\n@@ -577,7 +577,7 @@ static void bnxt_allmulticast_disable_op(struct rte_eth_dev *eth_dev)\n \tstruct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;\n \tstruct bnxt_vnic_info *vnic;\n \n-\tif (bp->vnic_info == NULL)\n+\tif (!bp->vnic_info)\n \t\treturn;\n \n \tvnic = &bp->vnic_info[0];\n@@ -955,7 +955,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \t}\n \teth_dev->data->mac_addrs = rte_zmalloc(\"bnxt_mac_addr_tbl\",\n \t\t\t\t\tETHER_ADDR_LEN * MAX_NUM_MAC_ADDR, 0);\n-\tif (eth_dev->data->mac_addrs == NULL) {\n+\tif (!eth_dev->data->mac_addrs) {\n \t\tRTE_LOG(ERR, PMD,\n \t\t\t\"Failed to alloc %u bytes needed to store MAC addr tbl\",\n \t\t\tETHER_ADDR_LEN * MAX_NUM_MAC_ADDR);\ndiff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c\nindex f03a1dc..d2576f7 100644\n--- a/drivers/net/bnxt/bnxt_filter.c\n+++ b/drivers/net/bnxt/bnxt_filter.c\n@@ -165,7 +165,7 @@ int bnxt_alloc_filter_mem(struct bnxt *bp)\n \tfilter_mem = rte_zmalloc(\"bnxt_filter_info\",\n \t\t\t\t max_filters * sizeof(struct bnxt_filter_info),\n \t\t\t\t 0);\n-\tif (filter_mem == NULL) {\n+\tif (!filter_mem) {\n \t\tRTE_LOG(ERR, PMD, \"Failed to alloc memory for %d filters\",\n \t\t\tmax_filters);\n \t\treturn -ENOMEM;\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 1a1f108..8994c47 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -431,7 +431,7 @@ int bnxt_hwrm_ver_get(struct bnxt *bp)\n \t\trte_free(bp->hwrm_cmd_resp_addr);\n \n \t\tbp->hwrm_cmd_resp_addr = rte_malloc(type, max_resp_len, 0);\n-\t\tif (bp->hwrm_cmd_resp_addr == NULL) {\n+\t\tif (!bp->hwrm_cmd_resp_addr) {\n \t\t\trc = -ENOMEM;\n \t\t\tgoto error;\n \t\t}\n@@ -1171,7 +1171,7 @@ int bnxt_alloc_hwrm_resources(struct bnxt *bp)\n \tbp->max_req_len = HWRM_MAX_REQ_LEN;\n \tbp->max_resp_len = HWRM_MAX_RESP_LEN;\n \tbp->hwrm_cmd_resp_addr = rte_malloc(type, bp->max_resp_len, 0);\n-\tif (bp->hwrm_cmd_resp_addr == NULL)\n+\tif (!bp->hwrm_cmd_resp_addr)\n \t\treturn -ENOMEM;\n \tbp->hwrm_cmd_resp_dma_addr =\n \t\trte_malloc_virt2phy(bp->hwrm_cmd_resp_addr);\n@@ -1211,7 +1211,7 @@ void bnxt_free_all_hwrm_resources(struct bnxt *bp)\n \tstruct bnxt_vnic_info *vnic;\n \tunsigned i;\n \n-\tif (bp->vnic_info == NULL)\n+\tif (!bp->vnic_info)\n \t\treturn;\n \n \tvnic = &bp->vnic_info[0];\ndiff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c\nindex 8852e28..91f6371 100644\n--- a/drivers/net/bnxt/bnxt_ring.c\n+++ b/drivers/net/bnxt/bnxt_ring.c\n@@ -143,7 +143,7 @@ int bnxt_alloc_rings(struct bnxt *bp, uint16_t qidx,\n \t\t\t\t\t SOCKET_ID_ANY,\n \t\t\t\t\t RTE_MEMZONE_2MB |\n \t\t\t\t\t RTE_MEMZONE_SIZE_HINT_ONLY);\n-\t\tif (mz == NULL)\n+\t\tif (!mz)\n \t\t\treturn -ENOMEM;\n \t}\n \tmemset(mz->addr, 0, mz->len);\ndiff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c\nindex c04c4c7..e957c0d 100644\n--- a/drivers/net/bnxt/bnxt_vnic.c\n+++ b/drivers/net/bnxt/bnxt_vnic.c\n@@ -267,7 +267,7 @@ int bnxt_alloc_vnic_mem(struct bnxt *bp)\n \t/* Allocate memory for VNIC pool and filter pool */\n \tvnic_mem = rte_zmalloc(\"bnxt_vnic_info\",\n \t\t\t       max_vnics * sizeof(struct bnxt_vnic_info), 0);\n-\tif (vnic_mem == NULL) {\n+\tif (!vnic_mem) {\n \t\tRTE_LOG(ERR, PMD, \"Failed to alloc memory for %d VNICs\",\n \t\t\tmax_vnics);\n \t\treturn -ENOMEM;\n",
    "prefixes": [
        "dpdk-dev",
        "40/40"
    ]
}