Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125834/?format=api
{ "id": 125834, "url": "http://patches.dpdk.org/api/patches/125834/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1680741919-22102-11-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1680741919-22102-11-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1680741919-22102-11-git-send-email-roretzla@linux.microsoft.com", "date": "2023-04-06T00:45:18", "name": "[v3,10/11] telemetry: disable json print formatting with msvc", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1007eea7f39bfafabe52358cc852a1b219891857", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1680741919-22102-11-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 27633, "url": "http://patches.dpdk.org/api/series/27633/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27633", "date": "2023-04-06T00:45:11", "name": "msvc integration changes", "version": 3, "mbox": "http://patches.dpdk.org/series/27633/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125834/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125834/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3A78F428D0;\n\tThu, 6 Apr 2023 02:46:07 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CCD7342D3B;\n\tThu, 6 Apr 2023 02:45:30 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id EEDF742BB1\n for <dev@dpdk.org>; Thu, 6 Apr 2023 02:45:22 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 9AA98210DF05; Wed, 5 Apr 2023 17:45:21 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 9AA98210DF05", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1680741921;\n bh=UdRl6E4dhDfTdvJ/Ndp/1r/2c9CLJI/CsNAgZ1wnSmA=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=c9rV3Poq+iPGFOwEbXc7dfDWluT4RgkpxHv/tiJq8Z9cDmPpq1uMJAziLzJ6vT0h9\n 8lTH+zMQsFCTv65IHvlyu/Gn6hT6yJFV8xMMX9c2Us8ZbRoxB4FcWjSz3nQqPcZmxp\n P8j0nIalHDn57gmj1RUm29WuYNObxg5fZNgIRsOk=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, david.marchand@redhat.com,\n thomas@monjalon.net,\n mb@smartsharesystems.com, konstantin.ananyev@huawei.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v3 10/11] telemetry: disable json print formatting with msvc", "Date": "Wed, 5 Apr 2023 17:45:18 -0700", "Message-Id": "<1680741919-22102-11-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1680741919-22102-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com>\n <1680741919-22102-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "VLAs are unsafe and will never be implemented in MSVC. When compiling\nwith MSVC just return immediately indicating 0 output characters\nformatted.\n\nFor now telemetry doesn't work on Windows, we will revisit support for\nthe telemetry library sometime after we establish the DPDK unit tests.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/telemetry/telemetry_json.h | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/lib/telemetry/telemetry_json.h b/lib/telemetry/telemetry_json.h\nindex 744bbfe..d847003 100644\n--- a/lib/telemetry/telemetry_json.h\n+++ b/lib/telemetry/telemetry_json.h\n@@ -30,6 +30,7 @@\n static inline int\n __json_snprintf(char *buf, const int len, const char *format, ...)\n {\n+#ifndef RTE_TOOLCHAIN_MSVC\n \tchar tmp[len];\n \tva_list ap;\n \tint ret;\n@@ -41,6 +42,7 @@\n \t\tstrcpy(buf, tmp);\n \t\treturn ret;\n \t}\n+#endif\n \treturn 0; /* nothing written or modified */\n }\n \n@@ -60,6 +62,7 @@\n static inline int\n __json_format_str(char *buf, const int len, const char *prefix, const char *str, const char *suffix)\n {\n+#ifndef RTE_TOOLCHAIN_MSVC\n \tchar tmp[len];\n \tint tmpidx = 0;\n \n@@ -98,6 +101,9 @@\n \n \tstrcpy(buf, tmp);\n \treturn tmpidx;\n+#else\n+\treturn 0;\n+#endif\n }\n \n /* Copies an empty array into the provided buffer. */\n", "prefixes": [ "v3", "10/11" ] }