Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125827/?format=api
http://patches.dpdk.org/api/patches/125827/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1680741919-22102-4-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1680741919-22102-4-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1680741919-22102-4-git-send-email-roretzla@linux.microsoft.com", "date": "2023-04-06T00:45:11", "name": "[v3,03/11] eal: use barrier intrinsics when compiling with msvc", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1addcb2bfd78e587e6b0a7946df2e1b36fb9bd4d", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1680741919-22102-4-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 27633, "url": "http://patches.dpdk.org/api/series/27633/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27633", "date": "2023-04-06T00:45:11", "name": "msvc integration changes", "version": 3, "mbox": "http://patches.dpdk.org/series/27633/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125827/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125827/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2F13E428D0;\n\tThu, 6 Apr 2023 02:45:23 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EE32C42BAC;\n\tThu, 6 Apr 2023 02:45:22 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id F16B340F18\n for <dev@dpdk.org>; Thu, 6 Apr 2023 02:45:21 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 44168210DEFB; Wed, 5 Apr 2023 17:45:21 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 44168210DEFB", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1680741921;\n bh=cEj+2X1bc/tb0SfKlg2j1xXB7Wh9mICLzC8juNL2AUc=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=pQJsz5aqCpkms8alwjRudwTO+naPPlJv9FYfnH5H+FDVGm9Jj9ZYadlwDQGb0mYm9\n h7ece1HQOAHK/1mONx8HUeGDBMjDy/TXTTsAk/dDe9Y0+3ruFo+tAk17jGOGLWxtqN\n chdjJFZLSB68kwM9LJSxBR7h1FqxoAgoLPt/E3+Y=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, david.marchand@redhat.com,\n thomas@monjalon.net,\n mb@smartsharesystems.com, konstantin.ananyev@huawei.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v3 03/11] eal: use barrier intrinsics when compiling with msvc", "Date": "Wed, 5 Apr 2023 17:45:11 -0700", "Message-Id": "<1680741919-22102-4-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1680741919-22102-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com>\n <1680741919-22102-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Inline assembly is not supported for msvc x64 instead expand\nrte_compiler_barrier as _ReadWriteBarrier and for rte_smp_mb\n_m_mfence intrinsics.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/eal/include/generic/rte_atomic.h | 4 ++++\n lib/eal/x86/include/rte_atomic.h | 5 ++++-\n 2 files changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/eal/include/generic/rte_atomic.h b/lib/eal/include/generic/rte_atomic.h\nindex 234b268..e973184 100644\n--- a/lib/eal/include/generic/rte_atomic.h\n+++ b/lib/eal/include/generic/rte_atomic.h\n@@ -116,9 +116,13 @@\n * Guarantees that operation reordering does not occur at compile time\n * for operations directly before and after the barrier.\n */\n+#ifndef RTE_TOOLCHAIN_MSVC\n #define\trte_compiler_barrier() do {\t\t\\\n \tasm volatile (\"\" : : : \"memory\");\t\\\n } while(0)\n+#else\n+#define rte_compiler_barrier() _ReadWriteBarrier()\n+#endif\n \n /**\n * Synchronization fence between threads based on the specified memory order.\ndiff --git a/lib/eal/x86/include/rte_atomic.h b/lib/eal/x86/include/rte_atomic.h\nindex f2ee1a9..ca733c5 100644\n--- a/lib/eal/x86/include/rte_atomic.h\n+++ b/lib/eal/x86/include/rte_atomic.h\n@@ -28,7 +28,6 @@\n #define\trte_rmb() _mm_lfence()\n \n #define rte_smp_wmb() rte_compiler_barrier()\n-\n #define rte_smp_rmb() rte_compiler_barrier()\n \n /*\n@@ -66,11 +65,15 @@\n static __rte_always_inline void\n rte_smp_mb(void)\n {\n+#ifndef RTE_TOOLCHAIN_MSVC\n #ifdef RTE_ARCH_I686\n \tasm volatile(\"lock addl $0, -128(%%esp); \" ::: \"memory\");\n #else\n \tasm volatile(\"lock addl $0, -128(%%rsp); \" ::: \"memory\");\n #endif\n+#else\n+\t_mm_mfence();\n+#endif\n }\n \n #define rte_io_mb() rte_mb()\n", "prefixes": [ "v3", "03/11" ] }{ "id": 125827, "url": "