Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125807/?format=api
{ "id": 125807, "url": "http://patches.dpdk.org/api/patches/125807/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230405142537.1899973-7-sedara@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230405142537.1899973-7-sedara@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230405142537.1899973-7-sedara@marvell.com", "date": "2023-04-05T14:25:32", "name": "[v2,06/10] net/octeon_ep: fix DMA incompletion", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "bc8f3869c7635f2a92475d52c9606ab52273a2ab", "submitter": { "id": 2729, "url": "http://patches.dpdk.org/api/people/2729/?format=api", "name": "Sathesh B Edara", "email": "sedara@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230405142537.1899973-7-sedara@marvell.com/mbox/", "series": [ { "id": 27627, "url": "http://patches.dpdk.org/api/series/27627/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27627", "date": "2023-04-05T14:25:26", "name": "extend octeon ep driver functionality", "version": 2, "mbox": "http://patches.dpdk.org/series/27627/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125807/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125807/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A7703428D4;\n\tWed, 5 Apr 2023 16:26:31 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D140342D3D;\n\tWed, 5 Apr 2023 16:25:54 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 09F7C42C4D\n for <dev@dpdk.org>; Wed, 5 Apr 2023 16:25:52 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 3357OLOC007019 for <dev@dpdk.org>; Wed, 5 Apr 2023 07:25:52 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3ps4jpjbht-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Wed, 05 Apr 2023 07:25:52 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Wed, 5 Apr 2023 07:25:50 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Wed, 5 Apr 2023 07:25:50 -0700", "from localhost.marvell.com (unknown [10.106.27.249])\n by maili.marvell.com (Postfix) with ESMTP id 463E43F7050;\n Wed, 5 Apr 2023 07:25:50 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=tUOxGFhthRmHBhFa4RE24L8wNzw2yu4oMliLz14QBsc=;\n b=E0AyVRIc+eVNuINORbyo+6TdBR19B8SPHjoUBAfQas34X4QwHEgkx6VfM/Jm4tsQt8DM\n +oFqgq5n1TXvVJ8BAVWUyjdrtBQQlgIOQDVvWl1mst4kudl53OQU5DjtLCIUPimgJv27\n xaqwTEjO3J14+oMzYkwnaPozI7ymFyf2kgFw2HodUYh5lTvnr2q39eM20lOjtYW/vcHL\n JxUogmqrzXf6JtdOXBSNoH6vuXYVqhssjDr37Qf3BTdEWTVLcc8pW16sApAZq6TJ+dOH\n LK6+WOu5R8/EXB7AkCPXTWCmuhpiDkHUT2I5EV+PYJYQvpF+oeniaRiM1bZykeANmrfV jA==", "From": "Sathesh Edara <sedara@marvell.com>", "To": "<sburla@marvell.com>, <jerinj@marvell.com>, <sedara@marvell.com>, \"Radha\n Mohan Chintakuntla\" <radhac@marvell.com>, Veerasenareddy Burru\n <vburru@marvell.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH v2 06/10] net/octeon_ep: fix DMA incompletion", "Date": "Wed, 5 Apr 2023 07:25:32 -0700", "Message-ID": "<20230405142537.1899973-7-sedara@marvell.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20230405142537.1899973-1-sedara@marvell.com>", "References": "<20230404141855.1025625-2-sedara@marvell.com>\n <20230405142537.1899973-1-sedara@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "RuKdzB0zxY7M4XbuhrfMfxYW5pOWUaI7", "X-Proofpoint-ORIG-GUID": "RuKdzB0zxY7M4XbuhrfMfxYW5pOWUaI7", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22\n definitions=2023-04-05_09,2023-04-05_01,2023-02-09_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch fixes the DMA incompletion\nduring packet reads.\n\nSigned-off-by: Sathesh Edara <sedara@marvell.com>\n---\n drivers/net/octeon_ep/otx_ep_common.h | 8 ++++++++\n drivers/net/octeon_ep/otx_ep_rxtx.c | 4 ++++\n 2 files changed, 12 insertions(+)", "diff": "diff --git a/drivers/net/octeon_ep/otx_ep_common.h b/drivers/net/octeon_ep/otx_ep_common.h\nindex 76528ed49d..1d9da5954e 100644\n--- a/drivers/net/octeon_ep/otx_ep_common.h\n+++ b/drivers/net/octeon_ep/otx_ep_common.h\n@@ -345,6 +345,14 @@ struct otx_ep_droq {\n \t */\n \tvoid *pkts_sent_reg;\n \n+\t/** Fix for DMA incompletion during pkt reads.\n+\t * This variable is used to initiate a sent_reg_read\n+\t * that completes pending dma\n+\t * this variable is used as lvalue so compiler cannot optimize\n+\t * the reads.\n+\t */\n+\tuint32_t sent_reg_val;\n+\n \t/* Statistics for this DROQ. */\n \tstruct otx_ep_droq_stats stats;\n \ndiff --git a/drivers/net/octeon_ep/otx_ep_rxtx.c b/drivers/net/octeon_ep/otx_ep_rxtx.c\nindex c4153bd583..ca968f6fe7 100644\n--- a/drivers/net/octeon_ep/otx_ep_rxtx.c\n+++ b/drivers/net/octeon_ep/otx_ep_rxtx.c\n@@ -917,6 +917,10 @@ otx_ep_droq_read_packet(struct otx_ep_device *otx_ep,\n \t\tstruct rte_mbuf *first_buf = NULL;\n \t\tstruct rte_mbuf *last_buf = NULL;\n \n+\t\t/* csr read helps to flush pending dma */\n+\t\tdroq->sent_reg_val = rte_read32(droq->pkts_sent_reg);\n+\t\trte_rmb();\n+\n \t\twhile (pkt_len < total_pkt_len) {\n \t\t\tint cpy_len = 0;\n \n", "prefixes": [ "v2", "06/10" ] }