Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125792/?format=api
{ "id": 125792, "url": "http://patches.dpdk.org/api/patches/125792/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1680638847-26430-10-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1680638847-26430-10-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1680638847-26430-10-git-send-email-roretzla@linux.microsoft.com", "date": "2023-04-04T20:07:27", "name": "[v2,9/9] telemetry: avoid expanding versioned symbol macros on msvc", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "691a4c4575c7cb4d6fdeaa6f5093d249f1f8aa1a", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1680638847-26430-10-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 27622, "url": "http://patches.dpdk.org/api/series/27622/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27622", "date": "2023-04-04T20:07:18", "name": "msvc integration changes", "version": 2, "mbox": "http://patches.dpdk.org/series/27622/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125792/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/125792/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F14C7428BC;\n\tTue, 4 Apr 2023 22:08:34 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 96C0A42D33;\n\tTue, 4 Apr 2023 22:07:39 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id C6B7441141\n for <dev@dpdk.org>; Tue, 4 Apr 2023 22:07:30 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 65456210DEAB; Tue, 4 Apr 2023 13:07:29 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 65456210DEAB", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1680638849;\n bh=8s73UQQAtEQ2WczFyopp6uPfPk17PNcxGsk9aCTBFsw=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=rXS/+v3TD1zBJWMwFO6Cr8+hpDFNaWLMaKSt1OlSAQf1LXrIWSlCtQdiqdi8JgXiN\n 8YL/F+wSXVtIQk19k+cbz2yBjhdTPwA+O0LXxHqijZJpfJFwEIpm0A0PHKDsBDTHTX\n kTsUq9wA6wZZv38vWgslDYq7pqcg5dHQrcDR+B8o=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, david.marchand@redhat.com,\n thomas@monjalon.net,\n mb@smartsharesystems.com, konstantin.ananyev@huawei.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v2 9/9] telemetry: avoid expanding versioned symbol macros on\n msvc", "Date": "Tue, 4 Apr 2023 13:07:27 -0700", "Message-Id": "<1680638847-26430-10-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1680638847-26430-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com>\n <1680638847-26430-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Windows does not support versioned symbols. Fortunately Windows also\ndoesn't have an exported stable ABI.\n\nExport rte_tel_data_add_array_int -> rte_tel_data_add_array_int_24\nand rte_tel_data_add_dict_int -> rte_tel_data_add_dict_int_v24\nfunctions.\n\nWindows does have a way to achieve similar versioning for symbols but it\nis not a simple #define so it will be done as a work package later.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/telemetry/telemetry_data.c | 16 ++++++++++++++++\n 1 file changed, 16 insertions(+)", "diff": "diff --git a/lib/telemetry/telemetry_data.c b/lib/telemetry/telemetry_data.c\nindex 2bac2de..284c16e 100644\n--- a/lib/telemetry/telemetry_data.c\n+++ b/lib/telemetry/telemetry_data.c\n@@ -82,8 +82,16 @@\n /* mark the v23 function as the older version, and v24 as the default version */\n VERSION_SYMBOL(rte_tel_data_add_array_int, _v23, 23);\n BIND_DEFAULT_SYMBOL(rte_tel_data_add_array_int, _v24, 24);\n+#ifndef RTE_TOOLCHAIN_MSVC\n MAP_STATIC_SYMBOL(int rte_tel_data_add_array_int(struct rte_tel_data *d,\n \t\tint64_t x), rte_tel_data_add_array_int_v24);\n+#else\n+int\n+rte_tel_data_add_array_int(struct rte_tel_data *d, int64_t x)\n+{\n+\treturn rte_tel_data_add_array_int_v24(d, x);\n+}\n+#endif\n \n int\n rte_tel_data_add_array_uint(struct rte_tel_data *d, uint64_t x)\n@@ -220,8 +228,16 @@\n /* mark the v23 function as the older version, and v24 as the default version */\n VERSION_SYMBOL(rte_tel_data_add_dict_int, _v23, 23);\n BIND_DEFAULT_SYMBOL(rte_tel_data_add_dict_int, _v24, 24);\n+#ifndef RTE_TOOLCHAIN_MSVC\n MAP_STATIC_SYMBOL(int rte_tel_data_add_dict_int(struct rte_tel_data *d,\n \t\tconst char *name, int64_t val), rte_tel_data_add_dict_int_v24);\n+#else\n+int\n+rte_tel_data_add_dict_int(struct rte_tel_data *d, const char *name, int64_t val)\n+{\n+\treturn rte_tel_data_add_dict_int_v24(d, name, val);\n+}\n+#endif\n \n int\n rte_tel_data_add_dict_uint(struct rte_tel_data *d,\n", "prefixes": [ "v2", "9/9" ] }