Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125788/?format=api
{ "id": 125788, "url": "http://patches.dpdk.org/api/patches/125788/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1680638847-26430-5-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1680638847-26430-5-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1680638847-26430-5-git-send-email-roretzla@linux.microsoft.com", "date": "2023-04-04T20:07:22", "name": "[v2,4/9] eal: typedef cpu flag enum as int for msvc", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4933d84dceb063af4dce5ff594d63f05137412c7", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1680638847-26430-5-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 27622, "url": "http://patches.dpdk.org/api/series/27622/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27622", "date": "2023-04-04T20:07:18", "name": "msvc integration changes", "version": 2, "mbox": "http://patches.dpdk.org/series/27622/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125788/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125788/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 72762428BC;\n\tTue, 4 Apr 2023 22:07:59 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 379E942C54;\n\tTue, 4 Apr 2023 22:07:35 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id F1FF541141\n for <dev@dpdk.org>; Tue, 4 Apr 2023 22:07:29 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 2679D210DEA4; Tue, 4 Apr 2023 13:07:29 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 2679D210DEA4", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1680638849;\n bh=suk611O6Ad/NaeKVpu2g21DUajOcYEmDmeCZxDkH9Fs=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=hzNHQRSujjZMK4B+0MPGqfsngqk2Cy3gtq4IJjRDZIE+MmHY5EQZj57C4bDhT/XPV\n prpe31Fpvv5JTPAS/t/aFlxtFQ1vYEaoMSc0n4rh0NLRfK13HyOIUA+jmo3N91sm/g\n 9md3zMfb4qvrqsNKXMjxip3ERXt0lh1sILn67WUo=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, david.marchand@redhat.com,\n thomas@monjalon.net,\n mb@smartsharesystems.com, konstantin.ananyev@huawei.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v2 4/9] eal: typedef cpu flag enum as int for msvc", "Date": "Tue, 4 Apr 2023 13:07:22 -0700", "Message-Id": "<1680638847-26430-5-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1680638847-26430-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com>\n <1680638847-26430-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Forward declaration of a typedef is a non-standard extension and is not\nsupported by msvc. Use an int instead.\n\nAbstract the use of the int/enum rte_cpu_flag_t in function parameter\nlists by re-typdefing the enum rte_cpu_flag_t to the rte_cpu_flag_t\nidentifier.\n\nRemove the use of __extension__ on function prototypes where\nrte_cpu_flag_t appeared in parameter lists, it is sufficient to have the\nconditionally compiled __extension__ at the non-standard forward\ndeclaration site.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/eal/include/generic/rte_cpuflags.h | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/eal/include/generic/rte_cpuflags.h b/lib/eal/include/generic/rte_cpuflags.h\nindex d35551e..87ab03c 100644\n--- a/lib/eal/include/generic/rte_cpuflags.h\n+++ b/lib/eal/include/generic/rte_cpuflags.h\n@@ -44,8 +44,12 @@ struct rte_cpu_intrinsics {\n /**\n * Enumeration of all CPU features supported\n */\n+#ifndef RTE_TOOLCHAIN_MSVC\n __extension__\n-enum rte_cpu_flag_t;\n+typedef enum rte_cpu_flag_t rte_cpu_flag_t;\n+#else\n+typedef int rte_cpu_flag_t;\n+#endif\n \n /**\n * Get name of CPU flag\n@@ -56,9 +60,8 @@ struct rte_cpu_intrinsics {\n * flag name\n * NULL if flag ID is invalid\n */\n-__extension__\n const char *\n-rte_cpu_get_flag_name(enum rte_cpu_flag_t feature);\n+rte_cpu_get_flag_name(rte_cpu_flag_t feature);\n \n /**\n * Function for checking a CPU flag availability\n@@ -70,9 +73,8 @@ struct rte_cpu_intrinsics {\n * 0 if flag is not available\n * -ENOENT if flag is invalid\n */\n-__extension__\n int\n-rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature);\n+rte_cpu_get_flag_enabled(rte_cpu_flag_t feature);\n \n /**\n * This function checks that the currently used CPU supports the CPU features\n", "prefixes": [ "v2", "4/9" ] }