Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125780/?format=api
{ "id": 125780, "url": "http://patches.dpdk.org/api/patches/125780/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230404141855.1025625-8-sedara@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230404141855.1025625-8-sedara@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230404141855.1025625-8-sedara@marvell.com", "date": "2023-04-04T14:18:52", "name": "[v1,7/9] net/octeon_ep: update queue size checks", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "77d8136f8034d803b06ad5de27338c32ab4e23b0", "submitter": { "id": 2729, "url": "http://patches.dpdk.org/api/people/2729/?format=api", "name": "Sathesh B Edara", "email": "sedara@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230404141855.1025625-8-sedara@marvell.com/mbox/", "series": [ { "id": 27620, "url": "http://patches.dpdk.org/api/series/27620/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27620", "date": "2023-04-04T14:18:45", "name": "extend octeon ep driver functionality", "version": 1, "mbox": "http://patches.dpdk.org/series/27620/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125780/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125780/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C3E9C428CE;\n\tTue, 4 Apr 2023 16:20:06 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EBB8042D40;\n\tTue, 4 Apr 2023 16:19:14 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 811D542D35\n for <dev@dpdk.org>; Tue, 4 Apr 2023 16:19:13 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 334ApmU6017569 for <dev@dpdk.org>; Tue, 4 Apr 2023 07:19:13 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3ppm4qw0wt-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Tue, 04 Apr 2023 07:19:12 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Tue, 4 Apr 2023 07:19:10 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Tue, 4 Apr 2023 07:19:10 -0700", "from localhost.marvell.com (unknown [10.106.27.249])\n by maili.marvell.com (Postfix) with ESMTP id EFA1B5B6930;\n Tue, 4 Apr 2023 07:19:09 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=PxEW4SEKHaMTnuHrueLKIucRIej85tUIjX/Vf68Wh7Y=;\n b=jbzkS7lFx7iz3bMTddodkOlR3GV2DBOyLBwwrtcpq0ug78q+h+VCBKLZrbynt9t0F6Sw\n qClzmoTh1hhpGV1I6tXG9uXZCXsBbBpFEk3g6CI0VL9Ua7ZAvgao+FEgrcTZpvRLBQir\n LmMyTbp4K9zeiw3K/0ZvTy1wa+UWnhReh3s4Eo5sPa7WhYZXP0DOz4vfGIcUrikj1Lrs\n zZ2y/wn/Y+KVCIJ1nTOcbQTQ2+GyQfEKTrfP0uFSVbxnyOJyYhb46JC2HVugsu5lT1R6\n NekQE6MJ8r8uqfgf4k/dGc8tQTUyycaluhZKEv/oNRHoEy9cFb/YQFekV2TYcOaultuB sQ==", "From": "Sathesh Edara <sedara@marvell.com>", "To": "<sburla@marvell.com>, <jerinj@marvell.com>, <sedara@marvell.com>, \"Radha\n Mohan Chintakuntla\" <radhac@marvell.com>, Veerasenareddy Burru\n <vburru@marvell.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH v1 7/9] net/octeon_ep: update queue size checks", "Date": "Tue, 4 Apr 2023 07:18:52 -0700", "Message-ID": "<20230404141855.1025625-8-sedara@marvell.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20230404141855.1025625-1-sedara@marvell.com>", "References": "<20230404141855.1025625-1-sedara@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "i1NM-tcfgEeEZOfif70GT5JbrHiCi72I", "X-Proofpoint-GUID": "i1NM-tcfgEeEZOfif70GT5JbrHiCi72I", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22\n definitions=2023-04-04_06,2023-04-04_04,2023-02-09_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch updates the output queue size checks\nto ensure that queue is larger than backpressure\nwatermark.Add setting of default queue sizes to\nthe minimum so that applications like testpmd\ncan be started without explicit queue size\narguments.\n\nSigned-off-by: Sathesh Edara <sedara@marvell.com>\n---\n drivers/net/octeon_ep/otx_ep_common.h | 9 +++++++--\n drivers/net/octeon_ep/otx_ep_ethdev.c | 12 ++++++++++--\n drivers/net/octeon_ep/otx_ep_rxtx.h | 4 ++--\n 3 files changed, 19 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/octeon_ep/otx_ep_common.h b/drivers/net/octeon_ep/otx_ep_common.h\nindex 1d9da5954e..3beec71968 100644\n--- a/drivers/net/octeon_ep/otx_ep_common.h\n+++ b/drivers/net/octeon_ep/otx_ep_common.h\n@@ -11,8 +11,13 @@\n #define OTX_EP_MAX_RINGS_PER_VF (8)\n #define OTX_EP_CFG_IO_QUEUES OTX_EP_MAX_RINGS_PER_VF\n #define OTX_EP_64BYTE_INSTR (64)\n-#define OTX_EP_MIN_IQ_DESCRIPTORS (128)\n-#define OTX_EP_MIN_OQ_DESCRIPTORS (128)\n+/*\n+ * Backpressure for SDP is configured on Octeon, and the minimum queue sizes\n+ * must be much larger than the backpressure watermark configured in the Octeon\n+ * SDP driver. IQ and OQ backpressure configurations are separate.\n+ */\n+#define OTX_EP_MIN_IQ_DESCRIPTORS (2048)\n+#define OTX_EP_MIN_OQ_DESCRIPTORS (2048)\n #define OTX_EP_MAX_IQ_DESCRIPTORS (8192)\n #define OTX_EP_MAX_OQ_DESCRIPTORS (8192)\n #define OTX_EP_OQ_BUF_SIZE (2048)\ndiff --git a/drivers/net/octeon_ep/otx_ep_ethdev.c b/drivers/net/octeon_ep/otx_ep_ethdev.c\nindex f1f2d2ba18..2cf82bd2e4 100644\n--- a/drivers/net/octeon_ep/otx_ep_ethdev.c\n+++ b/drivers/net/octeon_ep/otx_ep_ethdev.c\n@@ -47,6 +47,9 @@ otx_ep_dev_info_get(struct rte_eth_dev *eth_dev,\n \tdevinfo->rx_desc_lim = otx_ep_rx_desc_lim;\n \tdevinfo->tx_desc_lim = otx_ep_tx_desc_lim;\n \n+\tdevinfo->default_rxportconf.ring_size = OTX_EP_MIN_OQ_DESCRIPTORS;\n+\tdevinfo->default_txportconf.ring_size = OTX_EP_MIN_IQ_DESCRIPTORS;\n+\n \treturn 0;\n }\n \n@@ -273,8 +276,8 @@ otx_ep_rx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t q_no,\n \t\treturn -EINVAL;\n \t}\n \tif (num_rx_descs < (SDP_GBL_WMARK * 8)) {\n-\t\totx_ep_err(\"Invalid rx desc number should at least be greater than 8xwmark %u\\n\",\n-\t\t\t num_rx_descs);\n+\t\totx_ep_err(\"Invalid rx desc number(%u) should at least be greater than 8xwmark %u\\n\",\n+\t\t\t num_rx_descs, (SDP_GBL_WMARK * 8));\n \t\treturn -EINVAL;\n \t}\n \n@@ -356,6 +359,11 @@ otx_ep_tx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t q_no,\n \t\t\t num_tx_descs);\n \t\treturn -EINVAL;\n \t}\n+\tif (num_tx_descs < (SDP_GBL_WMARK * 8)) {\n+\t\totx_ep_err(\"Invalid tx desc number(%u) should at least be greater than 8*wmark(%u)\\n\",\n+\t\t\t num_tx_descs, (SDP_GBL_WMARK * 8));\n+\t\treturn -EINVAL;\n+\t}\n \n \tretval = otx_ep_setup_iqs(otx_epvf, q_no, num_tx_descs, socket_id);\n \ndiff --git a/drivers/net/octeon_ep/otx_ep_rxtx.h b/drivers/net/octeon_ep/otx_ep_rxtx.h\nindex 1527d350b5..7012888100 100644\n--- a/drivers/net/octeon_ep/otx_ep_rxtx.h\n+++ b/drivers/net/octeon_ep/otx_ep_rxtx.h\n@@ -7,8 +7,8 @@\n \n #include <rte_byteorder.h>\n \n-#define OTX_EP_RXD_ALIGN 1\n-#define OTX_EP_TXD_ALIGN 1\n+#define OTX_EP_RXD_ALIGN 2\n+#define OTX_EP_TXD_ALIGN 2\n \n #define OTX_EP_IQ_SEND_FAILED (-1)\n #define OTX_EP_IQ_SEND_SUCCESS (0)\n", "prefixes": [ "v1", "7/9" ] }