Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125771/?format=api
{ "id": 125771, "url": "http://patches.dpdk.org/api/patches/125771/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230404124112.71703-3-beilei.xing@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230404124112.71703-3-beilei.xing@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230404124112.71703-3-beilei.xing@intel.com", "date": "2023-04-04T12:41:12", "name": "[v3,2/2] common/idpf: refine capability get", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e4274de307bbe167e4b2be5b30fb67d4a015c1db", "submitter": { "id": 410, "url": "http://patches.dpdk.org/api/people/410/?format=api", "name": "Xing, Beilei", "email": "beilei.xing@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230404124112.71703-3-beilei.xing@intel.com/mbox/", "series": [ { "id": 27618, "url": "http://patches.dpdk.org/api/series/27618/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27618", "date": "2023-04-04T12:41:10", "name": "refine common module", "version": 3, "mbox": "http://patches.dpdk.org/series/27618/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125771/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125771/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 21E73428CD;\n\tTue, 4 Apr 2023 15:03:56 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3744042B7E;\n\tTue, 4 Apr 2023 15:03:48 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id 74B5242B7E\n for <dev@dpdk.org>; Tue, 4 Apr 2023 15:03:46 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 04 Apr 2023 06:03:46 -0700", "from dpdk-beileix-3.sh.intel.com ([10.67.110.253])\n by orsmga004.jf.intel.com with ESMTP; 04 Apr 2023 06:03:44 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1680613426; x=1712149426;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=OiZu0cmyThkxMRLb+mEuLb1IYL6w8qfcO8DINBq3IEw=;\n b=EY2rXu93r7M50ffLktRLGHQkWi4moln+/VdmdsuydszWEzhUeCwVLuZx\n hjLBW324f0KNeIXzcHx9p8brIEcWmGPrqUbyrbWFB7n7EuzAyAjdJ9qgA\n 0d+KCQp/dGJqbmgL981rJa2BNzlLVK1G5S8a2kvWy4Pb/ZFBLCkQVr6rb\n cfABGLnJDK2nZV58TWB3P51kL7kY/eXddGAy/Y8gNLspfZgWOmjogAsfI\n LIrMcq/foUParK0TkW32pgkQkDNFg4SoXkE6nfgyeugU7nfh3tA+pPf3e\n EKxOMWPN976Ev3ql20f08F5q8SAmF/YF4c2ZQGJ+Q+NqkUSDV9OrxeIpv g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10670\"; a=\"344739418\"", "E=Sophos;i=\"5.98,317,1673942400\"; d=\"scan'208\";a=\"344739418\"", "E=McAfee;i=\"6600,9927,10670\"; a=\"810229634\"", "E=Sophos;i=\"5.98,317,1673942400\"; d=\"scan'208\";a=\"810229634\"" ], "X-ExtLoop1": "1", "From": "beilei.xing@intel.com", "To": "jingjing.wu@intel.com", "Cc": "dev@dpdk.org,\n\tBeilei Xing <beilei.xing@intel.com>", "Subject": "[PATCH v3 2/2] common/idpf: refine capability get", "Date": "Tue, 4 Apr 2023 12:41:12 +0000", "Message-Id": "<20230404124112.71703-3-beilei.xing@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20230404124112.71703-1-beilei.xing@intel.com>", "References": "<20230321070703.80689-1-beilei.xing@intel.com>\n <20230404124112.71703-1-beilei.xing@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Beilei Xing <beilei.xing@intel.com>\n\nInitialize required capability in PMD, and refine\nidpf_vc_caps_get function. Then different PMDs can\nrequire different capability.\n\nSigned-off-by: Beilei Xing <beilei.xing@intel.com>\n---\n drivers/common/idpf/idpf_common_virtchnl.c | 45 ++--------------------\n drivers/net/cpfl/cpfl_ethdev.c | 41 ++++++++++++++++++++\n drivers/net/idpf/idpf_ethdev.c | 40 +++++++++++++++++++\n 3 files changed, 84 insertions(+), 42 deletions(-)", "diff": "diff --git a/drivers/common/idpf/idpf_common_virtchnl.c b/drivers/common/idpf/idpf_common_virtchnl.c\nindex 9ee7259539..a4e129062e 100644\n--- a/drivers/common/idpf/idpf_common_virtchnl.c\n+++ b/drivers/common/idpf/idpf_common_virtchnl.c\n@@ -278,51 +278,12 @@ idpf_vc_api_version_check(struct idpf_adapter *adapter)\n int\n idpf_vc_caps_get(struct idpf_adapter *adapter)\n {\n-\tstruct virtchnl2_get_capabilities caps_msg;\n \tstruct idpf_cmd_info args;\n \tint err;\n \n-\tmemset(&caps_msg, 0, sizeof(struct virtchnl2_get_capabilities));\n-\n-\tcaps_msg.csum_caps =\n-\t\tVIRTCHNL2_CAP_TX_CSUM_L3_IPV4 |\n-\t\tVIRTCHNL2_CAP_TX_CSUM_L4_IPV4_TCP |\n-\t\tVIRTCHNL2_CAP_TX_CSUM_L4_IPV4_UDP |\n-\t\tVIRTCHNL2_CAP_TX_CSUM_L4_IPV4_SCTP |\n-\t\tVIRTCHNL2_CAP_TX_CSUM_L4_IPV6_TCP |\n-\t\tVIRTCHNL2_CAP_TX_CSUM_L4_IPV6_UDP |\n-\t\tVIRTCHNL2_CAP_TX_CSUM_L4_IPV6_SCTP |\n-\t\tVIRTCHNL2_CAP_TX_CSUM_GENERIC |\n-\t\tVIRTCHNL2_CAP_RX_CSUM_L3_IPV4 |\n-\t\tVIRTCHNL2_CAP_RX_CSUM_L4_IPV4_TCP |\n-\t\tVIRTCHNL2_CAP_RX_CSUM_L4_IPV4_UDP |\n-\t\tVIRTCHNL2_CAP_RX_CSUM_L4_IPV4_SCTP |\n-\t\tVIRTCHNL2_CAP_RX_CSUM_L4_IPV6_TCP |\n-\t\tVIRTCHNL2_CAP_RX_CSUM_L4_IPV6_UDP |\n-\t\tVIRTCHNL2_CAP_RX_CSUM_L4_IPV6_SCTP |\n-\t\tVIRTCHNL2_CAP_RX_CSUM_GENERIC;\n-\n-\tcaps_msg.rss_caps =\n-\t\tVIRTCHNL2_CAP_RSS_IPV4_TCP |\n-\t\tVIRTCHNL2_CAP_RSS_IPV4_UDP |\n-\t\tVIRTCHNL2_CAP_RSS_IPV4_SCTP |\n-\t\tVIRTCHNL2_CAP_RSS_IPV4_OTHER |\n-\t\tVIRTCHNL2_CAP_RSS_IPV6_TCP |\n-\t\tVIRTCHNL2_CAP_RSS_IPV6_UDP |\n-\t\tVIRTCHNL2_CAP_RSS_IPV6_SCTP |\n-\t\tVIRTCHNL2_CAP_RSS_IPV6_OTHER |\n-\t\tVIRTCHNL2_CAP_RSS_IPV4_AH |\n-\t\tVIRTCHNL2_CAP_RSS_IPV4_ESP |\n-\t\tVIRTCHNL2_CAP_RSS_IPV4_AH_ESP |\n-\t\tVIRTCHNL2_CAP_RSS_IPV6_AH |\n-\t\tVIRTCHNL2_CAP_RSS_IPV6_ESP |\n-\t\tVIRTCHNL2_CAP_RSS_IPV6_AH_ESP;\n-\n-\tcaps_msg.other_caps = VIRTCHNL2_CAP_WB_ON_ITR;\n-\n \targs.ops = VIRTCHNL2_OP_GET_CAPS;\n-\targs.in_args = (uint8_t *)&caps_msg;\n-\targs.in_args_size = sizeof(caps_msg);\n+\targs.in_args = (uint8_t *)&adapter->caps;\n+\targs.in_args_size = sizeof(struct virtchnl2_get_capabilities);\n \targs.out_buffer = adapter->mbx_resp;\n \targs.out_size = IDPF_DFLT_MBX_BUF_SIZE;\n \n@@ -333,7 +294,7 @@ idpf_vc_caps_get(struct idpf_adapter *adapter)\n \t\treturn err;\n \t}\n \n-\trte_memcpy(&adapter->caps, args.out_buffer, sizeof(caps_msg));\n+\trte_memcpy(&adapter->caps, args.out_buffer, sizeof(struct virtchnl2_get_capabilities));\n \n \treturn 0;\n }\ndiff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c\nindex d3c50619ea..186ccb3095 100644\n--- a/drivers/net/cpfl/cpfl_ethdev.c\n+++ b/drivers/net/cpfl/cpfl_ethdev.c\n@@ -1200,6 +1200,45 @@ static struct idpf_ctlq_create_info ctlq_info[IDPF_CTLQ_NUM] = {\n \t}\n };\n \n+static struct virtchnl2_get_capabilities req_caps = {\n+\t.csum_caps =\n+\tVIRTCHNL2_CAP_TX_CSUM_L3_IPV4 |\n+\tVIRTCHNL2_CAP_TX_CSUM_L4_IPV4_TCP |\n+\tVIRTCHNL2_CAP_TX_CSUM_L4_IPV4_UDP |\n+\tVIRTCHNL2_CAP_TX_CSUM_L4_IPV4_SCTP |\n+\tVIRTCHNL2_CAP_TX_CSUM_L4_IPV6_TCP |\n+\tVIRTCHNL2_CAP_TX_CSUM_L4_IPV6_UDP |\n+\tVIRTCHNL2_CAP_TX_CSUM_L4_IPV6_SCTP |\n+\tVIRTCHNL2_CAP_TX_CSUM_GENERIC |\n+\tVIRTCHNL2_CAP_RX_CSUM_L3_IPV4 |\n+\tVIRTCHNL2_CAP_RX_CSUM_L4_IPV4_TCP |\n+\tVIRTCHNL2_CAP_RX_CSUM_L4_IPV4_UDP |\n+\tVIRTCHNL2_CAP_RX_CSUM_L4_IPV4_SCTP |\n+\tVIRTCHNL2_CAP_RX_CSUM_L4_IPV6_TCP |\n+\tVIRTCHNL2_CAP_RX_CSUM_L4_IPV6_UDP |\n+\tVIRTCHNL2_CAP_RX_CSUM_L4_IPV6_SCTP |\n+\tVIRTCHNL2_CAP_RX_CSUM_GENERIC,\n+\n+\t.rss_caps =\n+\tVIRTCHNL2_CAP_RSS_IPV4_TCP |\n+\tVIRTCHNL2_CAP_RSS_IPV4_UDP |\n+\tVIRTCHNL2_CAP_RSS_IPV4_SCTP |\n+\tVIRTCHNL2_CAP_RSS_IPV4_OTHER |\n+\tVIRTCHNL2_CAP_RSS_IPV6_TCP |\n+\tVIRTCHNL2_CAP_RSS_IPV6_UDP |\n+\tVIRTCHNL2_CAP_RSS_IPV6_SCTP |\n+\tVIRTCHNL2_CAP_RSS_IPV6_OTHER |\n+\tVIRTCHNL2_CAP_RSS_IPV4_AH |\n+\tVIRTCHNL2_CAP_RSS_IPV4_ESP |\n+\tVIRTCHNL2_CAP_RSS_IPV4_AH_ESP |\n+\tVIRTCHNL2_CAP_RSS_IPV6_AH |\n+\tVIRTCHNL2_CAP_RSS_IPV6_ESP |\n+\tVIRTCHNL2_CAP_RSS_IPV6_AH_ESP,\n+\n+\t.other_caps = VIRTCHNL2_CAP_WB_ON_ITR |\n+\tVIRTCHNL2_CAP_PTP\n+};\n+\n static int\n cpfl_adapter_ext_init(struct rte_pci_device *pci_dev, struct cpfl_adapter_ext *adapter)\n {\n@@ -1229,6 +1268,8 @@ cpfl_adapter_ext_init(struct rte_pci_device *pci_dev, struct cpfl_adapter_ext *a\n \t\tgoto err_reset_check;\n \t}\n \n+\trte_memcpy(&base->caps, &req_caps, sizeof(struct virtchnl2_get_capabilities));\n+\n \tret = idpf_adapter_init(base);\n \tif (ret != 0) {\n \t\tPMD_INIT_LOG(ERR, \"Failed to init adapter\");\ndiff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c\nindex 662a8a806a..18c152b598 100644\n--- a/drivers/net/idpf/idpf_ethdev.c\n+++ b/drivers/net/idpf/idpf_ethdev.c\n@@ -1163,6 +1163,44 @@ static struct idpf_ctlq_create_info idpf_ctlq_info[IDPF_CTLQ_NUM] = {\n \t}\n };\n \n+static struct virtchnl2_get_capabilities req_caps = {\n+\t.csum_caps =\n+\tVIRTCHNL2_CAP_TX_CSUM_L3_IPV4 |\n+\tVIRTCHNL2_CAP_TX_CSUM_L4_IPV4_TCP |\n+\tVIRTCHNL2_CAP_TX_CSUM_L4_IPV4_UDP |\n+\tVIRTCHNL2_CAP_TX_CSUM_L4_IPV4_SCTP |\n+\tVIRTCHNL2_CAP_TX_CSUM_L4_IPV6_TCP |\n+\tVIRTCHNL2_CAP_TX_CSUM_L4_IPV6_UDP |\n+\tVIRTCHNL2_CAP_TX_CSUM_L4_IPV6_SCTP |\n+\tVIRTCHNL2_CAP_TX_CSUM_GENERIC |\n+\tVIRTCHNL2_CAP_RX_CSUM_L3_IPV4 |\n+\tVIRTCHNL2_CAP_RX_CSUM_L4_IPV4_TCP |\n+\tVIRTCHNL2_CAP_RX_CSUM_L4_IPV4_UDP |\n+\tVIRTCHNL2_CAP_RX_CSUM_L4_IPV4_SCTP |\n+\tVIRTCHNL2_CAP_RX_CSUM_L4_IPV6_TCP |\n+\tVIRTCHNL2_CAP_RX_CSUM_L4_IPV6_UDP |\n+\tVIRTCHNL2_CAP_RX_CSUM_L4_IPV6_SCTP |\n+\tVIRTCHNL2_CAP_RX_CSUM_GENERIC,\n+\n+\t.rss_caps =\n+\tVIRTCHNL2_CAP_RSS_IPV4_TCP |\n+\tVIRTCHNL2_CAP_RSS_IPV4_UDP |\n+\tVIRTCHNL2_CAP_RSS_IPV4_SCTP |\n+\tVIRTCHNL2_CAP_RSS_IPV4_OTHER |\n+\tVIRTCHNL2_CAP_RSS_IPV6_TCP |\n+\tVIRTCHNL2_CAP_RSS_IPV6_UDP |\n+\tVIRTCHNL2_CAP_RSS_IPV6_SCTP |\n+\tVIRTCHNL2_CAP_RSS_IPV6_OTHER |\n+\tVIRTCHNL2_CAP_RSS_IPV4_AH |\n+\tVIRTCHNL2_CAP_RSS_IPV4_ESP |\n+\tVIRTCHNL2_CAP_RSS_IPV4_AH_ESP |\n+\tVIRTCHNL2_CAP_RSS_IPV6_AH |\n+\tVIRTCHNL2_CAP_RSS_IPV6_ESP |\n+\tVIRTCHNL2_CAP_RSS_IPV6_AH_ESP,\n+\n+\t.other_caps = VIRTCHNL2_CAP_WB_ON_ITR\n+};\n+\n static int\n idpf_adapter_ext_init(struct rte_pci_device *pci_dev, struct idpf_adapter_ext *adapter)\n {\n@@ -1192,6 +1230,8 @@ idpf_adapter_ext_init(struct rte_pci_device *pci_dev, struct idpf_adapter_ext *a\n \t\tgoto err_reset_check;\n \t}\n \n+\trte_memcpy(&base->caps, &req_caps, sizeof(struct virtchnl2_get_capabilities));\n+\n \tret = idpf_adapter_init(base);\n \tif (ret != 0) {\n \t\tPMD_INIT_LOG(ERR, \"Failed to init adapter\");\n", "prefixes": [ "v3", "2/2" ] }