Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125756/?format=api
{ "id": 125756, "url": "http://patches.dpdk.org/api/patches/125756/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230404124840.1898-5-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230404124840.1898-5-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230404124840.1898-5-david.marchand@redhat.com", "date": "2023-04-04T12:48:28", "name": "[v3,04/16] hash: annotate cuckoo hash lock", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "494b369701c9c23214f33e83bb6820e78ac066d8", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230404124840.1898-5-david.marchand@redhat.com/mbox/", "series": [ { "id": 27617, "url": "http://patches.dpdk.org/api/series/27617/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27617", "date": "2023-04-04T12:48:24", "name": "Enable lock annotations on most libraries and drivers", "version": 3, "mbox": "http://patches.dpdk.org/series/27617/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125756/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125756/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BFB94428CD;\n\tTue, 4 Apr 2023 14:49:21 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 283E742D1D;\n\tTue, 4 Apr 2023 14:49:10 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 6074942B7E\n for <dev@dpdk.org>; Tue, 4 Apr 2023 14:49:07 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-553-cPp5EjsJOLKNMZGZMW_BeA-1; Tue, 04 Apr 2023 08:49:05 -0400", "from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com\n [10.11.54.4])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5756F2807D63;\n Tue, 4 Apr 2023 12:49:05 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.225.38])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 27BC9202701F;\n Tue, 4 Apr 2023 12:49:04 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1680612546;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=5IXdKEIbzNEn/czHJyiyto+op04BlCukyTQehteBcjw=;\n b=RauylB2zlqUaNousxvfFE36I4pghJqp/JNE9wSZIvCKnlIjsRUigi0QAaWd7L4s3kvBQmo\n GGtYd0lUcN1aXwPJ9x5yqbnT7HRnlvYQu7AZTJWxpqq8qu/A8qOqY0HS6L5JhI2t5Tpbkv\n 0dNQVKQg+XIoAg3YYIgMbiLY9ZPLfCM=", "X-MC-Unique": "cPp5EjsJOLKNMZGZMW_BeA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, Yipeng Wang <yipeng1.wang@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>", "Subject": "[PATCH v3 04/16] hash: annotate cuckoo hash lock", "Date": "Tue, 4 Apr 2023 14:48:28 +0200", "Message-Id": "<20230404124840.1898-5-david.marchand@redhat.com>", "In-Reply-To": "<20230404124840.1898-1-david.marchand@redhat.com>", "References": "<20230224081642.2566619-1-david.marchand@redhat.com>\n <20230404124840.1898-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "__hash_rw_(reader|writer)_(|un)lock helpers take locks depending on\nconditions that are fixed at the rte_hash object initialisation.\nSo we can tell clang that those helpers unconditionally take/release\nthose locks (and waive the lock check on their implementation).\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n lib/hash/rte_cuckoo_hash.c | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c\nindex 829b79c89a..d92a903bb3 100644\n--- a/lib/hash/rte_cuckoo_hash.c\n+++ b/lib/hash/rte_cuckoo_hash.c\n@@ -575,6 +575,8 @@ rte_hash_count(const struct rte_hash *h)\n /* Read write locks implemented using rte_rwlock */\n static inline void\n __hash_rw_writer_lock(const struct rte_hash *h)\n+\t__rte_exclusive_lock_function(&h->readwrite_lock)\n+\t__rte_no_thread_safety_analysis\n {\n \tif (h->writer_takes_lock && h->hw_trans_mem_support)\n \t\trte_rwlock_write_lock_tm(h->readwrite_lock);\n@@ -584,6 +586,8 @@ __hash_rw_writer_lock(const struct rte_hash *h)\n \n static inline void\n __hash_rw_reader_lock(const struct rte_hash *h)\n+\t__rte_shared_lock_function(&h->readwrite_lock)\n+\t__rte_no_thread_safety_analysis\n {\n \tif (h->readwrite_concur_support && h->hw_trans_mem_support)\n \t\trte_rwlock_read_lock_tm(h->readwrite_lock);\n@@ -593,6 +597,8 @@ __hash_rw_reader_lock(const struct rte_hash *h)\n \n static inline void\n __hash_rw_writer_unlock(const struct rte_hash *h)\n+\t__rte_unlock_function(&h->readwrite_lock)\n+\t__rte_no_thread_safety_analysis\n {\n \tif (h->writer_takes_lock && h->hw_trans_mem_support)\n \t\trte_rwlock_write_unlock_tm(h->readwrite_lock);\n@@ -602,6 +608,8 @@ __hash_rw_writer_unlock(const struct rte_hash *h)\n \n static inline void\n __hash_rw_reader_unlock(const struct rte_hash *h)\n+\t__rte_unlock_function(&h->readwrite_lock)\n+\t__rte_no_thread_safety_analysis\n {\n \tif (h->readwrite_concur_support && h->hw_trans_mem_support)\n \t\trte_rwlock_read_unlock_tm(h->readwrite_lock);\n", "prefixes": [ "v3", "04/16" ] }