Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125736/?format=api
{ "id": 125736, "url": "http://patches.dpdk.org/api/patches/125736/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1680558751-17931-8-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1680558751-17931-8-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1680558751-17931-8-git-send-email-roretzla@linux.microsoft.com", "date": "2023-04-03T21:52:29", "name": "[7/9] eal: exclude exposure of rte atomic APIs for MSVC builds", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "63bf45520498ed578e6261402803a0d4bd0639ea", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1680558751-17931-8-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 27611, "url": "http://patches.dpdk.org/api/series/27611/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27611", "date": "2023-04-03T21:52:22", "name": "msvc integration changes", "version": 1, "mbox": "http://patches.dpdk.org/series/27611/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125736/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125736/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 915C0428C3;\n\tMon, 3 Apr 2023 23:53:09 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id ED2B842C54;\n\tMon, 3 Apr 2023 23:52:44 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id D7ABB40156\n for <dev@dpdk.org>; Mon, 3 Apr 2023 23:52:37 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id A8865210DC76; Mon, 3 Apr 2023 14:52:36 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com A8865210DC76", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1680558756;\n bh=uH50+MFvPHR3vD/Mq60lPgkZKJADsnrYD4/ri9Wn6kk=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=Z4zHOu1cD+N0QzoCv/edQI/zaZCvx1ElIqyxT4ONELGWK76xmR+PZBX+xRiBCEmF3\n a5XlrFodF2nBVqE1955XtmSJSoBITcLVV977g5zt94/Y0TR4iWy+uDD4ImkvpdoZoZ\n qSRPQW4M9BE79CAlKfwgzn0IiM5IZtw+69NOsezI=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, david.marchand@redhat.com,\n thomas@monjalon.net,\n mb@smartsharesystems.com, Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH 7/9] eal: exclude exposure of rte atomic APIs for MSVC builds", "Date": "Mon, 3 Apr 2023 14:52:29 -0700", "Message-Id": "<1680558751-17931-8-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "It's discouraged to use rte_atomics APIs instead standard APIs should be\nused from C11. Since MSVC is a new toolchain/platform combination block\nvisibility of the rte_atomic APIs from day 1.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/eal/include/generic/rte_atomic.h | 7 +++++++\n lib/eal/x86/include/rte_atomic.h | 4 ++++\n 2 files changed, 11 insertions(+)", "diff": "diff --git a/lib/eal/include/generic/rte_atomic.h b/lib/eal/include/generic/rte_atomic.h\nindex e973184..1964697 100644\n--- a/lib/eal/include/generic/rte_atomic.h\n+++ b/lib/eal/include/generic/rte_atomic.h\n@@ -131,6 +131,8 @@\n \n /*------------------------- 16 bit atomic operations -------------------------*/\n \n+#ifndef RTE_TOOLCHAIN_MSVC\n+\n /**\n * Atomic compare and set.\n *\n@@ -1038,8 +1040,11 @@ static inline void rte_atomic64_clear(rte_atomic64_t *v)\n }\n #endif\n \n+#endif\n+\n /*------------------------ 128 bit atomic operations -------------------------*/\n \n+\n /**\n * 128-bit integer structure.\n */\n@@ -1049,8 +1054,10 @@ static inline void rte_atomic64_clear(rte_atomic64_t *v)\n \tunion {\n \t\tuint64_t val[2];\n #ifdef RTE_ARCH_64\n+#ifndef RTE_TOOLCHAIN_MSVC\n \t\t__extension__ __int128 int128;\n #endif\n+#endif\n \t};\n } __rte_aligned(16) rte_int128_t;\n \ndiff --git a/lib/eal/x86/include/rte_atomic.h b/lib/eal/x86/include/rte_atomic.h\nindex 5cce9ba..20f3380 100644\n--- a/lib/eal/x86/include/rte_atomic.h\n+++ b/lib/eal/x86/include/rte_atomic.h\n@@ -87,6 +87,8 @@\n \n #define rte_io_rmb() rte_compiler_barrier()\n \n+#ifndef RTE_TOOLCHAIN_MSVC\n+\n /**\n * Synchronization fence between threads based on the specified memory order.\n *\n@@ -283,6 +285,8 @@ static inline int rte_atomic32_dec_and_test(rte_atomic32_t *v)\n #include \"rte_atomic_64.h\"\n #endif\n \n+#endif\n+\n #ifdef __cplusplus\n }\n #endif\n", "prefixes": [ "7/9" ] }