Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125691/?format=api
{ "id": 125691, "url": "http://patches.dpdk.org/api/patches/125691/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230331154259.1447831-14-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230331154259.1447831-14-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230331154259.1447831-14-maxime.coquelin@redhat.com", "date": "2023-03-31T15:42:45", "name": "[RFC,13/27] vhost: add helper for IOTLB misses", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ad77f0a34b7efbf1e212c3db5d3402d1d1c813a0", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230331154259.1447831-14-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 27594, "url": "http://patches.dpdk.org/api/series/27594/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27594", "date": "2023-03-31T15:42:32", "name": "Add VDUSE support to Vhost library", "version": 1, "mbox": "http://patches.dpdk.org/series/27594/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125691/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/125691/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5EF8B42887;\n\tFri, 31 Mar 2023 17:45:03 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 02F7242DCC;\n\tFri, 31 Mar 2023 17:43:53 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id E85F942D3D\n for <dev@dpdk.org>; Fri, 31 Mar 2023 17:43:51 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-33-VrDlnqSDNBWINpij9ku6IA-1; Fri, 31 Mar 2023 11:43:40 -0400", "from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com\n [10.11.54.4])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2888A85A5A3;\n Fri, 31 Mar 2023 15:43:40 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.6])\n by smtp.corp.redhat.com (Postfix) with ESMTP id CE047202701E;\n Fri, 31 Mar 2023 15:43:37 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1680277431;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=EnzJ2XPQzBwT4KAwoRaboJ+9eIYObJCLw4vEDG1mLb0=;\n b=J9XECcKRL6Vtf3IiscNEz9KCYVw9oNWy9RhusS+XjQKdWfRoNtMBlZfOTBlxXwsyX7yGuG\n o64ySSPuvoDtoB/F363PhI09u+PZrQte2Tx+JuRKj3hUmvOr6VbbKSxm5jOoxlMc97LkGz\n iySssOzIG6Awj7Rj2dBWyxRMgpqfDao=", "X-MC-Unique": "VrDlnqSDNBWINpij9ku6IA-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, david.marchand@redhat.com, chenbo.xia@intel.com,\n mkp@redhat.com, fbl@redhat.com, jasowang@redhat.com,\n cunming.liang@intel.com, xieyongji@bytedance.com, echaudro@redhat.com,\n eperezma@redhat.com, amorenoz@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[RFC 13/27] vhost: add helper for IOTLB misses", "Date": "Fri, 31 Mar 2023 17:42:45 +0200", "Message-Id": "<20230331154259.1447831-14-maxime.coquelin@redhat.com>", "In-Reply-To": "<20230331154259.1447831-1-maxime.coquelin@redhat.com>", "References": "<20230331154259.1447831-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch adds a helper for sending IOTLB misses as VDUSE\nwill use an ioctl while Vhost-user use a dedicated\nVhost-user backend request.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/vhost.c | 13 ++++++++++++-\n lib/vhost/vhost.h | 3 +++\n lib/vhost/vhost_user.c | 6 ++++--\n lib/vhost/vhost_user.h | 1 -\n 4 files changed, 19 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c\nindex 41f212315e..790eb06b28 100644\n--- a/lib/vhost/vhost.c\n+++ b/lib/vhost/vhost.c\n@@ -52,6 +52,12 @@ static const struct vhost_vq_stats_name_off vhost_vq_stat_strings[] = {\n \n #define VHOST_NB_VQ_STATS RTE_DIM(vhost_vq_stat_strings)\n \n+static int\n+vhost_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm)\n+{\n+\treturn dev->backend_ops->iotlb_miss(dev, iova, perm);\n+}\n+\n uint64_t\n __vhost_iova_to_vva(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\t uint64_t iova, uint64_t *size, uint8_t perm)\n@@ -86,7 +92,7 @@ __vhost_iova_to_vva(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\tvhost_user_iotlb_rd_unlock(vq);\n \n \t\tvhost_user_iotlb_pending_insert(dev, iova, perm);\n-\t\tif (vhost_user_iotlb_miss(dev, iova, perm)) {\n+\t\tif (vhost_iotlb_miss(dev, iova, perm)) {\n \t\t\tVHOST_LOG_DATA(dev->ifname, ERR,\n \t\t\t\t\"IOTLB miss req failed for IOVA 0x%\" PRIx64 \"\\n\",\n \t\t\t\tiova);\n@@ -686,6 +692,11 @@ vhost_new_device(struct vhost_backend_ops *ops)\n \t\treturn -1;\n \t}\n \n+\tif (ops->iotlb_miss == NULL) {\n+\t\tVHOST_LOG_CONFIG(\"device\", ERR, \"missing IOTLB miss backend op.\\n\");\n+\t\treturn -1;\n+\t}\n+\n \tpthread_mutex_lock(&vhost_dev_lock);\n \tfor (i = 0; i < RTE_MAX_VHOST_DEVICE; i++) {\n \t\tif (vhost_devices[i] == NULL)\ndiff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h\nindex 2ad26f6951..ee7640e901 100644\n--- a/lib/vhost/vhost.h\n+++ b/lib/vhost/vhost.h\n@@ -92,11 +92,14 @@\n struct virtio_net;\n typedef void (*vhost_iotlb_remove_notify)(uint64_t addr, uint64_t off, uint64_t size);\n \n+typedef int (*vhost_iotlb_miss_cb)(struct virtio_net *dev, uint64_t iova, uint8_t perm);\n+\n /**\n * Structure that contains backend-specific ops.\n */\n struct vhost_backend_ops {\n \tvhost_iotlb_remove_notify iotlb_remove_notify;\n+\tvhost_iotlb_miss_cb iotlb_miss;\n };\n \n /**\ndiff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c\nindex 2d5dec5bc1..6a9f32972a 100644\n--- a/lib/vhost/vhost_user.c\n+++ b/lib/vhost/vhost_user.c\n@@ -3305,7 +3305,7 @@ vhost_user_msg_handler(int vid, int fd)\n \treturn ret;\n }\n \n-int\n+static int\n vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm)\n {\n \tint ret;\n@@ -3465,7 +3465,9 @@ int rte_vhost_host_notifier_ctrl(int vid, uint16_t qid, bool enable)\n \treturn ret;\n }\n \n-static struct vhost_backend_ops vhost_user_backend_ops;\n+static struct vhost_backend_ops vhost_user_backend_ops = {\n+\t.iotlb_miss = vhost_user_iotlb_miss,\n+};\n \n int\n vhost_user_new_device(void)\ndiff --git a/lib/vhost/vhost_user.h b/lib/vhost/vhost_user.h\nindex 61456049c8..1ffeca92f3 100644\n--- a/lib/vhost/vhost_user.h\n+++ b/lib/vhost/vhost_user.h\n@@ -179,7 +179,6 @@ struct __rte_packed vhu_msg_context {\n \n /* vhost_user.c */\n int vhost_user_msg_handler(int vid, int fd);\n-int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm);\n \n /* socket.c */\n int read_fd_message(char *ifname, int sockfd, char *buf, int buflen, int *fds, int max_fds,\n", "prefixes": [ "RFC", "13/27" ] }