Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125688/?format=api
{ "id": 125688, "url": "http://patches.dpdk.org/api/patches/125688/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230331154259.1447831-13-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230331154259.1447831-13-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230331154259.1447831-13-maxime.coquelin@redhat.com", "date": "2023-03-31T15:42:44", "name": "[RFC,12/27] vhost: add IOTLB cache entry removal callback", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1f26b8c45bddceaf709adec774f2ad7c342d6128", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230331154259.1447831-13-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 27594, "url": "http://patches.dpdk.org/api/series/27594/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27594", "date": "2023-03-31T15:42:32", "name": "Add VDUSE support to Vhost library", "version": 1, "mbox": "http://patches.dpdk.org/series/27594/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125688/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/125688/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3600B42887;\n\tFri, 31 Mar 2023 17:44:44 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F258142DB9;\n\tFri, 31 Mar 2023 17:43:42 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id A55F042DA2\n for <dev@dpdk.org>; Fri, 31 Mar 2023 17:43:41 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-346-q0OAGq2-OQaMH9ykGE2Mgw-1; Fri, 31 Mar 2023 11:43:37 -0400", "from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com\n [10.11.54.4])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7A922185A7A2;\n Fri, 31 Mar 2023 15:43:37 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.6])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 3935A20290A5;\n Fri, 31 Mar 2023 15:43:35 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1680277421;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=LAPRlCaLVxKzzAIdEEBfv34fCej9/BW0KuBIVnmwQaQ=;\n b=GLYUd0kjDD0i17CkujPpVpqTUrkYOpKC87udUpocbScSFE5d1xtw219wUDcijAwMONoaiT\n no85BwOi9uAT4ESngGBw/tCf8lWckPizf8CBTdyweI8cnd/k4Snq5Fx7R1byDw1X2spXJD\n 3AsL5rBqfzP+Rup6paxwxk2dS1CR+p4=", "X-MC-Unique": "q0OAGq2-OQaMH9ykGE2Mgw-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, david.marchand@redhat.com, chenbo.xia@intel.com,\n mkp@redhat.com, fbl@redhat.com, jasowang@redhat.com,\n cunming.liang@intel.com, xieyongji@bytedance.com, echaudro@redhat.com,\n eperezma@redhat.com, amorenoz@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[RFC 12/27] vhost: add IOTLB cache entry removal callback", "Date": "Fri, 31 Mar 2023 17:42:44 +0200", "Message-Id": "<20230331154259.1447831-13-maxime.coquelin@redhat.com>", "In-Reply-To": "<20230331154259.1447831-1-maxime.coquelin@redhat.com>", "References": "<20230331154259.1447831-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "VDUSE will need to munmap() the IOTLB entry on removal\nfrom the cache, as it performs mmap() before insertion.\n\nThis patch introduces a callback that VDUSE layer will\nimplement to achieve this.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/iotlb.c | 12 ++++++++++++\n lib/vhost/vhost.h | 4 ++++\n 2 files changed, 16 insertions(+)", "diff": "diff --git a/lib/vhost/iotlb.c b/lib/vhost/iotlb.c\nindex 188dfb8e38..86b0be62b4 100644\n--- a/lib/vhost/iotlb.c\n+++ b/lib/vhost/iotlb.c\n@@ -25,6 +25,15 @@ struct vhost_iotlb_entry {\n \n #define IOTLB_CACHE_SIZE 2048\n \n+static void\n+vhost_user_iotlb_remove_notify(struct virtio_net *dev, struct vhost_iotlb_entry *entry)\n+{\n+\tif (dev->backend_ops->iotlb_remove_notify == NULL)\n+\t\treturn;\n+\n+\tdev->backend_ops->iotlb_remove_notify(entry->uaddr, entry->uoffset, entry->size);\n+}\n+\n static bool\n vhost_user_iotlb_share_page(struct vhost_iotlb_entry *a, struct vhost_iotlb_entry *b)\n {\n@@ -198,6 +207,7 @@ vhost_user_iotlb_cache_remove_all(struct virtio_net *dev)\n \t\tvhost_user_iotlb_set_dump(node);\n \n \t\tTAILQ_REMOVE(&dev->iotlb_list, node, next);\n+\t\tvhost_user_iotlb_remove_notify(dev, node);\n \t\tvhost_user_iotlb_pool_put(dev, node);\n \t}\n \n@@ -223,6 +233,7 @@ vhost_user_iotlb_cache_random_evict(struct virtio_net *dev)\n \t\t\tvhost_user_iotlb_clear_dump(node, prev_node, next_node);\n \n \t\t\tTAILQ_REMOVE(&dev->iotlb_list, node, next);\n+\t\t\tvhost_user_iotlb_remove_notify(dev, node);\n \t\t\tvhost_user_iotlb_pool_put(dev, node);\n \t\t\tdev->iotlb_cache_nr--;\n \t\t\tbreak;\n@@ -314,6 +325,7 @@ vhost_user_iotlb_cache_remove(struct virtio_net *dev, uint64_t iova, uint64_t si\n \t\t\tvhost_user_iotlb_clear_dump(node, prev_node, next_node);\n \n \t\t\tTAILQ_REMOVE(&dev->iotlb_list, node, next);\n+\t\t\tvhost_user_iotlb_remove_notify(dev, node);\n \t\t\tvhost_user_iotlb_pool_put(dev, node);\n \t\t\tdev->iotlb_cache_nr--;\n \t\t} else {\ndiff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h\nindex cc5c707205..2ad26f6951 100644\n--- a/lib/vhost/vhost.h\n+++ b/lib/vhost/vhost.h\n@@ -89,10 +89,14 @@\n \tfor (iter = val; iter < num; iter++)\n #endif\n \n+struct virtio_net;\n+typedef void (*vhost_iotlb_remove_notify)(uint64_t addr, uint64_t off, uint64_t size);\n+\n /**\n * Structure that contains backend-specific ops.\n */\n struct vhost_backend_ops {\n+\tvhost_iotlb_remove_notify iotlb_remove_notify;\n };\n \n /**\n", "prefixes": [ "RFC", "12/27" ] }