Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125687/?format=api
{ "id": 125687, "url": "http://patches.dpdk.org/api/patches/125687/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230331154259.1447831-12-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230331154259.1447831-12-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230331154259.1447831-12-maxime.coquelin@redhat.com", "date": "2023-03-31T15:42:43", "name": "[RFC,11/27] vhost: introduce backend ops", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a6347b4611f61a9b6ecac72bdbddda382ef59c7b", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230331154259.1447831-12-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 27594, "url": "http://patches.dpdk.org/api/series/27594/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27594", "date": "2023-03-31T15:42:32", "name": "Add VDUSE support to Vhost library", "version": 1, "mbox": "http://patches.dpdk.org/series/27594/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125687/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/125687/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 972AA42887;\n\tFri, 31 Mar 2023 17:44:36 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E963F42DAA;\n\tFri, 31 Mar 2023 17:43:41 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id E4A5F42D9B\n for <dev@dpdk.org>; Fri, 31 Mar 2023 17:43:38 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-48-vgbSIVJDNG-P3a1ye3wr4A-1; Fri, 31 Mar 2023 11:43:35 -0400", "from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com\n [10.11.54.4])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E626E280BF67;\n Fri, 31 Mar 2023 15:43:34 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.6])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 9050D2028E8F;\n Fri, 31 Mar 2023 15:43:32 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1680277418;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=K1HiwmdWGZNQqKxh0U2Bsu9jfh4mu0cl1yEOM0Jp3Sc=;\n b=iZdKqk4Rj+P8TmLQvk4ZBeW/WylQhv6fvuuFLp8/dRwsGsaWzZ7Y42kRRuqjzHASKoRNt7\n eE9cFCu2T6cyTFomh/iXxfO0dJQgRJAEo1DTUHxhOnR6z8QdOlRpWXqMlCo7ompyqNsgm2\n OjleaObC8X/PFSAsZdG/jGBRnZ5AXVU=", "X-MC-Unique": "vgbSIVJDNG-P3a1ye3wr4A-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, david.marchand@redhat.com, chenbo.xia@intel.com,\n mkp@redhat.com, fbl@redhat.com, jasowang@redhat.com,\n cunming.liang@intel.com, xieyongji@bytedance.com, echaudro@redhat.com,\n eperezma@redhat.com, amorenoz@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[RFC 11/27] vhost: introduce backend ops", "Date": "Fri, 31 Mar 2023 17:42:43 +0200", "Message-Id": "<20230331154259.1447831-12-maxime.coquelin@redhat.com>", "In-Reply-To": "<20230331154259.1447831-1-maxime.coquelin@redhat.com>", "References": "<20230331154259.1447831-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch introduces backend ops struct, that will enable\ncalling backend specifics callbacks (Vhost-user, VDUSE), in\nshared code.\n\nThis is an empty shell for now, it will be filled in later\npatches.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/socket.c | 2 +-\n lib/vhost/vhost.c | 8 +++++++-\n lib/vhost/vhost.h | 10 +++++++++-\n lib/vhost/vhost_user.c | 8 ++++++++\n lib/vhost/vhost_user.h | 1 +\n 5 files changed, 26 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c\nindex 669c322e12..ba54263824 100644\n--- a/lib/vhost/socket.c\n+++ b/lib/vhost/socket.c\n@@ -221,7 +221,7 @@ vhost_user_add_connection(int fd, struct vhost_user_socket *vsocket)\n \t\treturn;\n \t}\n \n-\tvid = vhost_new_device();\n+\tvid = vhost_user_new_device();\n \tif (vid == -1) {\n \t\tgoto err;\n \t}\ndiff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c\nindex 4f16307e4d..41f212315e 100644\n--- a/lib/vhost/vhost.c\n+++ b/lib/vhost/vhost.c\n@@ -676,11 +676,16 @@ reset_device(struct virtio_net *dev)\n * there is a new virtio device being attached).\n */\n int\n-vhost_new_device(void)\n+vhost_new_device(struct vhost_backend_ops *ops)\n {\n \tstruct virtio_net *dev;\n \tint i;\n \n+\tif (ops == NULL) {\n+\t\tVHOST_LOG_CONFIG(\"device\", ERR, \"missing backend ops.\\n\");\n+\t\treturn -1;\n+\t}\n+\n \tpthread_mutex_lock(&vhost_dev_lock);\n \tfor (i = 0; i < RTE_MAX_VHOST_DEVICE; i++) {\n \t\tif (vhost_devices[i] == NULL)\n@@ -708,6 +713,7 @@ vhost_new_device(void)\n \tdev->backend_req_fd = -1;\n \tdev->postcopy_ufd = -1;\n \trte_spinlock_init(&dev->backend_req_lock);\n+\tdev->backend_ops = ops;\n \n \treturn i;\n }\ndiff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h\nindex 4ace5ab081..cc5c707205 100644\n--- a/lib/vhost/vhost.h\n+++ b/lib/vhost/vhost.h\n@@ -89,6 +89,12 @@\n \tfor (iter = val; iter < num; iter++)\n #endif\n \n+/**\n+ * Structure that contains backend-specific ops.\n+ */\n+struct vhost_backend_ops {\n+};\n+\n /**\n * Structure contains buffer address, length and descriptor index\n * from vring to do scatter RX.\n@@ -513,6 +519,8 @@ struct virtio_net {\n \tvoid\t\t\t*extern_data;\n \t/* pre and post vhost user message handlers for the device */\n \tstruct rte_vhost_user_extern_ops extern_ops;\n+\n+\tstruct vhost_backend_ops *backend_ops;\n } __rte_cache_aligned;\n \n static inline void\n@@ -812,7 +820,7 @@ get_device(int vid)\n \treturn dev;\n }\n \n-int vhost_new_device(void);\n+int vhost_new_device(struct vhost_backend_ops *ops);\n void cleanup_device(struct virtio_net *dev, int destroy);\n void reset_device(struct virtio_net *dev);\n void vhost_destroy_device(int);\ndiff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c\nindex a989f2c46d..2d5dec5bc1 100644\n--- a/lib/vhost/vhost_user.c\n+++ b/lib/vhost/vhost_user.c\n@@ -3464,3 +3464,11 @@ int rte_vhost_host_notifier_ctrl(int vid, uint16_t qid, bool enable)\n \n \treturn ret;\n }\n+\n+static struct vhost_backend_ops vhost_user_backend_ops;\n+\n+int\n+vhost_user_new_device(void)\n+{\n+\treturn vhost_new_device(&vhost_user_backend_ops);\n+}\ndiff --git a/lib/vhost/vhost_user.h b/lib/vhost/vhost_user.h\nindex a0987a58f9..61456049c8 100644\n--- a/lib/vhost/vhost_user.h\n+++ b/lib/vhost/vhost_user.h\n@@ -185,5 +185,6 @@ int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm);\n int read_fd_message(char *ifname, int sockfd, char *buf, int buflen, int *fds, int max_fds,\n \t\tint *fd_num);\n int send_fd_message(char *ifname, int sockfd, char *buf, int buflen, int *fds, int fd_num);\n+int vhost_user_new_device(void);\n \n #endif\n", "prefixes": [ "RFC", "11/27" ] }