Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125678/?format=api
{ "id": 125678, "url": "http://patches.dpdk.org/api/patches/125678/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230331154259.1447831-3-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230331154259.1447831-3-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230331154259.1447831-3-maxime.coquelin@redhat.com", "date": "2023-03-31T15:42:34", "name": "[RFC,02/27] vhost: fix invalid call FD handling", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dc455c608623d2b8448187b237b9842de9ca346b", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230331154259.1447831-3-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 27594, "url": "http://patches.dpdk.org/api/series/27594/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27594", "date": "2023-03-31T15:42:32", "name": "Add VDUSE support to Vhost library", "version": 1, "mbox": "http://patches.dpdk.org/series/27594/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125678/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/125678/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8EEE742887;\n\tFri, 31 Mar 2023 17:43:23 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 351D342D43;\n\tFri, 31 Mar 2023 17:43:19 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 752EF42D3F\n for <dev@dpdk.org>; Fri, 31 Mar 2023 17:43:17 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-659-tHmC4fGVM4uTS7rJwMC1Sg-1; Fri, 31 Mar 2023 11:43:11 -0400", "from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com\n [10.11.54.4])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D9E918533DC;\n Fri, 31 Mar 2023 15:43:10 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.6])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 675A22027040;\n Fri, 31 Mar 2023 15:43:08 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1680277397;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ihLYrf2Njhvqp+07u/lWOhAdbUFFFk+YJ5ldsj+2EEg=;\n b=bVluc/X9pG2uSoSBLg90MW+AV5SgZ5kIB1m63dKsMPlNtyuxUoqjsCWltArlFSiuAGlarg\n 9e/byAzo+2FRy0ldoZZN98Q5jicWtLffmRsjBrDdggiO1e2tFyik0NMTvNELm1CUXfPf27\n WdIZvfb9tOapqV9s2KRyGJxmNkFjT0w=", "X-MC-Unique": "tHmC4fGVM4uTS7rJwMC1Sg-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, david.marchand@redhat.com, chenbo.xia@intel.com,\n mkp@redhat.com, fbl@redhat.com, jasowang@redhat.com,\n cunming.liang@intel.com, xieyongji@bytedance.com, echaudro@redhat.com,\n eperezma@redhat.com, amorenoz@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tstable@dpdk.org", "Subject": "[RFC 02/27] vhost: fix invalid call FD handling", "Date": "Fri, 31 Mar 2023 17:42:34 +0200", "Message-Id": "<20230331154259.1447831-3-maxime.coquelin@redhat.com>", "In-Reply-To": "<20230331154259.1447831-1-maxime.coquelin@redhat.com>", "References": "<20230331154259.1447831-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch fixes cases where IRQ injection is tried while\nthe call FD is not valid, which should not happen.\n\nFixes: b1cce26af1dc (\"vhost: add notification for packed ring\")\nFixes: e37ff954405a (\"vhost: support virtqueue interrupt/notification suppression\")\nCc: stable@dpdk.org\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/vhost.h | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h\nindex 8554ab4002..40863f7bfd 100644\n--- a/lib/vhost/vhost.h\n+++ b/lib/vhost/vhost.h\n@@ -902,9 +902,9 @@ vhost_vring_call_split(struct virtio_net *dev, struct vhost_virtqueue *vq)\n \t\t\t\"%s: used_event_idx=%d, old=%d, new=%d\\n\",\n \t\t\t__func__, vhost_used_event(vq), old, new);\n \n-\t\tif ((vhost_need_event(vhost_used_event(vq), new, old) &&\n-\t\t\t\t\t(vq->callfd >= 0)) ||\n-\t\t\t\tunlikely(!signalled_used_valid)) {\n+\t\tif ((vhost_need_event(vhost_used_event(vq), new, old) ||\n+\t\t\t\t\tunlikely(!signalled_used_valid)) &&\n+\t\t\t\tvq->callfd >= 0) {\n \t\t\teventfd_write(vq->callfd, (eventfd_t) 1);\n \t\t\tif (dev->flags & VIRTIO_DEV_STATS_ENABLED)\n \t\t\t\tvq->stats.guest_notifications++;\n@@ -971,7 +971,7 @@ vhost_vring_call_packed(struct virtio_net *dev, struct vhost_virtqueue *vq)\n \tif (vhost_need_event(off, new, old))\n \t\tkick = true;\n kick:\n-\tif (kick) {\n+\tif (kick && vq->callfd >= 0) {\n \t\teventfd_write(vq->callfd, (eventfd_t)1);\n \t\tif (dev->flags & VIRTIO_DEV_STATS_ENABLED)\n \t\t\tvq->stats.guest_notifications++;\n", "prefixes": [ "RFC", "02/27" ] }