Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125593/?format=api
{ "id": 125593, "url": "http://patches.dpdk.org/api/patches/125593/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230329234049.11071-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230329234049.11071-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230329234049.11071-2-stephen@networkplumber.org", "date": "2023-03-29T23:40:28", "name": "[v12,01/22] gso: don't log message on non TCP/UDP", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9adfb914ac1c424a573cf598e81382532b82bfee", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230329234049.11071-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 27577, "url": "http://patches.dpdk.org/api/series/27577/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27577", "date": "2023-03-29T23:40:27", "name": "Covert static log types in libraries to dynamic", "version": 12, "mbox": "http://patches.dpdk.org/series/27577/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125593/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125593/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D572C42868;\n\tThu, 30 Mar 2023 01:40:58 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 12B2F42B71;\n\tThu, 30 Mar 2023 01:40:58 +0200 (CEST)", "from mail-pl1-f174.google.com (mail-pl1-f174.google.com\n [209.85.214.174])\n by mails.dpdk.org (Postfix) with ESMTP id 1E16E41138\n for <dev@dpdk.org>; Thu, 30 Mar 2023 01:40:57 +0200 (CEST)", "by mail-pl1-f174.google.com with SMTP id ja10so16487848plb.5\n for <dev@dpdk.org>; Wed, 29 Mar 2023 16:40:57 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n f10-20020a17090274ca00b0019c2b1c4db1sm23360095plt.239.2023.03.29.16.40.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Mar 2023 16:40:55 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1680133256;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=22sb9KeaWCIHf//+hSXs7eWusMhXwHuF7sjijeI+aRE=;\n b=unxZs94JjtRtjLD/agARiK/DjnEnz3wdbp3vV06jQc297wzO4zKVUlDQyhLKeTBDlX\n l0gO68KteWc2/VRBJKJsnxqASTd4G5yg8NtfUConjMh0G7yXRVomnHJRj3x1qcDNDBNH\n fA86/37DQUulhny4tdbGbLTbYNP4QXrlmX5nBGjXrhw00X61FzjdwCds5j2ufTubmXKx\n h0KXIU2EyqadtdagY6VpffeaGQDEm+iHvPABNV56kJllsUCLVIzEsWEboanggToAE6UC\n GgG64Qi7dPJ+haWGX5BaDWU2YZCukDfJ3qcfiTDg/dJxEgTk7tZ0hap2uinM+1TXXNNs\n n3sA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112; t=1680133256;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=22sb9KeaWCIHf//+hSXs7eWusMhXwHuF7sjijeI+aRE=;\n b=Yi6fXAYwYzNcGwVz1ngsDfOso1DE4Wb8e63NQb3/fE3sYoANqNwJigACsFjy+Fdfq7\n 2PQQ9WpmhxKgvk7ejmNMOQe50lxHL2dJ529fATHr31LTvZ1W/FY9iuak7JlMe6EU8xK3\n 9MSOKUe2xIUknbrM6rI5fSg+wfzWp1gmU7eJ2Cj4NUWCkCLzKSQpigX/SZr3n/vCjiev\n cys7uRoSMn4tYIkzMTADT72SoVCwQyT/Naz/hQt21pK+5mBcq+jL9Fn4kiBngjAJRn5y\n K1vpz5NXi0ejpWTSEZBK8ef25SMxomXFxHghfO8T8R7HBDi00/KRhUlhKwKFZpYjLHUW\n mzdQ==", "X-Gm-Message-State": "AAQBX9foD7oEYE6AXZdDclmHEqXb+jAlQRjVzWzTnWqVx9r3y9+0bALx\n dTHjLHMOJVffsKQ4VW43cOUTdBOCk7fukb9PzeFtgg==", "X-Google-Smtp-Source": "\n AKy350YZ5Fdcbji9+72mcn3Eq83iH259aFfux8II74kF3k2iwiaqbJKX0Ov6RxKEwjGQOHsq1uxNNQ==", "X-Received": "by 2002:a17:90b:33c7:b0:23f:35c8:895 with SMTP id\n lk7-20020a17090b33c700b0023f35c80895mr22002166pjb.32.1680133255963;\n Wed, 29 Mar 2023 16:40:55 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Jiayu Hu <jiayu.hu@intel.com>, Mark Kavanagh <mark.b.kavanagh@intel.com>", "Subject": "[PATCH v12 01/22] gso: don't log message on non TCP/UDP", "Date": "Wed, 29 Mar 2023 16:40:28 -0700", "Message-Id": "<20230329234049.11071-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230329234049.11071-1-stephen@networkplumber.org>", "References": "<20230329234049.11071-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "If a large packet is passed into GSO routines of unknown protocol\nthen library would log a message.\nBetter to tell the application instead of logging.\n\nFixes: 119583797b6a (\"gso: support TCP/IPv4 GSO\")\nReviewed-by: Jiayu Hu <jiayu.hu@intel.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/gso/rte_gso.c | 4 +---\n lib/gso/rte_gso.h | 1 +\n 2 files changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/gso/rte_gso.c b/lib/gso/rte_gso.c\nindex 4b59217c16ee..e29c7d884aed 100644\n--- a/lib/gso/rte_gso.c\n+++ b/lib/gso/rte_gso.c\n@@ -80,9 +80,7 @@ rte_gso_segment(struct rte_mbuf *pkt,\n \t\tret = gso_udp4_segment(pkt, gso_size, direct_pool,\n \t\t\t\tindirect_pool, pkts_out, nb_pkts_out);\n \t} else {\n-\t\t/* unsupported packet, skip */\n-\t\tRTE_LOG(DEBUG, GSO, \"Unsupported packet type\\n\");\n-\t\tret = 0;\n+\t\tret = -ENOTSUP;\t/* only UDP or TCP allowed */\n \t}\n \n \tif (ret < 0) {\ndiff --git a/lib/gso/rte_gso.h b/lib/gso/rte_gso.h\nindex 40922524df42..c0f9a1b66ff2 100644\n--- a/lib/gso/rte_gso.h\n+++ b/lib/gso/rte_gso.h\n@@ -114,6 +114,7 @@ struct rte_gso_ctx {\n * - The number of GSO segments filled in pkts_out on success.\n * - Return 0 if it does not need to be GSO'd.\n * - Return -ENOMEM if run out of memory in MBUF pools.\n+ * - Return -ENOTSUP for protocols that can not be segmented\n * - Return -EINVAL for invalid parameters.\n */\n int rte_gso_segment(struct rte_mbuf *pkt,\n", "prefixes": [ "v12", "01/22" ] }