Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125371/?format=api
http://patches.dpdk.org/api/patches/125371/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230321131350.122290-3-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230321131350.122290-3-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230321131350.122290-3-bruce.richardson@intel.com", "date": "2023-03-21T13:13:50", "name": "[2/2] examples/qos_sched: report error if no pipes configured", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3dcc582923a45eb874d2069ebcce46947aedf351", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230321131350.122290-3-bruce.richardson@intel.com/mbox/", "series": [ { "id": 27485, "url": "http://patches.dpdk.org/api/series/27485/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27485", "date": "2023-03-21T13:13:48", "name": "small fixes for QoS profile handling", "version": 1, "mbox": "http://patches.dpdk.org/series/27485/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125371/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125371/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 76973427F7;\n\tTue, 21 Mar 2023 14:14:20 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E70FE42BFE;\n\tTue, 21 Mar 2023 14:14:10 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 14D26410EF\n for <dev@dpdk.org>; Tue, 21 Mar 2023 14:14:08 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Mar 2023 06:14:08 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.22])\n by orsmga001.jf.intel.com with ESMTP; 21 Mar 2023 06:14:07 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1679404449; x=1710940449;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=xhVs5n9wMxpcjXelqqmffA8TtDz7+0YhhXjlVTsvkzA=;\n b=WtQMWi/WdVM83YO0k/hHhXYR2Fo90DT6LqLrA5bMwpZsui1XWnJ4iRWj\n WyHfRCIEB+q1iAoAxKcWPXp0LZQukXEGQObNUE6MMIpBSynVvuQ7K9Tob\n XRxETGPhsJ+SB1mwL7AoFF407/2UgWftsvR7meFE4LnDaOC+W6xjybO/2\n lc42Nhlt5xVJkofKq4nTn4lV9fG6fpAvW6m2Gbc3i3+J1+8ynx5vWaGKe\n 3HTI8+lVu6WCXZtrYrTXYZHbxCe0a/vSZo703SfGORzmMbJRcLiIgAKpH\n lASPTVbGHJYrBrHiqnz9VhZ7alZIEbz6HPfCQAZ8XB0FbgRcu1CIaOKLj g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10656\"; a=\"319325460\"", "E=Sophos;i=\"5.98,279,1673942400\"; d=\"scan'208\";a=\"319325460\"", "E=McAfee;i=\"6600,9927,10656\"; a=\"713992926\"", "E=Sophos;i=\"5.98,279,1673942400\"; d=\"scan'208\";a=\"713992926\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "Subject": "[PATCH 2/2] examples/qos_sched: report error if no pipes configured", "Date": "Tue, 21 Mar 2023 13:13:50 +0000", "Message-Id": "<20230321131350.122290-3-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20230321131350.122290-1-bruce.richardson@intel.com>", "References": "<20230321131350.122290-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Have the QoS scheduler sample application report an error if no pipes\nare configured for a subport.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/qos_sched/init.c | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c\nindex 7a27c03b64..d8abae635a 100644\n--- a/examples/qos_sched/init.c\n+++ b/examples/qos_sched/init.c\n@@ -233,6 +233,7 @@ app_init_sched_port(uint32_t portid, uint32_t socketid)\n \tstruct rte_eth_link link;\n \tstruct rte_sched_port *port = NULL;\n \tuint32_t pipe, subport;\n+\tuint32_t pipe_count;\n \tint err;\n \n \terr = rte_eth_link_get(portid, &link);\n@@ -263,6 +264,7 @@ app_init_sched_port(uint32_t portid, uint32_t socketid)\n \t\tuint32_t n_pipes_per_subport =\n \t\t\tsubport_params[subport].n_pipes_per_subport_enabled;\n \n+\t\tpipe_count = 0;\n \t\tfor (pipe = 0; pipe < n_pipes_per_subport; pipe++) {\n \t\t\tif (app_pipe_to_profile[subport][pipe] != -1) {\n \t\t\t\terr = rte_sched_pipe_config(port, subport, pipe,\n@@ -272,8 +274,13 @@ app_init_sched_port(uint32_t portid, uint32_t socketid)\n \t\t\t\t\t\t\t\"for profile %d, err=%d\\n\", pipe,\n \t\t\t\t\t\t\tapp_pipe_to_profile[subport][pipe], err);\n \t\t\t\t}\n+\t\t\t\tpipe_count++;\n \t\t\t}\n \t\t}\n+\n+\t\tif (pipe_count == 0)\n+\t\t\trte_exit(EXIT_FAILURE, \"Error: invalid config, no pipes enabled for sched subport %u\\n\",\n+\t\t\t\t\tsubport);\n \t}\n \n \treturn port;\n", "prefixes": [ "2/2" ] }{ "id": 125371, "url": "