Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125370/?format=api
{ "id": 125370, "url": "http://patches.dpdk.org/api/patches/125370/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230321131350.122290-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230321131350.122290-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230321131350.122290-2-bruce.richardson@intel.com", "date": "2023-03-21T13:13:49", "name": "[1/2] examples/qos_sched: fix config entries in wrong sections", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e9d56e03eae7934451ff69f55fd12399d8e27ccc", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230321131350.122290-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 27485, "url": "http://patches.dpdk.org/api/series/27485/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27485", "date": "2023-03-21T13:13:48", "name": "small fixes for QoS profile handling", "version": 1, "mbox": "http://patches.dpdk.org/series/27485/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125370/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125370/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E92F3427F7;\n\tTue, 21 Mar 2023 14:14:13 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A24254282D;\n\tTue, 21 Mar 2023 14:14:09 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id C97BC410D1;\n Tue, 21 Mar 2023 14:14:07 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Mar 2023 06:14:04 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.22])\n by orsmga001.jf.intel.com with ESMTP; 21 Mar 2023 06:14:03 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1679404448; x=1710940448;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=R0t1UhuoJVB8gWWMbjv6h6bfCEXETkDTGa352yVc6c8=;\n b=Ohv7S1r4DZGhVZeqPMizWlIQvkNMdfam49nOvhOfLHuf37NJM4sNMB+W\n cXony/rrnecsT8DqNzVWzWAKx56WjhnlYdD8D0mvb6LmpZ654ala8jG/a\n y05Zxpi+M7M1ap0emONl6dZ/RZmijLlP13lQ9Jm5yM6fqvuBrjpesm6Mu\n UkdkSIfUxJZDu4/0HsQyJecj4/anJvysvCmN+Isre9bE7mhhGnUZskdAY\n jgBktBwIpAan3xI/0y9QLtEZpB47VXXG6MQg06du+AtRcAlfLTc8oVdof\n teyCIOJ2v5BOS0ZuWwlzn1rA5plaQQzk6vG6/NWZBE34kJVOtlwK2iVeR w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10656\"; a=\"319325450\"", "E=Sophos;i=\"5.98,279,1673942400\"; d=\"scan'208\";a=\"319325450\"", "E=McAfee;i=\"6600,9927,10656\"; a=\"713992897\"", "E=Sophos;i=\"5.98,279,1673942400\"; d=\"scan'208\";a=\"713992897\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "Subject": "[PATCH 1/2] examples/qos_sched: fix config entries in wrong sections", "Date": "Tue, 21 Mar 2023 13:13:49 +0000", "Message-Id": "<20230321131350.122290-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20230321131350.122290-1-bruce.richardson@intel.com>", "References": "<20230321131350.122290-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When specifying the QoS config, the profiles to be used for each pipe\nwithin a subport must be specified in the subport section, not in the\nsection for the subport profile itself. Similarly for subport profiles,\nthose should be specified in the port section.\n\nFixes: de3cfa2c9823 (\"sched: initial import\")\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/qos_sched/profile.cfg | 6 +++---\n examples/qos_sched/profile_ov.cfg | 6 +++---\n examples/qos_sched/profile_pie.cfg | 6 +++---\n examples/qos_sched/profile_red.cfg | 6 +++---\n 4 files changed, 12 insertions(+), 12 deletions(-)\n\n--\n2.37.2", "diff": "diff --git a/examples/qos_sched/profile.cfg b/examples/qos_sched/profile.cfg\nindex e8de101b6c..00d4c7c1a5 100644\n--- a/examples/qos_sched/profile.cfg\n+++ b/examples/qos_sched/profile.cfg\n@@ -26,6 +26,8 @@ number of subports per port = 1\n number of pipes per subport = 4096\n queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64\n\n+pipe 0-4095 = 0 ; These pipes are configured with pipe profile 0\n+\n [subport profile 0]\n tb rate = 1250000000 ; Bytes per second\n tb size = 1000000 ; Bytes\n@@ -46,8 +48,6 @@ tc 12 rate = 1250000000 ; Bytes per second\n\n tc period = 10 ; Milliseconds\n\n-pipe 0-4095 = 0 ; These pipes are configured with pipe profile 0\n-\n ; Pipe configuration\n [pipe profile 0]\n tb rate = 305175 ; Bytes per second\n@@ -71,4 +71,4 @@ tc period = 40 ; Milliseconds\n\n tc 12 oversubscription weight = 1\n\n-tc 12 wrr weights = 1 1 1 1\n\\ No newline at end of file\n+tc 12 wrr weights = 1 1 1 1\ndiff --git a/examples/qos_sched/profile_ov.cfg b/examples/qos_sched/profile_ov.cfg\nindex 14c89ae340..b6fe21ee1e 100644\n--- a/examples/qos_sched/profile_ov.cfg\n+++ b/examples/qos_sched/profile_ov.cfg\n@@ -6,12 +6,14 @@\n frame overhead = 24\n number of subports per port = 1\n\n+subport 0-8 = 0\n+\n ; Subport configuration\n [subport 0]\n number of pipes per subport = 32\n queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64\n\n-subport 0-8 = 0\n+pipe 0-31 = 0 ; These pipes are configured with pipe profile 0\n\n [subport profile 0]\n tb rate = 8400000 ; Bytes per second\n@@ -32,8 +34,6 @@ tc 11 rate = 8400000 ; Bytes per second\n tc 12 rate = 8400000 ; Bytes per second\n tc period = 10 ; Milliseconds\n\n-pipe 0-31 = 0 ; These pipes are configured with pipe profile 0\n-\n ; Pipe configuration\n [pipe profile 0]\n tb rate = 16800000 ; Bytes per second\ndiff --git a/examples/qos_sched/profile_pie.cfg b/examples/qos_sched/profile_pie.cfg\nindex 241f748b33..bbc09d912b 100644\n--- a/examples/qos_sched/profile_pie.cfg\n+++ b/examples/qos_sched/profile_pie.cfg\n@@ -21,12 +21,14 @@\n frame overhead = 24\n number of subports per port = 1\n\n+subport 0-8 = 0 ; These subports are configured with subport profile 0\n+\n ; Subport configuration\n [subport 0]\n number of pipes per subport = 4096\n queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64\n\n-subport 0-8 = 0 ; These subports are configured with subport profile 0\n+pipe 0-4095 = 0 ; These pipes are configured with pipe profile 0\n\n [subport profile 0]\n tb rate = 1250000000 ; Bytes per second\n@@ -48,8 +50,6 @@ tc 12 rate = 1250000000 ; Bytes per second\n\n tc period = 10 ; Milliseconds\n\n-pipe 0-4095 = 0 ; These pipes are configured with pipe profile 0\n-\n ; Pipe configuration\n [pipe profile 0]\n tb rate = 305175 ; Bytes per second\ndiff --git a/examples/qos_sched/profile_red.cfg b/examples/qos_sched/profile_red.cfg\nindex 4486d2799e..cee1470fd7 100644\n--- a/examples/qos_sched/profile_red.cfg\n+++ b/examples/qos_sched/profile_red.cfg\n@@ -21,12 +21,14 @@\n frame overhead = 24\n number of subports per port = 1\n\n+subport 0-8 = 0 ; These subports are configured with subport profile 0\n+\n ; Subport configuration\n [subport 0]\n number of pipes per subport = 4096\n queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64\n\n-subport 0-8 = 0 ; These subports are configured with subport profile 0\n+pipe 0-4095 = 0 ; These pipes are configured with pipe profile 0\n\n [subport profile 0]\n tb rate = 1250000000 ; Bytes per second\n@@ -48,8 +50,6 @@ tc 12 rate = 1250000000 ; Bytes per second\n\n tc period = 10 ; Milliseconds\n\n-pipe 0-4095 = 0 ; These pipes are configured with pipe profile 0\n-\n ; Pipe configuration\n [pipe profile 0]\n tb rate = 305175 ; Bytes per second\n", "prefixes": [ "1/2" ] }