Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125333/?format=api
{ "id": 125333, "url": "http://patches.dpdk.org/api/patches/125333/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1679338836-21321-4-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1679338836-21321-4-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1679338836-21321-4-git-send-email-roretzla@linux.microsoft.com", "date": "2023-03-20T19:00:23", "name": "[v3,03/16] common/mlx5: use previous value atomic fetch operations", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c7f6417f113d0f0dfb113b7e2cdaa2bc22be0e14", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1679338836-21321-4-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 27471, "url": "http://patches.dpdk.org/api/series/27471/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27471", "date": "2023-03-20T19:00:21", "name": "replace __atomic operations returning new value", "version": 3, "mbox": "http://patches.dpdk.org/series/27471/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125333/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125333/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BF7A5427E5;\n\tMon, 20 Mar 2023 20:01:28 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6C2B342C54;\n\tMon, 20 Mar 2023 20:01:09 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 96752410F3\n for <dev@dpdk.org>; Mon, 20 Mar 2023 20:01:02 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id E236120FB1B2; Mon, 20 Mar 2023 12:01:01 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com E236120FB1B2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1679338861;\n bh=7MtsXrm5aGlCAR057cFKAxXgAjohMLo6Xymq8eXlg/4=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=WoTMJH9x3ohGiizP/QzSlcDiQVDE8APvHERh/wLmnQSZA2G0X87yUhiedzQ8FlRsN\n 6gmO1TQLffS04xgl5KKuAhURyQOm/FdzcwAI/8F7XWlsTx6MlU3zNEHhmpdCQKheo0\n ysxPRMWoMQAIm4IZP+33uTNpThM5R/KRIIk69Dwg=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, thomas@monjalon.net,\n pbhagavatula@marvell.com, ndabilpuram@marvell.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v3 03/16] common/mlx5: use previous value atomic fetch\n operations", "Date": "Mon, 20 Mar 2023 12:00:23 -0700", "Message-Id": "<1679338836-21321-4-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1679338836-21321-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1678486530-20688-1-git-send-email-roretzla@linux.microsoft.com>\n <1679338836-21321-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use __atomic_fetch_{add,and,or,sub,xor} instead of\n__atomic_{add,and,or,sub,xor}_fetch adding the necessary code to\nallow consumption of the resulting value.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/common/mlx5/linux/mlx5_nl.c | 2 +-\n drivers/common/mlx5/mlx5_common_mr.c | 8 ++++----\n drivers/common/mlx5/mlx5_common_utils.c | 8 ++++----\n 3 files changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/linux/mlx5_nl.c b/drivers/common/mlx5/linux/mlx5_nl.c\nindex 5d04857..33670bb 100644\n--- a/drivers/common/mlx5/linux/mlx5_nl.c\n+++ b/drivers/common/mlx5/linux/mlx5_nl.c\n@@ -178,7 +178,7 @@ struct mlx5_nl_port_info {\n uint32_t atomic_sn;\n \n /* Generate Netlink sequence number. */\n-#define MLX5_NL_SN_GENERATE __atomic_add_fetch(&atomic_sn, 1, __ATOMIC_RELAXED)\n+#define MLX5_NL_SN_GENERATE (__atomic_fetch_add(&atomic_sn, 1, __ATOMIC_RELAXED) + 1)\n \n /**\n * Opens a Netlink socket.\ndiff --git a/drivers/common/mlx5/mlx5_common_mr.c b/drivers/common/mlx5/mlx5_common_mr.c\nindex 0e1d243..037a4d8 100644\n--- a/drivers/common/mlx5/mlx5_common_mr.c\n+++ b/drivers/common/mlx5/mlx5_common_mr.c\n@@ -58,8 +58,8 @@ struct mlx5_mempool_reg {\n \n \tif (__atomic_load_n(&buf->refcnt, __ATOMIC_RELAXED) == 1) {\n \t\trte_mempool_put(buf->mp, buf);\n-\t} else if (unlikely(__atomic_sub_fetch(&buf->refcnt, 1,\n-\t\t\t\t\t __ATOMIC_RELAXED) == 0)) {\n+\t} else if (unlikely(__atomic_fetch_sub(&buf->refcnt, 1,\n+\t\t\t\t\t __ATOMIC_RELAXED) - 1 == 0)) {\n \t\t__atomic_store_n(&buf->refcnt, 1, __ATOMIC_RELAXED);\n \t\trte_mempool_put(buf->mp, buf);\n \t}\n@@ -1665,8 +1665,8 @@ struct mlx5_mempool_get_extmem_data {\n \tbool ret = false;\n \n \tfor (i = 0; i < mpr->mrs_n; i++)\n-\t\tret |= __atomic_sub_fetch(&mpr->mrs[i].refcnt, 1,\n-\t\t\t\t\t __ATOMIC_RELAXED) == 0;\n+\t\tret |= __atomic_fetch_sub(&mpr->mrs[i].refcnt, 1,\n+\t\t\t\t\t __ATOMIC_RELAXED) - 1 == 0;\n \treturn ret;\n }\n \ndiff --git a/drivers/common/mlx5/mlx5_common_utils.c b/drivers/common/mlx5/mlx5_common_utils.c\nindex 58d744b..06b5b9b 100644\n--- a/drivers/common/mlx5/mlx5_common_utils.c\n+++ b/drivers/common/mlx5/mlx5_common_utils.c\n@@ -81,8 +81,8 @@ struct mlx5_list *\n \twhile (entry != NULL) {\n \t\tif (l_const->cb_match(l_const->ctx, entry, ctx) == 0) {\n \t\t\tif (reuse) {\n-\t\t\t\tret = __atomic_add_fetch(&entry->ref_cnt, 1,\n-\t\t\t\t\t\t\t __ATOMIC_RELAXED) - 1;\n+\t\t\t\tret = __atomic_fetch_add(&entry->ref_cnt, 1,\n+\t\t\t\t\t\t\t __ATOMIC_RELAXED);\n \t\t\t\tDRV_LOG(DEBUG, \"mlx5 list %s entry %p ref: %u.\",\n \t\t\t\t\tl_const->name, (void *)entry,\n \t\t\t\t\tentry->ref_cnt);\n@@ -285,7 +285,7 @@ struct mlx5_list_entry *\n {\n \tstruct mlx5_list_entry *gentry = entry->gentry;\n \n-\tif (__atomic_sub_fetch(&entry->ref_cnt, 1, __ATOMIC_RELAXED) != 0)\n+\tif (__atomic_fetch_sub(&entry->ref_cnt, 1, __ATOMIC_RELAXED) - 1 != 0)\n \t\treturn 1;\n \tif (entry->lcore_idx == (uint32_t)lcore_idx) {\n \t\tLIST_REMOVE(entry, next);\n@@ -303,7 +303,7 @@ struct mlx5_list_entry *\n \t\t\tl_const->name, (void *)entry);\n \t\treturn 0;\n \t}\n-\tif (__atomic_sub_fetch(&gentry->ref_cnt, 1, __ATOMIC_RELAXED) != 0)\n+\tif (__atomic_fetch_sub(&gentry->ref_cnt, 1, __ATOMIC_RELAXED) - 1 != 0)\n \t\treturn 1;\n \trte_rwlock_write_lock(&l_inconst->lock);\n \tif (likely(gentry->ref_cnt == 0)) {\n", "prefixes": [ "v3", "03/16" ] }