Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125332/?format=api
{ "id": 125332, "url": "http://patches.dpdk.org/api/patches/125332/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1679338836-21321-5-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1679338836-21321-5-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1679338836-21321-5-git-send-email-roretzla@linux.microsoft.com", "date": "2023-03-20T19:00:24", "name": "[v3,04/16] drivers/event: use previous value atomic fetch operations", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f74991b905b545be6b2a298110be7e468c2d4db0", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1679338836-21321-5-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 27471, "url": "http://patches.dpdk.org/api/series/27471/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27471", "date": "2023-03-20T19:00:21", "name": "replace __atomic operations returning new value", "version": 3, "mbox": "http://patches.dpdk.org/series/27471/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125332/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125332/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 72242427E5;\n\tMon, 20 Mar 2023 20:01:22 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1A2DF42BFE;\n\tMon, 20 Mar 2023 20:01:08 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 9AC1E41133\n for <dev@dpdk.org>; Mon, 20 Mar 2023 20:01:02 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id EE37520FB1BC; Mon, 20 Mar 2023 12:01:01 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com EE37520FB1BC", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1679338861;\n bh=KwkIPukJhLJutuumpiLf0nkOHPZ3M576XBwAsmBTZ/I=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=IRJTdcWvIoPQCH+jFXX7UjI1lUAVmEB3yVAYf3iX4TH/IIo6ZFZ5/1Ns5DVM96+qD\n 9Dybi2Aq94Vgo/eURoUsH/jNsNSI5E30hwJIRsVDGZ6Z36qWNXSqTBE+MmQ8zaAYA5\n w35BApMHQ2F17R0S09OQFWR6SRMQ/LznYFP7GvJo=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, thomas@monjalon.net,\n pbhagavatula@marvell.com, ndabilpuram@marvell.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v3 04/16] drivers/event: use previous value atomic fetch\n operations", "Date": "Mon, 20 Mar 2023 12:00:24 -0700", "Message-Id": "<1679338836-21321-5-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1679338836-21321-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1678486530-20688-1-git-send-email-roretzla@linux.microsoft.com>\n <1679338836-21321-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use __atomic_fetch_{add,and,or,sub,xor} instead of\n__atomic_{add,and,or,sub,xor}_fetch adding the necessary code to\nallow consumption of the resulting value.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/event/cnxk/cnxk_tim_worker.h | 2 +-\n drivers/event/dsw/dsw_event.c | 4 ++--\n drivers/event/octeontx/timvf_worker.h | 2 +-\n 3 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/event/cnxk/cnxk_tim_worker.h b/drivers/event/cnxk/cnxk_tim_worker.h\nindex a326d55..0bd66ec 100644\n--- a/drivers/event/cnxk/cnxk_tim_worker.h\n+++ b/drivers/event/cnxk/cnxk_tim_worker.h\n@@ -123,7 +123,7 @@\n \tconst uint64_t v =\n \t\t~(TIM_BUCKET_W1_M_NUM_ENTRIES << TIM_BUCKET_W1_S_NUM_ENTRIES);\n \n-\treturn __atomic_and_fetch(&bktp->w1, v, __ATOMIC_ACQ_REL);\n+\treturn __atomic_fetch_and(&bktp->w1, v, __ATOMIC_ACQ_REL) & v;\n }\n \n static inline uint64_t\ndiff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c\nindex 9932caf..cbdc03f 100644\n--- a/drivers/event/dsw/dsw_event.c\n+++ b/drivers/event/dsw/dsw_event.c\n@@ -45,8 +45,8 @@\n \t * allocation.\n \t */\n \tnew_total_on_loan =\n-\t __atomic_add_fetch(&dsw->credits_on_loan, acquired_credits,\n-\t\t\t __ATOMIC_RELAXED);\n+\t __atomic_fetch_add(&dsw->credits_on_loan, acquired_credits,\n+\t\t\t __ATOMIC_RELAXED) + acquired_credits;\n \n \tif (unlikely(new_total_on_loan > dsw->max_inflight)) {\n \t\t/* Some other port took the last credits */\ndiff --git a/drivers/event/octeontx/timvf_worker.h b/drivers/event/octeontx/timvf_worker.h\nindex 3f1e77f..aa729f8 100644\n--- a/drivers/event/octeontx/timvf_worker.h\n+++ b/drivers/event/octeontx/timvf_worker.h\n@@ -135,7 +135,7 @@\n {\n \tconst uint64_t v = ~(TIM_BUCKET_W1_M_NUM_ENTRIES <<\n \t\t\tTIM_BUCKET_W1_S_NUM_ENTRIES);\n-\treturn __atomic_and_fetch(&bktp->w1, v, __ATOMIC_ACQ_REL);\n+\treturn __atomic_fetch_and(&bktp->w1, v, __ATOMIC_ACQ_REL) & v;\n }\n \n static inline struct tim_mem_entry *\n", "prefixes": [ "v3", "04/16" ] }