Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125240/?format=api
{ "id": 125240, "url": "http://patches.dpdk.org/api/patches/125240/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1679092460-9930-3-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1679092460-9930-3-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1679092460-9930-3-git-send-email-roretzla@linux.microsoft.com", "date": "2023-03-17T22:34:16", "name": "[2/6] net/ixgbe: use rte thread API", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "efddc1ff0b3dc0d652ff3470a711291d1eb789b0", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1679092460-9930-3-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 27444, "url": "http://patches.dpdk.org/api/series/27444/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27444", "date": "2023-03-17T22:34:16", "name": "windows: remove most pthread lifetime shim functions", "version": 1, "mbox": "http://patches.dpdk.org/series/27444/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125240/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125240/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 48FD241EC5;\n\tFri, 17 Mar 2023 23:34:51 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D6AC242FE8;\n\tFri, 17 Mar 2023 23:34:50 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 5F20C40DF6\n for <dev@dpdk.org>; Fri, 17 Mar 2023 23:34:49 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id B10E02057BEA; Fri, 17 Mar 2023 15:34:48 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com B10E02057BEA", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1679092488;\n bh=bLhM8wHBeWKdRYbKi4pkuzhf4ZsxGYPZRqfwluMKfLw=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=qpgvXZ6uoWb16yPv2LMmK+Xp1J8NwmEi9D1RdXQ1CbdZS3pUbU5eTwP7YoAHYa2en\n GHjygGyEL5wj1zoKWR7PCLfGxJSYDrGYMRMzIIc2xKtTDk0o/z+2yLkBczAE6OXJOj\n MtvlycoodkVZJnjCTDlvB3FMAIvpEK2LoMvB5E/4=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net,\n\tTyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH 2/6] net/ixgbe: use rte thread API", "Date": "Fri, 17 Mar 2023 15:34:16 -0700", "Message-Id": "<1679092460-9930-3-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1679092460-9930-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1679092460-9930-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Update driver to use rte thread API where available instead of pthread\nas a prerequisite to removing pthread stubs on Windows.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 10 +++++-----\n drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-\n 2 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 88118bc..3abe96e 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -236,7 +236,7 @@ static int ixgbe_dev_rss_reta_query(struct rte_eth_dev *dev,\n static int ixgbe_dev_interrupt_action(struct rte_eth_dev *dev);\n static void ixgbe_dev_interrupt_handler(void *param);\n static void ixgbe_dev_interrupt_delayed_handler(void *param);\n-static void *ixgbe_dev_setup_link_thread_handler(void *param);\n+static uint32_t ixgbe_dev_setup_link_thread_handler(void *param);\n static int ixgbe_dev_wait_setup_link_complete(struct rte_eth_dev *dev,\n \t\t\t\t\t uint32_t timeout_ms);\n \n@@ -4203,7 +4203,7 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n \treturn 1;\n }\n \n-static void *\n+static uint32_t\n ixgbe_dev_setup_link_thread_handler(void *param)\n {\n \tstruct rte_eth_dev *dev = (struct rte_eth_dev *)param;\n@@ -4214,7 +4214,7 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n \tu32 speed;\n \tbool autoneg = false;\n \n-\tpthread_detach(pthread_self());\n+\trte_thread_detach(rte_thread_self());\n \tspeed = hw->phy.autoneg_advertised;\n \tif (!speed)\n \t\tixgbe_get_link_capabilities(hw, &speed, &autoneg);\n@@ -4223,7 +4223,7 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n \n \tintr->flags &= ~IXGBE_FLAG_NEED_LINK_CONFIG;\n \trte_atomic32_clear(&ad->link_thread_running);\n-\treturn NULL;\n+\treturn 0;\n }\n \n /*\n@@ -4323,7 +4323,7 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n \t\t\t\t * when there is no link thread running.\n \t\t\t\t */\n \t\t\t\tintr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG;\n-\t\t\t\tif (rte_ctrl_thread_create(&ad->link_thread_tid,\n+\t\t\t\tif (rte_thread_create_control(&ad->link_thread_tid,\n \t\t\t\t\t\"ixgbe-link-handler\",\n \t\t\t\t\tNULL,\n \t\t\t\t\tixgbe_dev_setup_link_thread_handler,\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h\nindex 48290af..4332b2c 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.h\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.h\n@@ -511,7 +511,7 @@ struct ixgbe_adapter {\n \tuint8_t pflink_fullchk;\n \tuint8_t mac_ctrl_frame_fwd;\n \trte_atomic32_t link_thread_running;\n-\tpthread_t link_thread_tid;\n+\trte_thread_t link_thread_tid;\n };\n \n struct ixgbe_vf_representor {\n", "prefixes": [ "2/6" ] }