Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125146/?format=api
{ "id": 125146, "url": "http://patches.dpdk.org/api/patches/125146/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230315135427.11489-1-syalavarthi@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230315135427.11489-1-syalavarthi@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230315135427.11489-1-syalavarthi@marvell.com", "date": "2023-03-15T13:54:27", "name": "[1/1] ml/cnxk: fix multiple coverity issues", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0d74be7dbf0267d0353a02beb503d8ee45622d1d", "submitter": { "id": 2480, "url": "http://patches.dpdk.org/api/people/2480/?format=api", "name": "Srikanth Yalavarthi", "email": "syalavarthi@marvell.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230315135427.11489-1-syalavarthi@marvell.com/mbox/", "series": [ { "id": 27403, "url": "http://patches.dpdk.org/api/series/27403/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27403", "date": "2023-03-15T13:54:27", "name": "[1/1] ml/cnxk: fix multiple coverity issues", "version": 1, "mbox": "http://patches.dpdk.org/series/27403/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125146/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/125146/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9662E41E9F;\n\tWed, 15 Mar 2023 14:54:44 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7309140A7A;\n\tWed, 15 Mar 2023 14:54:44 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 2FC7B40141\n for <dev@dpdk.org>; Wed, 15 Mar 2023 14:54:43 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 32FBMjoI005927 for <dev@dpdk.org>; Wed, 15 Mar 2023 06:54:42 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3pb2a8jb59-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Wed, 15 Mar 2023 06:54:42 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.42;\n Wed, 15 Mar 2023 06:54:29 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.42 via Frontend\n Transport; Wed, 15 Mar 2023 06:54:29 -0700", "from ml-host-33.caveonetworks.com (unknown [10.110.143.233])\n by maili.marvell.com (Postfix) with ESMTP id 97B0A3F7048;\n Wed, 15 Mar 2023 06:54:29 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-type; s=pfpt0220;\n bh=k0dyNXHs5c762L8f3fH2fBFJZlQ2NusrmkJBI1UmWxY=;\n b=R6Wp065SxeBQF+KAEcQ69d53fKmLUJ+297LDjn/TQLiemO9M5sCitpAAW03cBYieRaZj\n oCtu+lRvTFTUZncphDDZ00OYsszuL/3Hvbwyev4fZiVuyjMbgCyTD7evdlXI5ty8Zuop\n wwuvz7PVCL/x5YVo4cbSLY74UecwITIZf9INe9+zURihpA6AojDgzkOcQIUhLk1CL2ck\n eZiPMjPj2KaLWkkqJ6cb5Z26wFrSVYWlsfRtge63GibPKdrQ/RrnOYEgPAG0fB2vy7lF\n NioQnOmW+DcyhLK5GxHhAeEtg6wmLl7AoMtFDN9w+mLiSwR5pvGHd7fa4ZExfMStGNT4 gw==", "From": "Srikanth Yalavarthi <syalavarthi@marvell.com>", "To": "Srikanth Yalavarthi <syalavarthi@marvell.com>, Prince Takkar\n <ptakkar@marvell.com>", "CC": "<dev@dpdk.org>, <sshankarnara@marvell.com>", "Subject": "[PATCH 1/1] ml/cnxk: fix multiple coverity issues", "Date": "Wed, 15 Mar 2023 06:54:27 -0700", "Message-ID": "<20230315135427.11489-1-syalavarthi@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "NPGVxSvaEZXoRpk5FHWbq8meFEnuKDrq", "X-Proofpoint-GUID": "NPGVxSvaEZXoRpk5FHWbq8meFEnuKDrq", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22\n definitions=2023-03-15_06,2023-03-15_01,2023-02-09_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Added checks for null pointers. Removed logically dead\ncode. Fix division or modulo by zero. Fix evaludation\norder violation issues.\n\nCoverity issue: 383658 383659, 383664, 383665\nFixes: 817e3e55bb18 (\"ml/cnxk: support simulator environment\")\nFixes: da3325131d71 (\"ml/cnxk: find OCM mask and page slots for a model\")\nFixes: b7d0650ebce0 (\"ml/cnxk: reserve and free OCM pages\")\nFixes: 4ff4ab8e1a20 (\"ml/cnxk: support extended statistics\")\n\nSigned-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>\n---\n drivers/ml/cnxk/cn10k_ml_dev.c | 4 ++--\n drivers/ml/cnxk/cn10k_ml_ocm.c | 33 +++++++--------------------------\n drivers/ml/cnxk/cn10k_ml_ops.c | 3 ++-\n 3 files changed, 11 insertions(+), 29 deletions(-)", "diff": "diff --git a/drivers/ml/cnxk/cn10k_ml_dev.c b/drivers/ml/cnxk/cn10k_ml_dev.c\nindex 6f9a1015a6..bba3c9022e 100644\n--- a/drivers/ml/cnxk/cn10k_ml_dev.c\n+++ b/drivers/ml/cnxk/cn10k_ml_dev.c\n@@ -779,8 +779,8 @@ cn10k_ml_fw_load(struct cn10k_ml_dev *mldev)\n \tif (roc_env_is_emulator() || roc_env_is_hw()) {\n \t\t/* Read firmware image to a buffer */\n \t\tret = rte_firmware_read(fw->path, &fw_buffer, &fw_size);\n-\t\tif (ret < 0) {\n-\t\t\tplt_err(\"Can't read firmware data: %s\\n\", fw->path);\n+\t\tif ((ret < 0) || (fw_buffer == NULL)) {\n+\t\t\tplt_err(\"Unable to read firmware data: %s\\n\", fw->path);\n \t\t\treturn ret;\n \t\t}\n \ndiff --git a/drivers/ml/cnxk/cn10k_ml_ocm.c b/drivers/ml/cnxk/cn10k_ml_ocm.c\nindex d8d2c71a3c..f0f76b83b3 100644\n--- a/drivers/ml/cnxk/cn10k_ml_ocm.c\n+++ b/drivers/ml/cnxk/cn10k_ml_ocm.c\n@@ -224,7 +224,6 @@ cn10k_ml_ocm_tilemask_find(struct rte_ml_dev *dev, uint8_t num_tiles, uint16_t w\n \tuint16_t scratch_page_start;\n \tint used_last_wb_page_max;\n \tuint16_t scratch_page_end;\n-\tuint8_t search_start_tile;\n \tuint8_t search_end_tile;\n \tuint8_t *local_ocm_mask;\n \tint wb_page_start_curr;\n@@ -235,7 +234,6 @@ cn10k_ml_ocm_tilemask_find(struct rte_ml_dev *dev, uint8_t num_tiles, uint16_t w\n \tuint16_t word_id;\n \tuint8_t tile_idx;\n \tint max_slot_sz;\n-\tint start_tile;\n \tint page_id;\n \n \tmldev = dev->data->dev_private;\n@@ -250,28 +248,14 @@ cn10k_ml_ocm_tilemask_find(struct rte_ml_dev *dev, uint8_t num_tiles, uint16_t w\n \twb_page_start = -1;\n \tused_scratch_pages_max = 0;\n \tused_last_wb_page_max = -1;\n-\tstart_tile = -1;\n \tmax_slot_sz_curr = 0;\n \tmax_slot_sz = 0;\n \ttile_idx = 0;\n \n-\tif ((start_tile != -1) && (start_tile % num_tiles != 0)) {\n-\t\tplt_err(\"Invalid start_tile, %d\", start_tile);\n-\t\treturn -1;\n-\t}\n-\n-\tif (start_tile < 0) {\n-\t\tsearch_start_tile = 0;\n-\t\tsearch_end_tile = ocm->num_tiles - num_tiles;\n-\t} else {\n-\t\tsearch_start_tile = start_tile;\n-\t\tsearch_end_tile = start_tile;\n-\t}\n-\n-\t/* nibbles + prefix '0x' */\n+\tsearch_end_tile = ocm->num_tiles - num_tiles;\n \tlocal_ocm_mask = rte_zmalloc(\"local_ocm_mask\", mldev->ocm.mask_words, RTE_CACHE_LINE_SIZE);\n+\ttile_start = 0;\n \n-\ttile_start = search_start_tile;\n start_search:\n \tused_scratch_pages_max = 0;\n \tused_last_wb_page_max = -1;\n@@ -423,10 +407,8 @@ cn10k_ml_ocm_free_pages(struct rte_ml_dev *dev, uint16_t model_id)\n \twb_page_end = wb_page_start + model->model_mem_map.wb_pages - 1;\n \tfor (tile_id = model->addr.tile_start; tile_id <= model->addr.tile_end; tile_id++) {\n \t\tfor (page_id = wb_page_start; page_id <= wb_page_end; page_id++) {\n-\t\t\tocm->tile_ocm_info[tile_id].ocm_mask[page_id / OCM_MAP_WORD_SIZE] =\n-\t\t\t\tCLEAR_BIT(ocm->tile_ocm_info[tile_id]\n-\t\t\t\t\t\t .ocm_mask[page_id / OCM_MAP_WORD_SIZE],\n-\t\t\t\t\t page_id % OCM_MAP_WORD_SIZE);\n+\t\t\tCLEAR_BIT(ocm->tile_ocm_info[tile_id].ocm_mask[page_id / OCM_MAP_WORD_SIZE],\n+\t\t\t\t page_id % OCM_MAP_WORD_SIZE);\n \t\t}\n \n \t\t/* Update last_wb_page size */\n@@ -452,10 +434,9 @@ cn10k_ml_ocm_free_pages(struct rte_ml_dev *dev, uint16_t model_id)\n \t\t\tprev_start = ocm->num_pages - ocm->tile_ocm_info[tile_id].scratch_pages;\n \t\t\tcurr_start = ocm->num_pages - scratch_resize_pages;\n \t\t\tfor (page_id = prev_start; page_id < curr_start; page_id++) {\n-\t\t\t\tocm->tile_ocm_info[tile_id].ocm_mask[page_id / OCM_MAP_WORD_SIZE] =\n-\t\t\t\t\tCLEAR_BIT(ocm->tile_ocm_info[tile_id]\n-\t\t\t\t\t\t\t .ocm_mask[page_id / OCM_MAP_WORD_SIZE],\n-\t\t\t\t\t\t page_id % OCM_MAP_WORD_SIZE);\n+\t\t\t\tCLEAR_BIT(ocm->tile_ocm_info[tile_id]\n+\t\t\t\t\t\t .ocm_mask[page_id / OCM_MAP_WORD_SIZE],\n+\t\t\t\t\t page_id % OCM_MAP_WORD_SIZE);\n \t\t\t}\n \t\t\tocm->tile_ocm_info[tile_id].scratch_pages = scratch_resize_pages;\n \t\t}\ndiff --git a/drivers/ml/cnxk/cn10k_ml_ops.c b/drivers/ml/cnxk/cn10k_ml_ops.c\nindex 7d5eb97668..bf9409ad10 100644\n--- a/drivers/ml/cnxk/cn10k_ml_ops.c\n+++ b/drivers/ml/cnxk/cn10k_ml_ops.c\n@@ -444,7 +444,8 @@ cn10k_ml_prep_fp_job_descriptor(struct rte_ml_dev *dev, struct cn10k_ml_req *req\n \t\t\tcount += model->burst_stats[qp_id].dequeued_count - \\\n \t\t\t\t model->burst_stats[qp_id].str##_reset_count; \\\n \t\t} \\\n-\t\tvalue = value / count; \\\n+\t\tif (count != 0) \\\n+\t\t\tvalue = value / count; \\\n \t} while (0)\n \n #define ML_MIN_FOREACH_QP(dev, model, qp_id, str, value, count) \\\n", "prefixes": [ "1/1" ] }