Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125140/?format=api
{ "id": 125140, "url": "http://patches.dpdk.org/api/patches/125140/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230315110033.30143-3-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230315110033.30143-3-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230315110033.30143-3-liudongdong3@huawei.com", "date": "2023-03-15T11:00:30", "name": "[2/5] net/hns3: support setting and querying RSS hash function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "20da16936249ed53fbcdef356d2713a8ef2b718e", "submitter": { "id": 2718, "url": "http://patches.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230315110033.30143-3-liudongdong3@huawei.com/mbox/", "series": [ { "id": 27400, "url": "http://patches.dpdk.org/api/series/27400/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27400", "date": "2023-03-15T11:00:28", "name": "support setting and querying RSS algorithms", "version": 1, "mbox": "http://patches.dpdk.org/series/27400/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125140/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125140/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EE46441E9F;\n\tWed, 15 Mar 2023 12:02:08 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 13EC542B8E;\n\tWed, 15 Mar 2023 12:02:00 +0100 (CET)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 50437427F2;\n Wed, 15 Mar 2023 12:01:57 +0100 (CET)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.55])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Pc6pB0tWLzfbWB;\n Wed, 15 Mar 2023 18:58:58 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.21; Wed, 15 Mar 2023 19:01:55 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>,\n <andrew.rybchenko@oktetlabs.ru>, <reshma.pattan@intel.com>", "CC": "<stable@dpdk.org>, <yisen.zhuang@huawei.com>, <liudongdong3@huawei.com>,\n Huisong Li <lihuisong@huawei.com>", "Subject": "[PATCH 2/5] net/hns3: support setting and querying RSS hash function", "Date": "Wed, 15 Mar 2023 19:00:30 +0800", "Message-ID": "<20230315110033.30143-3-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20230315110033.30143-1-liudongdong3@huawei.com>", "References": "<20230315110033.30143-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nSupport setting and querying RSS hash function by ethdev ops.\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_rss.c | 47 +++++++++++++++++++++----------------\n 1 file changed, 27 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c\nindex 6126512bd7..c8346d43d1 100644\n--- a/drivers/net/hns3/hns3_rss.c\n+++ b/drivers/net/hns3/hns3_rss.c\n@@ -646,14 +646,14 @@ hns3_dev_rss_hash_update(struct rte_eth_dev *dev,\n \tif (ret)\n \t\tgoto set_tuple_fail;\n \n-\tif (key) {\n-\t\tret = hns3_rss_set_algo_key(hw, hw->rss_info.hash_algo,\n-\t\t\t\t\t key, hw->rss_key_size);\n-\t\tif (ret)\n-\t\t\tgoto set_algo_key_fail;\n-\t\t/* Update the shadow RSS key with user specified */\n+\tret = hns3_update_rss_algo_key(hw, rss_conf->func, key, key_len);\n+\tif (ret != 0)\n+\t\tgoto set_algo_key_fail;\n+\n+\tif (rss_conf->func != RTE_ETH_HASH_FUNCTION_DEFAULT)\n+\t\thw->rss_info.hash_algo = hns3_hash_func_map[rss_conf->func];\n+\tif (key != NULL)\n \t\tmemcpy(hw->rss_info.key, key, hw->rss_key_size);\n-\t}\n \thw->rss_info.rss_hf = rss_hf;\n \trte_spinlock_unlock(&hw->lock);\n \n@@ -769,7 +769,13 @@ int\n hns3_dev_rss_hash_conf_get(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_rss_conf *rss_conf)\n {\n+\tconst uint8_t hash_func_map[] = {\n+\t\t[HNS3_RSS_HASH_ALGO_TOEPLITZ] = RTE_ETH_HASH_FUNCTION_TOEPLITZ,\n+\t\t[HNS3_RSS_HASH_ALGO_SIMPLE] = RTE_ETH_HASH_FUNCTION_SIMPLE_XOR,\n+\t\t[HNS3_RSS_HASH_ALGO_SYMMETRIC_TOEP] = RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,\n+\t};\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n+\tuint8_t rss_key[HNS3_RSS_KEY_SIZE_MAX] = {0};\n \tstruct hns3_hw *hw = &hns->hw;\n \tuint8_t hash_algo;\n \tint ret;\n@@ -777,26 +783,27 @@ hns3_dev_rss_hash_conf_get(struct rte_eth_dev *dev,\n \trte_spinlock_lock(&hw->lock);\n \tret = hns3_rss_hash_get_rss_hf(hw, &rss_conf->rss_hf);\n \tif (ret != 0) {\n+\t\trte_spinlock_unlock(&hw->lock);\n \t\thns3_err(hw, \"obtain hash tuples failed, ret = %d\", ret);\n-\t\tgoto out;\n+\t\treturn ret;\n+\t}\n+\n+\tret = hns3_rss_get_algo_key(hw, &hash_algo, rss_key, hw->rss_key_size);\n+\tif (ret != 0) {\n+\t\trte_spinlock_unlock(&hw->lock);\n+\t\thns3_err(hw, \"obtain hash algo and key failed, ret = %d\", ret);\n+\t\treturn ret;\n \t}\n+\trte_spinlock_unlock(&hw->lock);\n \n-\t/* Get the RSS Key required by the user */\n+\t/* Get the RSS Key if user required. */\n \tif (rss_conf->rss_key && rss_conf->rss_key_len >= hw->rss_key_size) {\n-\t\tret = hns3_rss_get_algo_key(hw, &hash_algo, rss_conf->rss_key,\n-\t\t\t\t\t hw->rss_key_size);\n-\t\tif (ret != 0) {\n-\t\t\thns3_err(hw, \"obtain hash algo and key failed, ret = %d\",\n-\t\t\t\t ret);\n-\t\t\tgoto out;\n-\t\t}\n+\t\tmemcpy(rss_conf->rss_key, rss_key, hw->rss_key_size);\n \t\trss_conf->rss_key_len = hw->rss_key_size;\n \t}\n+\trss_conf->func = hash_func_map[hash_algo];\n \n-out:\n-\trte_spinlock_unlock(&hw->lock);\n-\n-\treturn ret;\n+\treturn 0;\n }\n \n /*\n", "prefixes": [ "2/5" ] }