Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125139/?format=api
{ "id": 125139, "url": "http://patches.dpdk.org/api/patches/125139/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230315110033.30143-2-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230315110033.30143-2-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230315110033.30143-2-liudongdong3@huawei.com", "date": "2023-03-15T11:00:29", "name": "[1/5] ethdev: support setting and querying rss algorithm", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fe4359211b117440824eb201ea22ea8158243550", "submitter": { "id": 2718, "url": "http://patches.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230315110033.30143-2-liudongdong3@huawei.com/mbox/", "series": [ { "id": 27400, "url": "http://patches.dpdk.org/api/series/27400/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27400", "date": "2023-03-15T11:00:28", "name": "support setting and querying RSS algorithms", "version": 1, "mbox": "http://patches.dpdk.org/series/27400/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125139/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125139/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C38BA41E9F;\n\tWed, 15 Mar 2023 12:01:59 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E8DD040141;\n\tWed, 15 Mar 2023 12:01:58 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 025304161A;\n Wed, 15 Mar 2023 12:01:57 +0100 (CET)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.57])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Pc6q16mjrzHwfk;\n Wed, 15 Mar 2023 18:59:41 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.21; Wed, 15 Mar 2023 19:01:52 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>,\n <andrew.rybchenko@oktetlabs.ru>, <reshma.pattan@intel.com>", "CC": "<stable@dpdk.org>, <yisen.zhuang@huawei.com>, <liudongdong3@huawei.com>,\n Jie Hai <haijie1@huawei.com>", "Subject": "[PATCH 1/5] ethdev: support setting and querying rss algorithm", "Date": "Wed, 15 Mar 2023 19:00:29 +0800", "Message-ID": "<20230315110033.30143-2-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20230315110033.30143-1-liudongdong3@huawei.com>", "References": "<20230315110033.30143-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Jie Hai <haijie1@huawei.com>\n\nCurrently, rte_eth_rss_conf supports configuring rss hash\nfunctions, rss key and it's length, but not rss hash algorithm.\n\nThe structure ``rte_eth_rss_conf`` is extended by adding a new field,\n\"func\". This represents the RSS algorithms to apply. The following\nAPI is affected:\n\t- rte_eth_dev_configure\n\t- rte_eth_dev_rss_hash_update\n\t- rte_eth_dev_rss_hash_conf_get\n\nTo prevent configuration failures caused by incorrect func input, check\nthis parameter in advance. If it's incorrect, a warning is generated\nand the default value is set. Do the same for rte_eth_dev_rss_hash_update\nand rte_eth_dev_configure.\n\nTo check whether the drivers report the func field, it is set to default\nvalue before querying.\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n doc/guides/rel_notes/release_23_03.rst | 4 ++--\n lib/ethdev/rte_ethdev.c | 18 ++++++++++++++++++\n lib/ethdev/rte_ethdev.h | 5 +++++\n 3 files changed, 25 insertions(+), 2 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_23_03.rst b/doc/guides/rel_notes/release_23_03.rst\nindex af6f37389c..7879567427 100644\n--- a/doc/guides/rel_notes/release_23_03.rst\n+++ b/doc/guides/rel_notes/release_23_03.rst\n@@ -284,8 +284,8 @@ ABI Changes\n Also, make sure to start the actual text at the margin.\n =======================================================\n \n-* No ABI change that would break compatibility with 22.11.\n-\n+* ethdev: Added \"func\" field to ``rte_eth_rss_conf`` structure for RSS hash\n+ algorithm.\n \n Known Issues\n ------------\ndiff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex 4d03255683..db561026bd 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -1368,6 +1368,15 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,\n \t\tgoto rollback;\n \t}\n \n+\tif (dev_conf->rx_adv_conf.rss_conf.func >= RTE_ETH_HASH_FUNCTION_MAX) {\n+\t\tRTE_ETHDEV_LOG(WARNING,\n+\t\t\t\"Ethdev port_id=%u invalid rss hash function (%u), modified to default value (%u)\\n\",\n+\t\t\tport_id, dev_conf->rx_adv_conf.rss_conf.func,\n+\t\t\tRTE_ETH_HASH_FUNCTION_DEFAULT);\n+\t\tdev->data->dev_conf.rx_adv_conf.rss_conf.func =\n+\t\t\tRTE_ETH_HASH_FUNCTION_DEFAULT;\n+\t}\n+\n \t/* Check if Rx RSS distribution is disabled but RSS hash is enabled. */\n \tif (((dev_conf->rxmode.mq_mode & RTE_ETH_MQ_RX_RSS_FLAG) == 0) &&\n \t (dev_conf->rxmode.offloads & RTE_ETH_RX_OFFLOAD_RSS_HASH)) {\n@@ -4553,6 +4562,13 @@ rte_eth_dev_rss_hash_update(uint16_t port_id,\n \t\treturn -ENOTSUP;\n \t}\n \n+\tif (rss_conf->func >= RTE_ETH_HASH_FUNCTION_MAX) {\n+\t\tRTE_ETHDEV_LOG(NOTICE,\n+\t\t\t\"Ethdev port_id=%u invalid rss hash function (%u), modified to default value (%u)\\n\",\n+\t\t\tport_id, rss_conf->func, RTE_ETH_HASH_FUNCTION_DEFAULT);\n+\t\trss_conf->func = RTE_ETH_HASH_FUNCTION_DEFAULT;\n+\t}\n+\n \tif (*dev->dev_ops->rss_hash_update == NULL)\n \t\treturn -ENOTSUP;\n \tret = eth_err(port_id, (*dev->dev_ops->rss_hash_update)(dev,\n@@ -4580,6 +4596,8 @@ rte_eth_dev_rss_hash_conf_get(uint16_t port_id,\n \t\treturn -EINVAL;\n \t}\n \n+\trss_conf->func = RTE_ETH_HASH_FUNCTION_DEFAULT;\n+\n \tif (*dev->dev_ops->rss_hash_conf_get == NULL)\n \t\treturn -ENOTSUP;\n \tret = eth_err(port_id, (*dev->dev_ops->rss_hash_conf_get)(dev,\ndiff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h\nindex 99fe9e238b..5abe2cb36d 100644\n--- a/lib/ethdev/rte_ethdev.h\n+++ b/lib/ethdev/rte_ethdev.h\n@@ -174,6 +174,7 @@ extern \"C\" {\n \n #include \"rte_ethdev_trace_fp.h\"\n #include \"rte_dev_info.h\"\n+#include \"rte_flow.h\"\n \n extern int rte_eth_dev_logtype;\n \n@@ -461,11 +462,15 @@ struct rte_vlan_filter_conf {\n * The *rss_hf* field of the *rss_conf* structure indicates the different\n * types of IPv4/IPv6 packets to which the RSS hashing must be applied.\n * Supplying an *rss_hf* equal to zero disables the RSS feature.\n+ *\n+ * The *func* field of the *rss_conf* structure indicates the different\n+ * types of hash algorithms applied by the RSS hashing.\n */\n struct rte_eth_rss_conf {\n \tuint8_t *rss_key; /**< If not NULL, 40-byte hash key. */\n \tuint8_t rss_key_len; /**< hash key length in bytes. */\n \tuint64_t rss_hf; /**< Hash functions to apply - see below. */\n+\tenum rte_eth_hash_function func;\t/**< Hash algorithm to apply. */\n };\n \n /*\n", "prefixes": [ "1/5" ] }