Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125129/?format=api
{ "id": 125129, "url": "http://patches.dpdk.org/api/patches/125129/?format=api", "web_url": "http://patches.dpdk.org/project/dts/patch/20230315015655.768885-2-ke1.xu@intel.com/", "project": { "id": 3, "url": "http://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20230315015655.768885-2-ke1.xu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20230315015655.768885-2-ke1.xu@intel.com", "date": "2023-03-15T01:56:54", "name": "[V2,1/2] framework/test_result: fix unsafe __set_test_case", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5615e134e9c99af9ddf66672dd10733d53eac09b", "submitter": { "id": 2810, "url": "http://patches.dpdk.org/api/people/2810/?format=api", "name": "Ke Xu", "email": "ke1.xu@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dts/patch/20230315015655.768885-2-ke1.xu@intel.com/mbox/", "series": [ { "id": 27392, "url": "http://patches.dpdk.org/api/series/27392/?format=api", "web_url": "http://patches.dpdk.org/project/dts/list/?series=27392", "date": "2023-03-15T01:56:53", "name": "fix result output overwriting when using multiple lines in execution configuration for one suite.", "version": 2, "mbox": "http://patches.dpdk.org/series/27392/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125129/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/125129/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DA1E841E96;\n\tWed, 15 Mar 2023 02:59:31 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D6765410FB;\n\tWed, 15 Mar 2023 02:59:31 +0100 (CET)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id 573A7400EF\n for <dts@dpdk.org>; Wed, 15 Mar 2023 02:59:30 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Mar 2023 18:59:29 -0700", "from dpdk-xuke-lab.sh.intel.com ([10.67.119.8])\n by orsmga007.jf.intel.com with ESMTP; 14 Mar 2023 18:59:28 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1678845570; x=1710381570;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=SZOCM6PF7yfaooLJF87YSYLx0xWJa/T9/1BrIb/vytA=;\n b=TDlret9YJGz1GmUygqOc3Dn7tJ7kyFyBNjzCxhPKN3/2wmdeJFyMJO3E\n cyK2Ksv5U5BXkJN95lFzoAfVmyhdzJB/35hpBnF7jUDhUjRQu5+Xjxu6K\n JGoJf+WN7H7WLwZYdJ3hM+QS5EQ53lLtmCTQGQQXoHOVO51GlT1Vc3E0R\n JrlnwccAQbglZPpvdfD0LFXuBt23CU8IDT6YKTJ7SZbvfYh5w0xxudjBT\n Wt6sb84BHEJFuC0jk1R/sAkqSSypbQeVlYi7/4f5rEZIWHd6IJu7BucXW\n 4kg191udTRanKVV36idn36HCdXJ43DHaQQPNaaNfGyE6/2d+fsd5TLp8r A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10649\"; a=\"317244190\"", "E=Sophos;i=\"5.98,261,1673942400\"; d=\"scan'208\";a=\"317244190\"", "E=McAfee;i=\"6500,9779,10649\"; a=\"672561441\"", "E=Sophos;i=\"5.98,261,1673942400\"; d=\"scan'208\";a=\"672561441\"" ], "X-ExtLoop1": "1", "From": "Ke Xu <ke1.xu@intel.com>", "To": "dts@dpdk.org", "Cc": "lijuan.tu@intel.com,\n\tke1.xu@intel.com", "Subject": "[DTS][PATCH V2 1/2] framework/test_result: fix unsafe __set_test_case", "Date": "Wed, 15 Mar 2023 09:56:54 +0800", "Message-Id": "<20230315015655.768885-2-ke1.xu@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230315015655.768885-1-ke1.xu@intel.com>", "References": "<20230315015655.768885-1-ke1.xu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "Without a pre-append check, __set_test_case method will append redundant\n elements when setting but locating the result at the first element. If\n this method is called several times, the outcome will de-organize in data\n structure.\n\nThere is a pre-append check in __set_test_suite and __set_test_suite. This\n implementation imitated the methods above.\n\nSigned-off-by: Ke Xu <ke1.xu@intel.com>\n---\n framework/test_result.py | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/framework/test_result.py b/framework/test_result.py\nindex b62ed120..081b7256 100644\n--- a/framework/test_result.py\n+++ b/framework/test_result.py\n@@ -232,8 +232,9 @@ class Result(object):\n \n def __set_test_case(self, test_case):\n cases = self.__current_cases()\n- cases.append(test_case)\n- cases.append([])\n+ if test_case not in cases:\n+ cases.append(test_case)\n+ cases.append([])\n self.__test_case = cases.index(test_case)\n \n def __get_test_case(self):\n", "prefixes": [ "V2", "1/2" ] }