Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125003/?format=api
{ "id": 125003, "url": "http://patches.dpdk.org/api/patches/125003/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230310093518.5198-15-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230310093518.5198-15-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230310093518.5198-15-liudongdong3@huawei.com", "date": "2023-03-10T09:35:16", "name": "[14/16] net/hns3: separate rte flow RSS config from hns3 rss conf", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e7023142b6eb66e22769629a0f7591269a5bcb01", "submitter": { "id": 2718, "url": "http://patches.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230310093518.5198-15-liudongdong3@huawei.com/mbox/", "series": [ { "id": 27329, "url": "http://patches.dpdk.org/api/series/27329/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27329", "date": "2023-03-10T09:35:02", "name": "net/hns3: some code refactor for hns3 RSS", "version": 1, "mbox": "http://patches.dpdk.org/series/27329/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/125003/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/125003/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3303141E3A;\n\tFri, 10 Mar 2023 10:37:57 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5FCE442D75;\n\tFri, 10 Mar 2023 10:36:47 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 149A342D5D;\n Fri, 10 Mar 2023 10:36:41 +0100 (CET)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.54])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4PY19471M1zKqCw;\n Fri, 10 Mar 2023 17:34:32 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.21; Fri, 10 Mar 2023 17:36:39 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>,\n <andrew.rybchenko@oktetlabs.ru>", "CC": "<stable@dpdk.org>, <yisen.zhuang@huawei.com>, <liudongdong3@huawei.com>,\n <lihuisong@huawei.com>", "Subject": "[PATCH 14/16] net/hns3: separate rte flow RSS config from hns3 rss\n conf", "Date": "Fri, 10 Mar 2023 17:35:16 +0800", "Message-ID": "<20230310093518.5198-15-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20230310093518.5198-1-liudongdong3@huawei.com>", "References": "<20230310093518.5198-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nSome RSS fields in struct hns3_rss_conf (e.g. conf, queue,\nvalid) are only used when create RSS flow rule, which is\nunnecessary for RSS configuration information from ethdev\nops. This patch removes these fields from hns3_rss_conf\nand add a new struct hns3_flow_rss_conf as rte flow\nRSS filter list node element.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_flow.c | 23 ++++++++++++-----------\n drivers/net/hns3/hns3_flow.h | 10 +++++++++-\n drivers/net/hns3/hns3_rss.h | 5 -----\n 3 files changed, 21 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c\nindex 527874df44..89374816aa 100644\n--- a/drivers/net/hns3/hns3_flow.c\n+++ b/drivers/net/hns3/hns3_flow.c\n@@ -1359,7 +1359,6 @@ hns3_parse_rss_filter(struct rte_eth_dev *dev,\n {\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tstruct hns3_hw *hw = &hns->hw;\n-\tstruct hns3_rss_conf *rss_conf = &hw->rss_info;\n \tconst struct rte_flow_action_rss *rss;\n \tconst struct rte_flow_action *act;\n \tuint32_t act_index = 0;\n@@ -1374,7 +1373,7 @@ hns3_parse_rss_filter(struct rte_eth_dev *dev,\n \t\t\t\t\t act, \"no valid queues\");\n \t}\n \n-\tif (rss->queue_num > RTE_DIM(rss_conf->queue))\n+\tif (rss->queue_num > HNS3_RSS_QUEUES_BUFFER_NUM)\n \t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION_CONF, act,\n \t\t\t\t\t \"queue number configured exceeds \"\n@@ -1439,7 +1438,7 @@ hns3_disable_rss(struct hns3_hw *hw)\n }\n \n static int\n-hns3_parse_rss_algorithm(struct hns3_hw *hw, struct hns3_rss_conf *rss_conf,\n+hns3_parse_rss_algorithm(struct hns3_hw *hw, struct hns3_flow_rss_conf *rss_conf,\n \t\t\t uint8_t *hash_algo)\n {\n \tconst uint8_t hash_func_map[] = {\n@@ -1466,8 +1465,8 @@ hns3_parse_rss_algorithm(struct hns3_hw *hw, struct hns3_rss_conf *rss_conf,\n \t\t * rte_flow_hash_algo) when this rule is delivered.\n \t\t */\n \t\tif (__atomic_load_n(&hw->reset.resetting, __ATOMIC_RELAXED) &&\n-\t\t *hash_algo != rss_conf->rte_flow_hash_algo)\n-\t\t\t*hash_algo = rss_conf->rte_flow_hash_algo;\n+\t\t *hash_algo != rss_conf->hash_algo)\n+\t\t\t*hash_algo = rss_conf->hash_algo;\n \n \t\treturn 0;\n \t}\n@@ -1478,7 +1477,7 @@ hns3_parse_rss_algorithm(struct hns3_hw *hw, struct hns3_rss_conf *rss_conf,\n }\n \n static int\n-hns3_hw_rss_hash_set(struct hns3_hw *hw, struct hns3_rss_conf *conf)\n+hns3_hw_rss_hash_set(struct hns3_hw *hw, struct hns3_flow_rss_conf *conf)\n {\n \tstruct rte_flow_action_rss *rss_config = &conf->conf;\n \tuint8_t rss_key[HNS3_RSS_KEY_SIZE_MAX] = {0};\n@@ -1503,7 +1502,7 @@ hns3_hw_rss_hash_set(struct hns3_hw *hw, struct hns3_rss_conf *conf)\n \t\t\t\t hw->rss_key_size);\n \tif (ret)\n \t\treturn ret;\n-\tconf->rte_flow_hash_algo = hash_algo;\n+\tconf->hash_algo = hash_algo;\n \n \t/* Filter the unsupported flow types */\n \tflow_types = rss_config->types ?\n@@ -1545,7 +1544,8 @@ hns3_update_indir_table(struct hns3_hw *hw,\n }\n \n static int\n-hns3_reset_rss_filter(struct hns3_hw *hw, const struct hns3_rss_conf *conf)\n+hns3_reset_rss_filter(struct hns3_hw *hw,\n+\t\t const struct hns3_flow_rss_conf *conf)\n {\n \tint ret;\n \n@@ -1560,7 +1560,7 @@ hns3_reset_rss_filter(struct hns3_hw *hw, const struct hns3_rss_conf *conf)\n }\n \n static int\n-hns3_config_rss_filter(struct hns3_hw *hw, struct hns3_rss_conf *conf)\n+hns3_config_rss_filter(struct hns3_hw *hw, struct hns3_flow_rss_conf *conf)\n {\n \tstruct rte_flow_action_rss *rss_act;\n \tuint16_t num;\n@@ -1669,7 +1669,8 @@ hns3_rss_action_is_dup(struct hns3_hw *hw,\n }\n \n static int\n-hns3_flow_parse_rss(struct rte_eth_dev *dev, struct hns3_rss_conf *conf)\n+hns3_flow_parse_rss(struct rte_eth_dev *dev,\n+\t\t struct hns3_flow_rss_conf *conf)\n {\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tstruct hns3_hw *hw = &hns->hw;\n@@ -1739,8 +1740,8 @@ hns3_flow_create_rss_rule(struct rte_eth_dev *dev,\n \tstruct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tconst struct rte_flow_action_rss *rss_act;\n \tstruct hns3_rss_conf_ele *rss_filter_ptr;\n+\tstruct hns3_flow_rss_conf *new_conf;\n \tstruct hns3_rss_conf_ele *filter_ptr;\n-\tstruct hns3_rss_conf *new_conf;\n \tint ret;\n \n \trss_filter_ptr = rte_zmalloc(\"hns3 rss filter\",\ndiff --git a/drivers/net/hns3/hns3_flow.h b/drivers/net/hns3/hns3_flow.h\nindex e4b2fdf2e6..90126f2b6e 100644\n--- a/drivers/net/hns3/hns3_flow.h\n+++ b/drivers/net/hns3/hns3_flow.h\n@@ -24,10 +24,18 @@ struct rte_flow {\n \tuint32_t counter_id;\n };\n \n+struct hns3_flow_rss_conf {\n+\tstruct rte_flow_action_rss conf;\n+\tuint8_t hash_algo;\n+\tuint8_t key[HNS3_RSS_KEY_SIZE_MAX]; /* Hash key */\n+\tuint16_t queue[HNS3_RSS_QUEUES_BUFFER_NUM]; /* Queues indices to use */\n+\tbool valid; /* check if RSS rule is valid */\n+};\n+\n /* rss filter list structure */\n struct hns3_rss_conf_ele {\n \tTAILQ_ENTRY(hns3_rss_conf_ele) entries;\n-\tstruct hns3_rss_conf filter_info;\n+\tstruct hns3_flow_rss_conf filter_info;\n };\n \n /* hns3_flow memory list structure */\ndiff --git a/drivers/net/hns3/hns3_rss.h b/drivers/net/hns3/hns3_rss.h\nindex cc0bb8431d..d19730c69c 100644\n--- a/drivers/net/hns3/hns3_rss.h\n+++ b/drivers/net/hns3/hns3_rss.h\n@@ -40,15 +40,10 @@\n /* Same as the Max queue num under TC */\n #define HNS3_RSS_QUEUES_BUFFER_NUM\t512\n struct hns3_rss_conf {\n-\t/* RSS parameters :algorithm, flow_types, key, queue */\n-\tstruct rte_flow_action_rss conf;\n \tuint64_t rss_hf;\n \tuint8_t hash_algo; /* hash function type defined by hardware */\n-\tuint8_t rte_flow_hash_algo;\n \tuint8_t key[HNS3_RSS_KEY_SIZE_MAX]; /* Hash key */\n \tuint16_t rss_indirection_tbl[HNS3_RSS_IND_TBL_SIZE_MAX];\n-\tuint16_t queue[HNS3_RSS_QUEUES_BUFFER_NUM]; /* Queues indices to use */\n-\tbool valid; /* check if RSS rule is valid */\n \t/*\n \t * For IPv6 SCTP packets type, check whether the NIC hardware support\n \t * RSS hash using the src/dst port as the input tuple. For Kunpeng920\n", "prefixes": [ "14/16" ] }