Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124998/?format=api
{ "id": 124998, "url": "http://patches.dpdk.org/api/patches/124998/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230310093518.5198-10-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230310093518.5198-10-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230310093518.5198-10-liudongdong3@huawei.com", "date": "2023-03-10T09:35:11", "name": "[09/16] net/hns3: separate the setting of RSS types", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4b54210c7a221e2d7a80c523f8d78b50952f57fc", "submitter": { "id": 2718, "url": "http://patches.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230310093518.5198-10-liudongdong3@huawei.com/mbox/", "series": [ { "id": 27329, "url": "http://patches.dpdk.org/api/series/27329/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27329", "date": "2023-03-10T09:35:02", "name": "net/hns3: some code refactor for hns3 RSS", "version": 1, "mbox": "http://patches.dpdk.org/series/27329/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/124998/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/124998/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2D0C541E3A;\n\tFri, 10 Mar 2023 10:37:29 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 042B842D59;\n\tFri, 10 Mar 2023 10:36:41 +0100 (CET)", "from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])\n by mails.dpdk.org (Postfix) with ESMTP id AC38D42BFE;\n Fri, 10 Mar 2023 10:36:34 +0100 (CET)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.54])\n by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4PY18658M3z16PL3;\n Fri, 10 Mar 2023 17:33:42 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.21; Fri, 10 Mar 2023 17:36:32 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>,\n <andrew.rybchenko@oktetlabs.ru>", "CC": "<stable@dpdk.org>, <yisen.zhuang@huawei.com>, <liudongdong3@huawei.com>,\n <lihuisong@huawei.com>", "Subject": "[PATCH 09/16] net/hns3: separate the setting of RSS types", "Date": "Fri, 10 Mar 2023 17:35:11 +0800", "Message-ID": "<20230310093518.5198-10-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20230310093518.5198-1-liudongdong3@huawei.com>", "References": "<20230310093518.5198-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nThe settings of RSS types comes from the ethdev ops (like, dev_configure\nand rss_hash_update) and rte_flow API. For the ethdev ops, driver has to\nsave it so as to it can be restored when reset is triggered.\nWhile rte_flow API no need to maintain this field, it can be restored by\nthe saved rule.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_flow.c | 3 ++-\n drivers/net/hns3/hns3_rss.c | 22 ++++++++++++++--------\n drivers/net/hns3/hns3_rss.h | 1 +\n 3 files changed, 17 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c\nindex d5db09a263..21e00e515e 100644\n--- a/drivers/net/hns3/hns3_flow.c\n+++ b/drivers/net/hns3/hns3_flow.c\n@@ -1433,6 +1433,7 @@ hns3_disable_rss(struct hns3_hw *hw)\n \tret = hns3_set_rss_tuple_by_rss_hf(hw, 0);\n \tif (ret)\n \t\treturn ret;\n+\thw->rss_info.rss_hf = 0;\n \n \treturn 0;\n }\n@@ -1580,7 +1581,7 @@ hns3_config_rss_filter(struct hns3_hw *hw,\n \t/* Filter the unsupported flow types */\n \tflow_types = conf->conf.types ?\n \t\t rss_flow_conf.types & HNS3_ETH_RSS_SUPPORT :\n-\t\t hw->rss_info.conf.types;\n+\t\t hw->rss_info.rss_hf;\n \tif (flow_types != rss_flow_conf.types)\n \t\thns3_warn(hw, \"modified RSS types based on hardware support,\"\n \t\t\t \" requested:0x%\" PRIx64 \" configured:0x%\" PRIx64,\ndiff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c\nindex 037914ef04..2ef267aac6 100644\n--- a/drivers/net/hns3/hns3_rss.c\n+++ b/drivers/net/hns3/hns3_rss.c\n@@ -627,9 +627,6 @@ hns3_set_rss_tuple_by_rss_hf(struct hns3_hw *hw, uint64_t rss_hf)\n \t\treturn ret;\n \t}\n \n-\t/* Update supported flow types when set tuple success */\n-\thw->rss_info.conf.types = rss_hf;\n-\n \treturn 0;\n }\n \n@@ -647,7 +644,7 @@ hns3_dev_rss_hash_update(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_rss_conf *rss_conf)\n {\n \tstruct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tuint64_t rss_hf_bk = hw->rss_info.conf.types;\n+\tuint64_t rss_hf_bk = hw->rss_info.rss_hf;\n \tuint8_t key_len = rss_conf->rss_key_len;\n \tuint64_t rss_hf = rss_conf->rss_hf;\n \tuint8_t *key = rss_conf->rss_key;\n@@ -672,6 +669,7 @@ hns3_dev_rss_hash_update(struct rte_eth_dev *dev,\n \t\t/* Update the shadow RSS key with user specified */\n \t\tmemcpy(hw->rss_info.key, key, hw->rss_key_size);\n \t}\n+\thw->rss_info.rss_hf = rss_hf;\n \trte_spinlock_unlock(&hw->lock);\n \n \treturn 0;\n@@ -1029,6 +1027,7 @@ hns3_rss_set_default_args(struct hns3_hw *hw)\n \t/* Default hash algorithm */\n \trss_cfg->hash_algo = HNS3_RSS_HASH_ALGO_TOEPLITZ;\n \n+\thw->rss_info.rss_hf = 0;\n \tmemcpy(rss_cfg->key, hns3_hash_key,\n \t\tRTE_MIN(sizeof(hns3_hash_key), hw->rss_key_size));\n \n@@ -1066,15 +1065,22 @@ hns3_config_rss(struct hns3_adapter *hns)\n \t\treturn ret;\n \n \t/*\n-\t * When muli-queue RSS mode flag is not set or unsupported tuples are\n+\t * When multi-queue RSS mode flag is not set or unsupported tuples are\n \t * set, disable all tuples.\n \t */\n-\trss_hf = hw->rss_info.conf.types;\n+\trss_hf = hw->rss_info.rss_hf;\n \tif (!((uint32_t)mq_mode & RTE_ETH_MQ_RX_RSS_FLAG) ||\n \t !(rss_hf & HNS3_ETH_RSS_SUPPORT))\n \t\trss_hf = 0;\n \n-\treturn hns3_set_rss_tuple_by_rss_hf(hw, rss_hf);\n+\tret = hns3_set_rss_tuple_by_rss_hf(hw, rss_hf);\n+\tif (ret != 0) {\n+\t\thns3_err(hw, \"set RSS tuples failed, ret = %d.\", ret);\n+\t\treturn ret;\n+\t}\n+\thw->rss_info.rss_hf = rss_hf;\n+\n+\treturn 0;\n }\n \n /*\n@@ -1092,5 +1098,5 @@ hns3_rss_uninit(struct hns3_adapter *hns)\n \t\treturn;\n \n \t/* Disable RSS */\n-\thw->rss_info.conf.types = 0;\n+\thw->rss_info.rss_hf = 0;\n }\ndiff --git a/drivers/net/hns3/hns3_rss.h b/drivers/net/hns3/hns3_rss.h\nindex 6e679b709b..21b90789d0 100644\n--- a/drivers/net/hns3/hns3_rss.h\n+++ b/drivers/net/hns3/hns3_rss.h\n@@ -41,6 +41,7 @@\n struct hns3_rss_conf {\n \t/* RSS parameters :algorithm, flow_types, key, queue */\n \tstruct rte_flow_action_rss conf;\n+\tuint64_t rss_hf;\n \tuint8_t hash_algo; /* hash function type defined by hardware */\n \tuint8_t rte_flow_hash_algo;\n \tuint8_t key[HNS3_RSS_KEY_SIZE_MAX]; /* Hash key */\n", "prefixes": [ "09/16" ] }