Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124996/?format=api
{ "id": 124996, "url": "http://patches.dpdk.org/api/patches/124996/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230310093518.5198-8-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230310093518.5198-8-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230310093518.5198-8-liudongdong3@huawei.com", "date": "2023-03-10T09:35:09", "name": "[07/16] net/hns3: separate the setting of hash key", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8b7ab947bfea3a6c2f4b4802b3e3c82832186736", "submitter": { "id": 2718, "url": "http://patches.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230310093518.5198-8-liudongdong3@huawei.com/mbox/", "series": [ { "id": 27329, "url": "http://patches.dpdk.org/api/series/27329/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27329", "date": "2023-03-10T09:35:02", "name": "net/hns3: some code refactor for hns3 RSS", "version": 1, "mbox": "http://patches.dpdk.org/series/27329/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/124996/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/124996/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0BEDC41E3A;\n\tFri, 10 Mar 2023 10:37:15 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1E78C42D3E;\n\tFri, 10 Mar 2023 10:36:38 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id D886E42D0D;\n Fri, 10 Mar 2023 10:36:33 +0100 (CET)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.55])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4PY17m6q34zSknC;\n Fri, 10 Mar 2023 17:33:24 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.21; Fri, 10 Mar 2023 17:36:32 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>,\n <andrew.rybchenko@oktetlabs.ru>", "CC": "<stable@dpdk.org>, <yisen.zhuang@huawei.com>, <liudongdong3@huawei.com>,\n <lihuisong@huawei.com>", "Subject": "[PATCH 07/16] net/hns3: separate the setting of hash key", "Date": "Fri, 10 Mar 2023 17:35:09 +0800", "Message-ID": "<20230310093518.5198-8-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20230310093518.5198-1-liudongdong3@huawei.com>", "References": "<20230310093518.5198-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nThe settings of hash key comes from the ethdev ops (like, dev_configure\nand rss_hash_update) and rte_flow API. For the ethdev ops, driver has\nto save it to rss_info::key in hns3_hw structure so as to it can be\nrestored when reset is triggered. While rte_flow API no need to use\nthis field to save, they has a global flow_rss_list to maintain all\nrules which save hash key. And hash key can be restored by this rule\ninformation during the reset phase.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_rss.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c\nindex 88ba0757b5..be717b7641 100644\n--- a/drivers/net/hns3/hns3_rss.c\n+++ b/drivers/net/hns3/hns3_rss.c\n@@ -376,8 +376,7 @@ hns3_rss_set_algo_key(struct hns3_hw *hw, uint8_t hash_algo,\n \t\t\treturn ret;\n \t\t}\n \t}\n-\t/* Update the shadow RSS key with user specified */\n-\tmemcpy(hw->rss_info.key, key, hw->rss_key_size);\n+\n \treturn 0;\n }\n \n@@ -671,6 +670,8 @@ hns3_dev_rss_hash_update(struct rte_eth_dev *dev,\n \t\t\t\t\t key, hw->rss_key_size);\n \t\tif (ret)\n \t\t\tgoto set_algo_key_fail;\n+\t\t/* Update the shadow RSS key with user specified */\n+\t\tmemcpy(hw->rss_info.key, key, hw->rss_key_size);\n \t}\n \trte_spinlock_unlock(&hw->lock);\n \n", "prefixes": [ "07/16" ] }