Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124991/?format=api
{ "id": 124991, "url": "http://patches.dpdk.org/api/patches/124991/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230310093518.5198-4-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230310093518.5198-4-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230310093518.5198-4-liudongdong3@huawei.com", "date": "2023-03-10T09:35:05", "name": "[03/16] net/hns3: use hardware config to report hash key", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e893a7c99bcc23593a22ce432c35dcaa402c462a", "submitter": { "id": 2718, "url": "http://patches.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230310093518.5198-4-liudongdong3@huawei.com/mbox/", "series": [ { "id": 27329, "url": "http://patches.dpdk.org/api/series/27329/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27329", "date": "2023-03-10T09:35:02", "name": "net/hns3: some code refactor for hns3 RSS", "version": 1, "mbox": "http://patches.dpdk.org/series/27329/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/124991/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/124991/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7A92F41E3A;\n\tFri, 10 Mar 2023 10:36:39 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8EFE542B71;\n\tFri, 10 Mar 2023 10:36:31 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 71CDA40685;\n Fri, 10 Mar 2023 10:36:28 +0100 (CET)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.55])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4PY18q2RvpzKqH0;\n Fri, 10 Mar 2023 17:34:19 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.21; Fri, 10 Mar 2023 17:36:25 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>,\n <andrew.rybchenko@oktetlabs.ru>", "CC": "<stable@dpdk.org>, <yisen.zhuang@huawei.com>, <liudongdong3@huawei.com>,\n <lihuisong@huawei.com>", "Subject": "[PATCH 03/16] net/hns3: use hardware config to report hash key", "Date": "Fri, 10 Mar 2023 17:35:05 +0800", "Message-ID": "<20230310093518.5198-4-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20230310093518.5198-1-liudongdong3@huawei.com>", "References": "<20230310093518.5198-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems702-chm.china.huawei.com (10.3.19.179) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nCurrently, hns3_dev_rss_hash_conf_get() interface reports RSS key from\nthe key maintained by driver. It's better to report the key from hardware,\nwhich is more realistic.\n\nFixes: c37ca66f2b27 (\"net/hns3: support RSS\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_rss.c | 53 ++++++++++++++++++++++++++++++++++++-\n drivers/net/hns3/hns3_rss.h | 3 ++-\n 2 files changed, 54 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c\nindex f6d677ade8..a046cc31d1 100644\n--- a/drivers/net/hns3/hns3_rss.c\n+++ b/drivers/net/hns3/hns3_rss.c\n@@ -321,6 +321,48 @@ hns3_rss_set_algo_key(struct hns3_hw *hw, uint8_t hash_algo,\n \treturn 0;\n }\n \n+int\n+hns3_rss_get_algo_key(struct hns3_hw *hw, uint8_t *hash_algo,\n+\t\t uint8_t *key, uint8_t key_len)\n+{\n+\tstruct hns3_rss_generic_config_cmd *req;\n+\tstruct hns3_cmd_desc desc;\n+\tuint16_t cur_key_size;\n+\tuint16_t max_bd_num;\n+\tuint8_t *cur_key;\n+\tuint16_t idx;\n+\tint ret;\n+\n+\treq = (struct hns3_rss_generic_config_cmd *)desc.data;\n+\tmax_bd_num = DIV_ROUND_UP(key_len, HNS3_RSS_HASH_KEY_NUM);\n+\tfor (idx = 0; idx < max_bd_num; idx++) {\n+\t\thns3_cmd_setup_basic_desc(&desc, HNS3_OPC_RSS_GENERIC_CONFIG,\n+\t\t\t\t\t true);\n+\n+\t\treq->hash_config |= (idx << HNS3_RSS_HASH_KEY_OFFSET_B);\n+\t\tret = hns3_cmd_send(hw, &desc, 1);\n+\t\tif (ret) {\n+\t\t\thns3_err(hw, \"fail to obtain RSS algo and key from firmware, ret = %d\",\n+\t\t\t\t ret);\n+\t\t\treturn ret;\n+\t\t}\n+\n+\t\tif (idx == 0)\n+\t\t\t*hash_algo = req->hash_config & HNS3_RSS_HASH_ALGO_MASK;\n+\n+\t\tif (idx == max_bd_num - 1 &&\n+\t\t (key_len % HNS3_RSS_HASH_KEY_NUM) != 0)\n+\t\t\tcur_key_size = key_len % HNS3_RSS_HASH_KEY_NUM;\n+\t\telse\n+\t\t\tcur_key_size = HNS3_RSS_HASH_KEY_NUM;\n+\n+\t\tcur_key = key + idx * HNS3_RSS_HASH_KEY_NUM;\n+\t\tmemcpy(cur_key, req->hash_key, cur_key_size);\n+\t}\n+\n+\treturn 0;\n+}\n+\n /*\n * rss_indirection_table command function, opcode:0x0D07.\n * Used to configure the indirection table of rss.\n@@ -549,13 +591,22 @@ hns3_dev_rss_hash_conf_get(struct rte_eth_dev *dev,\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tstruct hns3_hw *hw = &hns->hw;\n \tstruct hns3_rss_conf *rss_cfg = &hw->rss_info;\n+\tuint8_t hash_algo;\n+\tint ret;\n \n \trte_spinlock_lock(&hw->lock);\n \trss_conf->rss_hf = rss_cfg->conf.types;\n \n \t/* Get the RSS Key required by the user */\n \tif (rss_conf->rss_key && rss_conf->rss_key_len >= hw->rss_key_size) {\n-\t\tmemcpy(rss_conf->rss_key, rss_cfg->key, hw->rss_key_size);\n+\t\tret = hns3_rss_get_algo_key(hw, &hash_algo, rss_conf->rss_key,\n+\t\t\t\t\t hw->rss_key_size);\n+\t\tif (ret != 0) {\n+\t\t\trte_spinlock_unlock(&hw->lock);\n+\t\t\thns3_err(hw, \"obtain hash algo and key failed, ret = %d\",\n+\t\t\t\t ret);\n+\t\t\treturn ret;\n+\t\t}\n \t\trss_conf->rss_key_len = hw->rss_key_size;\n \t}\n \trte_spinlock_unlock(&hw->lock);\ndiff --git a/drivers/net/hns3/hns3_rss.h b/drivers/net/hns3/hns3_rss.h\nindex d6f81996f4..be0141f602 100644\n--- a/drivers/net/hns3/hns3_rss.h\n+++ b/drivers/net/hns3/hns3_rss.h\n@@ -112,6 +112,7 @@ void hns3_rss_uninit(struct hns3_adapter *hns);\n int hns3_set_rss_tuple_by_rss_hf(struct hns3_hw *hw, uint64_t rss_hf);\n int hns3_rss_set_algo_key(struct hns3_hw *hw, uint8_t hash_algo,\n \t\t\t const uint8_t *key, uint8_t key_len);\n-\n+int hns3_rss_get_algo_key(struct hns3_hw *hw, uint8_t *hash_algo,\n+\t\t\t uint8_t *key, uint8_t key_len);\n \n #endif /* HNS3_RSS_H */\n", "prefixes": [ "03/16" ] }