Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124827/?format=api
{ "id": 124827, "url": "http://patches.dpdk.org/api/patches/124827/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230306192810.106154-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230306192810.106154-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230306192810.106154-2-stephen@networkplumber.org", "date": "2023-03-06T19:28:09", "name": "[v3,1/2] eal: unify logging code for FreeBsd and Linux", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "53f235510abe5089b889af99d007869e8cc3cc26", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230306192810.106154-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 27266, "url": "http://patches.dpdk.org/api/series/27266/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27266", "date": "2023-03-06T19:28:08", "name": "Add option to timestamp console log", "version": 3, "mbox": "http://patches.dpdk.org/series/27266/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/124827/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/124827/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1586B41DF6;\n\tMon, 6 Mar 2023 20:28:21 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8435C410F9;\n\tMon, 6 Mar 2023 20:28:16 +0100 (CET)", "from mail-pj1-f51.google.com (mail-pj1-f51.google.com\n [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 5298D40A8A\n for <dev@dpdk.org>; Mon, 6 Mar 2023 20:28:14 +0100 (CET)", "by mail-pj1-f51.google.com with SMTP id\n h17-20020a17090aea9100b0023739b10792so9740333pjz.1\n for <dev@dpdk.org>; Mon, 06 Mar 2023 11:28:14 -0800 (PST)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n g22-20020a1709029f9600b001991d6c6c64sm5653476plq.185.2023.03.06.11.28.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 06 Mar 2023 11:28:12 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1678130893;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=dKGr7PUWrmPmcCmVQmXOUcuNvrHWrvXJqvOeVVHo9B4=;\n b=hvxY0Pdy5BYgJGe2Zt0W6PgkY7C68WcuqOTKmQ+u1kFrh4NvnERgtxYFU3RX8qK8ce\n AfJ9gTOjgDo4bFTRGBnpsHmKjM0Vad/3ljMuMdA/H5AHiz0+9iyKsgrG7ZyJXnEFK/sH\n TKHOCTsyuLWq/v0Zx/JY2o/8kQ+A2G/fCKyua9NgETTN6r+DNsGnLbdIS6Wvh4tpbe9S\n YX9N3yX4B9HBRJn/mP8iL5HXmyB0I5dEUIgPMweFDcghwZgld77e0Rdq2g0CBVbRPQXj\n E4Oj2a4hFeGpr0zl2DjtR3qHIg3uLwHBn/xzG2EbeVTEx2pVC3NkQ1Q8QfbsNyUxDXfz\n ErPQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112; t=1678130893;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=dKGr7PUWrmPmcCmVQmXOUcuNvrHWrvXJqvOeVVHo9B4=;\n b=a6PkEgHm0qtu7JRVRH9qFV5w3xf+SOrY/pTOjaXyIrkpzaIgEU+eSpofv28vj42iUr\n Gdr3E7Cl57p9E+S9TiyY4eiOkeP3WQyXJjyxUo9jFhuxqqdxcvSd7bRPf7jE6bXmlyQh\n dIWK48XwIOxgwfP7peH/NTiY8hNMXWFp05WtT2+F4oyhprl/XsjeIg5ONUEjDiTPhwCm\n t2Qbjj+poRG6P0KcUqR9DRApy1FLjoJIAdajD5v2IidmPPj0PvfQ7oDcy3tTOoATPrb0\n gmmfgqnU0q29NF+64B467K6p6iQTA+qjqTrA/1CV5XxEyZ59qYwEmXDqQB5lzBaP68Mq\n 2MVQ==", "X-Gm-Message-State": "AO0yUKUPaO5//Go0rMBgBoD3EDlpLxn3M5jf6RAMVwfgdrLSJOlXhouY\n G/ch3MokwnlK4IBTKIqWxfLz1MnETD96n5kLQnpPmQ==", "X-Google-Smtp-Source": "\n AK7set/9Z5eWxTSwsMNXJ5bsEmsgitckMpANW+6WrhdiFeVnaTcQCLjhU+kLZ8FNtArvCXAXHjNWvg==", "X-Received": "by 2002:a17:902:a416:b0:19e:bfec:7928 with SMTP id\n p22-20020a170902a41600b0019ebfec7928mr4148414plq.24.1678130893235;\n Mon, 06 Mar 2023 11:28:13 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v3 1/2] eal: unify logging code for FreeBsd and Linux", "Date": "Mon, 6 Mar 2023 11:28:09 -0800", "Message-Id": "<20230306192810.106154-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230306192810.106154-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20230306192810.106154-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "FreeBSD logging code was not using syslog and did not have\nthe same options as Linux. Move the log writing code to common\ntree.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/freebsd/eal.c | 7 +++++++\n lib/eal/linux/meson.build | 1 -\n lib/eal/{linux => unix}/eal_log.c | 0\n lib/eal/unix/meson.build | 1 +\n 4 files changed, 8 insertions(+), 1 deletion(-)\n rename lib/eal/{linux => unix}/eal_log.c (100%)", "diff": "diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex 7db4239c5187..3a53f9e13887 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -51,6 +51,7 @@\n #include \"eal_hugepages.h\"\n #include \"eal_options.h\"\n #include \"eal_memcfg.h\"\n+#include \"eal_log.h\"\n #include \"eal_trace.h\"\n \n #define MEMSIZE_IF_NO_HUGE_PAGE (64ULL * 1024ULL * 1024ULL)\n@@ -744,6 +745,12 @@ rte_eal_init(int argc, char **argv)\n #endif\n \t}\n \n+\tif (eal_log_init(getprogname(), internal_conf->syslog_facility) < 0) {\n+\t\trte_eal_init_alert(\"Cannot init logging.\");\n+\t\trte_errno = ENOMEM;\n+\t\treturn -1;\n+\t}\n+\n \t/* in secondary processes, memory init may allocate additional fbarrays\n \t * not present in primary processes, so to avoid any potential issues,\n \t * initialize memzones first.\ndiff --git a/lib/eal/linux/meson.build b/lib/eal/linux/meson.build\nindex 3cccfa36c0a4..1b913acc0681 100644\n--- a/lib/eal/linux/meson.build\n+++ b/lib/eal/linux/meson.build\n@@ -11,7 +11,6 @@ sources += files(\n 'eal_hugepage_info.c',\n 'eal_interrupts.c',\n 'eal_lcore.c',\n- 'eal_log.c',\n 'eal_memalloc.c',\n 'eal_memory.c',\n 'eal_thread.c',\ndiff --git a/lib/eal/linux/eal_log.c b/lib/eal/unix/eal_log.c\nsimilarity index 100%\nrename from lib/eal/linux/eal_log.c\nrename to lib/eal/unix/eal_log.c\ndiff --git a/lib/eal/unix/meson.build b/lib/eal/unix/meson.build\nindex cc7d67dd321d..37d07594df29 100644\n--- a/lib/eal/unix/meson.build\n+++ b/lib/eal/unix/meson.build\n@@ -6,6 +6,7 @@ sources += files(\n 'eal_file.c',\n 'eal_filesystem.c',\n 'eal_firmware.c',\n+ 'eal_log.c',\n 'eal_unix_memory.c',\n 'eal_unix_thread.c',\n 'eal_unix_timer.c',\n", "prefixes": [ "v3", "1/2" ] }