Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 124743,
    "url": "http://patches.dpdk.org/api/patches/124743/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230302202211.170017-7-hernan.vargas@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230302202211.170017-7-hernan.vargas@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230302202211.170017-7-hernan.vargas@intel.com",
    "date": "2023-03-02T20:22:00",
    "name": "[v3,06/17] test/bbdev: enable early termination for validation",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "561de3ca93982fc75f17fcaffff63880809c9f1f",
    "submitter": {
        "id": 2659,
        "url": "http://patches.dpdk.org/api/people/2659/?format=api",
        "name": "Hernan Vargas",
        "email": "hernan.vargas@intel.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230302202211.170017-7-hernan.vargas@intel.com/mbox/",
    "series": [
        {
            "id": 27233,
            "url": "http://patches.dpdk.org/api/series/27233/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27233",
            "date": "2023-03-02T20:21:54",
            "name": "test/bbdev: changes for 23.03",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/27233/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/124743/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/124743/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 713BE41DB8;\n\tThu,  2 Mar 2023 21:22:44 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CED7C42D37;\n\tThu,  2 Mar 2023 21:22:05 +0100 (CET)",
            "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id AD02742B8B\n for <dev@dpdk.org>; Thu,  2 Mar 2023 21:22:00 +0100 (CET)",
            "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Mar 2023 12:21:59 -0800",
            "from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103])\n by orsmga008.jf.intel.com with ESMTP; 02 Mar 2023 12:21:59 -0800"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1677788520; x=1709324520;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=2hwIDTaDFpJFllJ2kG1dO8q530Mgcw/990sSV7dl/O4=;\n b=a/VmKVQ7k3GDCdpu8yX+DBI8gwrWAP0SzZo+80//UsO6dZfVbiQHKwt6\n WyUiESFAymsh3bCmyv8blbJIn/DMOAD8hWf4SICyceP19gHuMIaT97Q5u\n scfChdWnWQLyboA+ufa3vfI8QH1P4zK/y0oBudwSrW1/QcR/fZH8oILNW\n NNb3JZ4glVeuHvGNohyTcAdpmHQQjzsiRmugSpTPTiO6tYH2e93qRfVom\n Rdnrgd4Zt3MX7IV6U20TeOrnaIndNvBNTWU1I9MtU8KVb81DJBufClZ03\n uhhg5QIw47X0z79POtvdPdYPb5WAv5U7ZZXdiiL+pYe6AbyfecsX0g3Mm A==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6500,9779,10637\"; a=\"334871177\"",
            "E=Sophos;i=\"5.98,228,1673942400\"; d=\"scan'208\";a=\"334871177\"",
            "E=McAfee;i=\"6500,9779,10637\"; a=\"705398109\"",
            "E=Sophos;i=\"5.98,228,1673942400\"; d=\"scan'208\";a=\"705398109\""
        ],
        "X-ExtLoop1": "1",
        "From": "Hernan Vargas <hernan.vargas@intel.com>",
        "To": "dev@dpdk.org, gakhil@marvell.com, trix@redhat.com,\n maxime.coquelin@redhat.com",
        "Cc": "nicolas.chautru@intel.com, qi.z.zhang@intel.com,\n Hernan Vargas <hernan.vargas@intel.com>",
        "Subject": "[PATCH v3 06/17] test/bbdev: enable early termination for validation",
        "Date": "Thu,  2 Mar 2023 12:22:00 -0800",
        "Message-Id": "<20230302202211.170017-7-hernan.vargas@intel.com>",
        "X-Mailer": "git-send-email 2.37.1",
        "In-Reply-To": "<20230302202211.170017-1-hernan.vargas@intel.com>",
        "References": "<20230302202211.170017-1-hernan.vargas@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Enhancement to enable early termination for validation tests if the\ndevice supports it.\n\nSigned-off-by: Hernan Vargas <hernan.vargas@intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n app/test-bbdev/test_bbdev_perf.c | 30 +++++++++++++++++++-----------\n 1 file changed, 19 insertions(+), 11 deletions(-)",
    "diff": "diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c\nindex 4de3d937a53d..396473961ad1 100644\n--- a/app/test-bbdev/test_bbdev_perf.c\n+++ b/app/test-bbdev/test_bbdev_perf.c\n@@ -3773,11 +3773,11 @@ throughput_pmd_lcore_ldpc_dec(void *arg)\n \tTEST_ASSERT_SUCCESS(ret, \"Allocation failed for %d ops\", num_ops);\n \n \t/* For throughput tests we need to disable early termination */\n-\tif (check_bit(ref_op->ldpc_dec.op_flags,\n-\t\t\tRTE_BBDEV_LDPC_ITERATION_STOP_ENABLE))\n-\t\tref_op->ldpc_dec.op_flags -=\n-\t\t\t\tRTE_BBDEV_LDPC_ITERATION_STOP_ENABLE;\n+\tif (check_bit(ref_op->ldpc_dec.op_flags, RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE))\n+\t\tref_op->ldpc_dec.op_flags -= RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE;\n+\n \tref_op->ldpc_dec.iter_max = get_iter_max();\n+\t/* Since ET is disabled, the expected iter_count is iter_max */\n \tref_op->ldpc_dec.iter_count = ref_op->ldpc_dec.iter_max;\n \n \tif (test_vector.op_type != RTE_BBDEV_OP_NONE)\n@@ -4463,7 +4463,7 @@ latency_test_dec(struct rte_mempool *mempool,\n \t\tstruct test_buffers *bufs, struct rte_bbdev_dec_op *ref_op,\n \t\tint vector_mask, uint16_t dev_id, uint16_t queue_id,\n \t\tconst uint16_t num_to_process, uint16_t burst_sz,\n-\t\tuint64_t *total_time, uint64_t *min_time, uint64_t *max_time)\n+\t\tuint64_t *total_time, uint64_t *min_time, uint64_t *max_time, bool disable_et)\n {\n \tint ret = TEST_SUCCESS;\n \tuint16_t i, j, dequeued;\n@@ -4479,8 +4479,14 @@ latency_test_dec(struct rte_mempool *mempool,\n \t\t\tburst_sz = num_to_process - dequeued;\n \n \t\tret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz);\n-\t\tTEST_ASSERT_SUCCESS(ret,\n-\t\t\t\t\"rte_bbdev_dec_op_alloc_bulk() failed\");\n+\t\tTEST_ASSERT_SUCCESS(ret, \"rte_bbdev_dec_op_alloc_bulk() failed\");\n+\n+\t\tref_op->turbo_dec.iter_max = get_iter_max();\n+\t\t/* For validation tests we want to enable early termination */\n+\t\tif (!disable_et && !check_bit(ref_op->turbo_dec.op_flags,\n+\t\t\t\tRTE_BBDEV_TURBO_EARLY_TERMINATION))\n+\t\t\tref_op->turbo_dec.op_flags |= RTE_BBDEV_TURBO_EARLY_TERMINATION;\n+\n \t\tif (test_vector.op_type != RTE_BBDEV_OP_NONE)\n \t\t\tcopy_reference_dec_op(ops_enq, burst_sz, dequeued,\n \t\t\t\t\tbufs->inputs,\n@@ -4559,10 +4565,12 @@ latency_test_ldpc_dec(struct rte_mempool *mempool,\n \t\t/* For latency tests we need to disable early termination */\n \t\tif (disable_et && check_bit(ref_op->ldpc_dec.op_flags,\n \t\t\t\tRTE_BBDEV_LDPC_ITERATION_STOP_ENABLE))\n-\t\t\tref_op->ldpc_dec.op_flags -=\n-\t\t\t\t\tRTE_BBDEV_LDPC_ITERATION_STOP_ENABLE;\n+\t\t\tref_op->ldpc_dec.op_flags -= RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE;\n+\n \t\tref_op->ldpc_dec.iter_max = get_iter_max();\n-\t\tref_op->ldpc_dec.iter_count = ref_op->ldpc_dec.iter_max;\n+\t\t/* When ET is disabled, the expected iter_count is iter_max */\n+\t\tif (disable_et)\n+\t\t\tref_op->ldpc_dec.iter_count = ref_op->ldpc_dec.iter_max;\n \n \t\tif (test_vector.op_type != RTE_BBDEV_OP_NONE)\n \t\t\tcopy_reference_ldpc_dec_op(ops_enq, burst_sz, dequeued,\n@@ -4871,7 +4879,7 @@ validation_latency_test(struct active_device *ad,\n \t\titer = latency_test_dec(op_params->mp, bufs,\n \t\t\t\top_params->ref_dec_op, op_params->vector_mask,\n \t\t\t\tad->dev_id, queue_id, num_to_process,\n-\t\t\t\tburst_sz, &total_time, &min_time, &max_time);\n+\t\t\t\tburst_sz, &total_time, &min_time, &max_time, latency_flag);\n \telse if (op_type == RTE_BBDEV_OP_LDPC_ENC)\n \t\titer = latency_test_ldpc_enc(op_params->mp, bufs,\n \t\t\t\top_params->ref_enc_op, ad->dev_id, queue_id,\n",
    "prefixes": [
        "v3",
        "06/17"
    ]
}