Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124739/?format=api
{ "id": 124739, "url": "http://patches.dpdk.org/api/patches/124739/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230302202211.170017-3-hernan.vargas@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230302202211.170017-3-hernan.vargas@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230302202211.170017-3-hernan.vargas@intel.com", "date": "2023-03-02T20:21:56", "name": "[v3,02/17] test/bbdev: extend HARQ tolerance", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "dfcfc1393a3f0a7f7c7fc74ee30962fe39b1a688", "submitter": { "id": 2659, "url": "http://patches.dpdk.org/api/people/2659/?format=api", "name": "Hernan Vargas", "email": "hernan.vargas@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230302202211.170017-3-hernan.vargas@intel.com/mbox/", "series": [ { "id": 27233, "url": "http://patches.dpdk.org/api/series/27233/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27233", "date": "2023-03-02T20:21:54", "name": "test/bbdev: changes for 23.03", "version": 3, "mbox": "http://patches.dpdk.org/series/27233/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/124739/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/124739/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 11CE441DB8;\n\tThu, 2 Mar 2023 21:22:13 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C05D642BB1;\n\tThu, 2 Mar 2023 21:22:00 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id 1AD9340E09;\n Thu, 2 Mar 2023 21:21:57 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Mar 2023 12:21:57 -0800", "from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103])\n by orsmga008.jf.intel.com with ESMTP; 02 Mar 2023 12:21:56 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1677788518; x=1709324518;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=II7xXLlMMX2x2WsdGVAIWdk0LHDbh4X9DYMJtrddyt8=;\n b=Mtq5OBQO6Upz8CumcyBSxo8qrUEoMMGWwUC2yF5gCpgDLcRCjWWm9aWK\n Up5qTfu/xSJ6+CubkW/8Ls8cSCj7PXZ5gAWJSd8I3Ih/cj2RSEXz/0o6m\n M9jjWvvQMjxvbhulyj987R08TiLUdQw8uI9sKkAysMpRcyqzr4URFvEPm\n WCXEdAUZ+sM6GjvngXJ12Sv+9F5zxVFXnMiEQPvFzzOJ0EEqWaKE57d0/\n Ix9uzt7gk4RCRmyVoKfCtFyrU8PhLlCeysA2hnTpey8lQ/713Ay4yb72I\n itAYegSXhsSnvK0ePJ4sLprPFNovWb/Jj57XaFE/FMb7yDyGFlNMIp0dd A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10637\"; a=\"334871152\"", "E=Sophos;i=\"5.98,228,1673942400\"; d=\"scan'208\";a=\"334871152\"", "E=McAfee;i=\"6500,9779,10637\"; a=\"705398089\"", "E=Sophos;i=\"5.98,228,1673942400\"; d=\"scan'208\";a=\"705398089\"" ], "X-ExtLoop1": "1", "From": "Hernan Vargas <hernan.vargas@intel.com>", "To": "dev@dpdk.org, gakhil@marvell.com, trix@redhat.com,\n maxime.coquelin@redhat.com", "Cc": "nicolas.chautru@intel.com, qi.z.zhang@intel.com,\n Hernan Vargas <hernan.vargas@intel.com>, stable@dpdk.org", "Subject": "[PATCH v3 02/17] test/bbdev: extend HARQ tolerance", "Date": "Thu, 2 Mar 2023 12:21:56 -0800", "Message-Id": "<20230302202211.170017-3-hernan.vargas@intel.com>", "X-Mailer": "git-send-email 2.37.1", "In-Reply-To": "<20230302202211.170017-1-hernan.vargas@intel.com>", "References": "<20230302202211.170017-1-hernan.vargas@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "HARQ memory implementation could have different size assumptions.\nExtending HARQ tolerance to cover different implementations.\n\nFixes: 335c11fd276 (\"app/bbdev: support HARQ validation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hernan Vargas <hernan.vargas@intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n app/test-bbdev/test_bbdev_perf.c | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c\nindex 027f32cbf1b7..74e7e1394092 100644\n--- a/app/test-bbdev/test_bbdev_perf.c\n+++ b/app/test-bbdev/test_bbdev_perf.c\n@@ -95,6 +95,7 @@\n #define K0_3_1 56 /* K0 fraction numerator for rv 3 and BG 1 */\n #define K0_3_2 43 /* K0 fraction numerator for rv 3 and BG 2 */\n \n+#define HARQ_MEM_TOLERANCE 256\n static struct test_bbdev_vector test_vector;\n \n /* Switch between PMD and Interrupt for throughput TC */\n@@ -2090,13 +2091,17 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op,\n \t\tuint16_t data_len = rte_pktmbuf_data_len(m) - offset;\n \t\ttotal_data_size += orig_op->segments[i].length;\n \n-\t\tTEST_ASSERT(orig_op->segments[i].length <\n-\t\t\t\t(uint32_t)(data_len + 64),\n+\t\tTEST_ASSERT(orig_op->segments[i].length < (uint32_t)(data_len + HARQ_MEM_TOLERANCE),\n \t\t\t\t\"Length of segment differ in original (%u) and filled (%u) op\",\n \t\t\t\torig_op->segments[i].length, data_len);\n \t\tharq_orig = (int8_t *) orig_op->segments[i].addr;\n \t\tharq_out = rte_pktmbuf_mtod_offset(m, int8_t *, offset);\n \n+\t\t/* Cannot compare HARQ output data for such cases */\n+\t\tif ((ldpc_llr_decimals > 1) && ((ops_ld->op_flags & RTE_BBDEV_LDPC_LLR_COMPRESSION)\n+\t\t\t\t|| (ops_ld->op_flags & RTE_BBDEV_LDPC_HARQ_6BIT_COMPRESSION)))\n+\t\t\tbreak;\n+\n \t\tif (!(ldpc_cap_flags &\n \t\t\t\tRTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_FILLERS\n \t\t\t\t) || (ops_ld->op_flags &\n@@ -2172,7 +2177,7 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op,\n \n \t/* Validate total mbuf pkt length */\n \tuint32_t pkt_len = rte_pktmbuf_pkt_len(op->data) - op->offset;\n-\tTEST_ASSERT(total_data_size < pkt_len + 64,\n+\tTEST_ASSERT(total_data_size < pkt_len + HARQ_MEM_TOLERANCE,\n \t\t\t\"Length of data differ in original (%u) and filled (%u) op\",\n \t\t\ttotal_data_size, pkt_len);\n \n", "prefixes": [ "v3", "02/17" ] }