Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124410/?format=api
{ "id": 124410, "url": "http://patches.dpdk.org/api/patches/124410/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230222215541.158205-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230222215541.158205-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230222215541.158205-2-stephen@networkplumber.org", "date": "2023-02-22T21:55:20", "name": "[v11,01/22] gso: don't log message on non TCP/UDP", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "677c921aac92ff0f088325d450f88ebf235af022", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230222215541.158205-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 27146, "url": "http://patches.dpdk.org/api/series/27146/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27146", "date": "2023-02-22T21:55:19", "name": "Convert static log type values in libraries", "version": 11, "mbox": "http://patches.dpdk.org/series/27146/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/124410/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/124410/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 60AB441D43;\n\tWed, 22 Feb 2023 22:55:52 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0393B43171;\n\tWed, 22 Feb 2023 22:55:52 +0100 (CET)", "from mail-pf1-f182.google.com (mail-pf1-f182.google.com\n [209.85.210.182])\n by mails.dpdk.org (Postfix) with ESMTP id 6978343154\n for <dev@dpdk.org>; Wed, 22 Feb 2023 22:55:50 +0100 (CET)", "by mail-pf1-f182.google.com with SMTP id 16so5230050pfl.8\n for <dev@dpdk.org>; Wed, 22 Feb 2023 13:55:50 -0800 (PST)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n d7-20020aa78147000000b00571cdbd0771sm6400722pfn.102.2023.02.22.13.55.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Feb 2023 13:55:49 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=bRyRO3VTymBjGYshCckfveSSAEGjziLD70dZsRHNoIE=;\n b=DLagXWn6bZtlMIdm7VhB7kSaz3taaWVglu63ZTAMXs9Z7ice9IyvCiWPTSuewZ8HE8\n iqY3ZgsQ8Z0t9CMrwMdIX25aeT4MjFHLg7y3oAG0oei0wPoA9wTKUJkshiCcfcLMgb9E\n +UBorxyOLHErs/cUoUdE76jhrfOO+LdCnmj2rM07LilZl84GQlmme13zHVwnF0HQic/J\n w1jhgUYiE2CINTJ/oHRjUJAnO2FwH4NZ389guR/Mcql7N/MT/OpYgPY/jrcmcznImSRL\n DBHsImLa3TgtNS8e2Z3DQqt3D1fZHaXXemabZf+xuxpt65jAlyO93jgVDRC/VwsWerZD\n uldw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=bRyRO3VTymBjGYshCckfveSSAEGjziLD70dZsRHNoIE=;\n b=23bXR7UXmwoSS+BZ1DXeaHUBDM/FSePIpbac3f8L99qiRLdwwWMr6IxOc1uCijDqA4\n kdJO0wEwyNsyFuH6G/LdVMyK6dtS+Dr1bFgYfr8fOUA9uzwIk/5l3yTp8GjtD6gIdCiw\n 0OphugrErucVEK6JF/6/lrMIC5HpaEjaH3kvtQtZr82q99o+EPvEVEuw/4DwyjO46mvb\n KDdrYcDOnO7/oDn/hambUHdGwMgKEjTLLE+gR23k4kNUNEdh6yYa/kDJHDhptJCtpSN8\n T2ck0NEvLg5IMPR9oPlIRO47d5hD3xQgJsuvocqvKrGcH5h6lZlopiZUba9O9QeOmnEk\n 1OtA==", "X-Gm-Message-State": "AO0yUKVfES029F76MVnFK6+bePMUpSDBoJhvSe1uZ+gmMWJS6qduE+TV\n f3xBvoXfYme3lNLecDuXqM4IFOhKiRbhVTpj0YE=", "X-Google-Smtp-Source": "\n AK7set9WlmDj5k0GrJ1oASsvNBeI8cQ9g3s37wYuVCBdK0zm+4cLYy5sgr5I7K0Ky8eFUrFgwjFS5w==", "X-Received": "by 2002:aa7:9d83:0:b0:5a8:bd67:156d with SMTP id\n f3-20020aa79d83000000b005a8bd67156dmr7885396pfq.6.1677102949335;\n Wed, 22 Feb 2023 13:55:49 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Jiayu Hu <jiayu.hu@intel.com>, Mark Kavanagh <mark.b.kavanagh@intel.com>", "Subject": "[PATCH v11 01/22] gso: don't log message on non TCP/UDP", "Date": "Wed, 22 Feb 2023 13:55:20 -0800", "Message-Id": "<20230222215541.158205-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230222215541.158205-1-stephen@networkplumber.org>", "References": "<20230207204151.1503491-1-stephen@networkplumber.org>\n <20230222215541.158205-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "If a large packet is passed into GSO routines of unknown protocol\nthen library would log a message.\nBetter to tell the application instead of logging.\n\nFixes: 119583797b6a (\"gso: support TCP/IPv4 GSO\")\nReviewed-by: Jiayu Hu <jiayu.hu@intel.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/gso/rte_gso.c | 5 ++---\n lib/gso/rte_gso.h | 1 +\n 2 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/gso/rte_gso.c b/lib/gso/rte_gso.c\nindex 4b59217c16ee..c8e67c2d4b48 100644\n--- a/lib/gso/rte_gso.c\n+++ b/lib/gso/rte_gso.c\n@@ -80,9 +80,8 @@ rte_gso_segment(struct rte_mbuf *pkt,\n \t\tret = gso_udp4_segment(pkt, gso_size, direct_pool,\n \t\t\t\tindirect_pool, pkts_out, nb_pkts_out);\n \t} else {\n-\t\t/* unsupported packet, skip */\n-\t\tRTE_LOG(DEBUG, GSO, \"Unsupported packet type\\n\");\n-\t\tret = 0;\n+\t\tret = -ENOTSUP;\t/* only UDP or TCP allowed */\n+\n \t}\n \n \tif (ret < 0) {\ndiff --git a/lib/gso/rte_gso.h b/lib/gso/rte_gso.h\nindex 40922524df42..23d6980aff9f 100644\n--- a/lib/gso/rte_gso.h\n+++ b/lib/gso/rte_gso.h\n@@ -114,6 +114,7 @@ struct rte_gso_ctx {\n * - The number of GSO segments filled in pkts_out on success.\n * - Return 0 if it does not need to be GSO'd.\n * - Return -ENOMEM if run out of memory in MBUF pools.\n+ * - Return -ENOTSUP for protocols that can not be segmentd (not UDP or TCP)\n * - Return -EINVAL for invalid parameters.\n */\n int rte_gso_segment(struct rte_mbuf *pkt,\n", "prefixes": [ "v11", "01/22" ] }