Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124312/?format=api
http://patches.dpdk.org/api/patches/124312/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230221190208.514276-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230221190208.514276-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230221190208.514276-2-stephen@networkplumber.org", "date": "2023-02-21T19:01:47", "name": "[v9,01/22] gso: don't log message on non TCP/UDP", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "677c921aac92ff0f088325d450f88ebf235af022", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230221190208.514276-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 27127, "url": "http://patches.dpdk.org/api/series/27127/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27127", "date": "2023-02-21T19:01:46", "name": "Convert static logtypes in libraries", "version": 9, "mbox": "http://patches.dpdk.org/series/27127/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/124312/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/124312/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8D49B41D32;\n\tTue, 21 Feb 2023 20:02:18 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 80E8B41133;\n\tTue, 21 Feb 2023 20:02:18 +0100 (CET)", "from mail-pl1-f180.google.com (mail-pl1-f180.google.com\n [209.85.214.180])\n by mails.dpdk.org (Postfix) with ESMTP id 0899140691\n for <dev@dpdk.org>; Tue, 21 Feb 2023 20:02:18 +0100 (CET)", "by mail-pl1-f180.google.com with SMTP id c1so6391496plg.4\n for <dev@dpdk.org>; Tue, 21 Feb 2023 11:02:17 -0800 (PST)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n jc4-20020a17090325c400b001991e59fde6sm10213018plb.216.2023.02.21.11.02.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 Feb 2023 11:02:16 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=bRyRO3VTymBjGYshCckfveSSAEGjziLD70dZsRHNoIE=;\n b=6HPagWPx+gl/Ble3cOx4VEbB43V26EnooK5P3B4RMcVqJYe4wLyXi1tK4eKiDZfwiM\n NF8QSLFNG6+eZ8UOtRVt3cbtiLwr1d6YOpVyoDi7wYQH1iYq8MI1EvU5lPwvJ/s0vALA\n qRDvvFnLJTGOxUWTX03pOorXM0bvmUtyCqf6bbO7k3UDHxkCojq3uIOLT72Jfno+LdNo\n 9VC+v9FvbAH78POpGC1nSLtjQbDr8rwy9uGvKKSDrkf7Dk4RjraseAtsfL0qnuLAW5Nn\n In9jH4MmFvUAnh5jYih8UpzX3UiYSl/JZFt6PqeWBggqNgFQAEoZoURUNMpu7zMRp4hj\n 2AFQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=bRyRO3VTymBjGYshCckfveSSAEGjziLD70dZsRHNoIE=;\n b=JvlecwYPn+QLV2cGIsPNL1J+8SnMBdIB0wVCYrfty89YWdIagcke3tCX5j0yJM4vMb\n rhdJBeLtiDc689VRi6feOpLH2P/E0WU++gsf/WbWUOYPBAB8RJl1vSdXvClc8Yz1Vbuk\n 3VxgvXfehGl1Cl9pQcYztLdFxrjRZ5tT0uceilyZ1le3gOzMfn4b2VrymReCADs/JHlw\n +y9YWwTsZCILEHlptNN/suKk598us9L0RMV44FCIM8JlKu5EI2N0eJoid/oVd74pc8+B\n nyDu4fMul8A3rjruBTXanbNG2RrRo7gQW02I9z6aXdoBoO4o/5GO8Q+blNs1X5SSKodX\n 7nGw==", "X-Gm-Message-State": "AO0yUKVLYNn/v37hNm4SUmYRfN6R+3LKy4wq/rOkAaaDHd7/m/dJ5Zpc\n zXyo6Jb9zo1bin4StlOCXFKZOuE1sF6ctP1rxGk=", "X-Google-Smtp-Source": "\n AK7set8XetyPl/+4KKC6+M2ZD/it4t53j4FkC9iPTZcAK4HBbvGx4dtck6E8w97jnc4t/LnxSFiqDg==", "X-Received": "by 2002:a17:902:ceca:b0:19a:85a7:dcb9 with SMTP id\n d10-20020a170902ceca00b0019a85a7dcb9mr5786398plg.2.1677006136930;\n Tue, 21 Feb 2023 11:02:16 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Jiayu Hu <jiayu.hu@intel.com>, Mark Kavanagh <mark.b.kavanagh@intel.com>", "Subject": "[PATCH v9 01/22] gso: don't log message on non TCP/UDP", "Date": "Tue, 21 Feb 2023 11:01:47 -0800", "Message-Id": "<20230221190208.514276-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230221190208.514276-1-stephen@networkplumber.org>", "References": "<20230207204151.1503491-1-stephen@networkplumber.org>\n <20230221190208.514276-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "If a large packet is passed into GSO routines of unknown protocol\nthen library would log a message.\nBetter to tell the application instead of logging.\n\nFixes: 119583797b6a (\"gso: support TCP/IPv4 GSO\")\nReviewed-by: Jiayu Hu <jiayu.hu@intel.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/gso/rte_gso.c | 5 ++---\n lib/gso/rte_gso.h | 1 +\n 2 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/gso/rte_gso.c b/lib/gso/rte_gso.c\nindex 4b59217c16ee..c8e67c2d4b48 100644\n--- a/lib/gso/rte_gso.c\n+++ b/lib/gso/rte_gso.c\n@@ -80,9 +80,8 @@ rte_gso_segment(struct rte_mbuf *pkt,\n \t\tret = gso_udp4_segment(pkt, gso_size, direct_pool,\n \t\t\t\tindirect_pool, pkts_out, nb_pkts_out);\n \t} else {\n-\t\t/* unsupported packet, skip */\n-\t\tRTE_LOG(DEBUG, GSO, \"Unsupported packet type\\n\");\n-\t\tret = 0;\n+\t\tret = -ENOTSUP;\t/* only UDP or TCP allowed */\n+\n \t}\n \n \tif (ret < 0) {\ndiff --git a/lib/gso/rte_gso.h b/lib/gso/rte_gso.h\nindex 40922524df42..23d6980aff9f 100644\n--- a/lib/gso/rte_gso.h\n+++ b/lib/gso/rte_gso.h\n@@ -114,6 +114,7 @@ struct rte_gso_ctx {\n * - The number of GSO segments filled in pkts_out on success.\n * - Return 0 if it does not need to be GSO'd.\n * - Return -ENOMEM if run out of memory in MBUF pools.\n+ * - Return -ENOTSUP for protocols that can not be segmentd (not UDP or TCP)\n * - Return -EINVAL for invalid parameters.\n */\n int rte_gso_segment(struct rte_mbuf *pkt,\n", "prefixes": [ "v9", "01/22" ] }{ "id": 124312, "url": "