Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124260/?format=api
{ "id": 124260, "url": "http://patches.dpdk.org/api/patches/124260/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230221055222.38289-3-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230221055222.38289-3-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230221055222.38289-3-chaoyong.he@corigine.com", "date": "2023-02-21T05:52:22", "name": "[2/2] net/nfp: fix getting wrong RSS configuration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6cd16a70be25b66c957da77fdd9bd826f3637f19", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230221055222.38289-3-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 27104, "url": "http://patches.dpdk.org/api/series/27104/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27104", "date": "2023-02-21T05:52:20", "name": "add support for RSS parsing of SCTP packet", "version": 1, "mbox": "http://patches.dpdk.org/series/27104/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/124260/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/124260/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F09B041CF8;\n\tTue, 21 Feb 2023 06:52:57 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 751C143184;\n\tTue, 21 Feb 2023 06:52:45 +0100 (CET)", "from NAM10-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam10on2129.outbound.protection.outlook.com [40.107.94.129])\n by mails.dpdk.org (Postfix) with ESMTP id 5B5E043184;\n Tue, 21 Feb 2023 06:52:43 +0100 (CET)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by SN4PR13MB5661.namprd13.prod.outlook.com (2603:10b6:806:21c::22)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.20; Tue, 21 Feb\n 2023 05:52:41 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::7ea4:e421:5dd5:9f4d%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023\n 05:52:41 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=ipSnSYh1pr7DfvGbraW6YR+Mh4bY4fsWUFy2St9iwkIeyZ1rzHiUFaBlR0EchDn2SyKgT+CsCH+LO+eoYwuuiu4NYuM3NULZ+bTEOK7JPy1n3b426PpiZre1S/LcjZHyACuYDjgDnO8LnQx04ny8OlIhKwqBjI5Yyp6KcT2VcQQuxfvwH9QROQ8htUGxyfupsyisCTZ+3KJIJjDp7kjfuja4DTbeLSq3eQqLEVRLa27QmIjtVKZLzC2/3dL3mewAxLelpmFAp0zvbT0QJYraLoS4S9+gR6Cv7AmwLgpEv7ST9PWfXoEgYm0vtCn6tvg0L/cnmEavS9ThYZ75LIS/IQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=fQJo6Rgl1nycSssmrVppAVElZlufoFN6V1/WvEEhfIM=;\n b=klOCiKxw1CNR3fG0Xw+3C8JeRhyRhivSrR+yldQ2aAWEm2Rp3XAB5rKFr67dodWL/Yhw9f1YZZ9r0lLQ33pk2uR0iSwxHlcZGKG4ERr1k6Z+e3jXMsHK2FaloygJSB/IOmJZBI24nMmxIPqUvb7AVhes89OyuDNHKKsFwQ8bj+jGmqQTQm1knvk5dK4MDpG6sCraOdJ2dibMFeeRe0V/G2Q595Ylca5d9gXhfp610FN8sYjd8SYUnZbVHznyKxPlpvXjXXQ7dYsP75oZo9vG7vkCfpVuSeB0Y2pEloR1hIOD1OaSKwK3I4NefbNrOmwnMg3OZyYC0yKMl0cPGvBBjg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=fQJo6Rgl1nycSssmrVppAVElZlufoFN6V1/WvEEhfIM=;\n b=gwKbKEL+qNJtxCvI5B1jHKLWmCORLahqrKaRmezbtwBV2EjfBT2o1w75Sl/Kvva7pu1WVLZ0CFauDHuJB5PRtlylhN1nF02iEdMMZMEwNwZ4W6TeGiJqWqdqOhQ0nSpHIisVqJKxGkCgBsmDb3Nl9Td5SggpMwQW7j1BJpSJ1VY=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, niklas.soderlund@corigine.com,\n Long Wu <long.wu@corigine.com>, louis.peens@corigine.com, stable@dpdk.org,\n Chaoyong He <chaoyong.he@corigine.com>", "Subject": "[PATCH 2/2] net/nfp: fix getting wrong RSS configuration", "Date": "Tue, 21 Feb 2023 13:52:22 +0800", "Message-Id": "<20230221055222.38289-3-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.29.3", "In-Reply-To": "<20230221055222.38289-1-chaoyong.he@corigine.com>", "References": "<20230221055222.38289-1-chaoyong.he@corigine.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-ClientProxiedBy": "BYAPR05CA0084.namprd05.prod.outlook.com\n (2603:10b6:a03:e0::25) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|SN4PR13MB5661:EE_", "X-MS-Office365-Filtering-Correlation-Id": "a28f79c0-992c-471c-d894-08db13cfd811", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 8xpu2L+RQrRpsOkcENs9YcKBYY9lECkppOv1I6PEacnpQBkZWnJDzyWD9M+/3952soh2Ju8R9Kwt64GcmbuJbi3uTOiFDKo8VGzAUGIShMZA/pYkydoQoPXwWnQojQd9f/itSsA8up35U16JG3XxoiYNLI2XDDBhFgdY7gRWvFJD1b3xRj7hOk6ezZpO2mDqwCxWwxWCVXgzr1wD42Rf/f4JKPI5knASetmENhhru0GqhsI/aMZtASMrXOAfaZ+SRO66oFT/6lpuZys/PIZvtyT+4x95mOaALGy7nnlVnAXf+GPPJzWJTgP48PPph4WBqCr6vehDbP0lfo4LzgA7XMUIPQnMnYnawNosUtSOJ+sSMG6FQYOhk33v9ouUnMoqQPoDuZ1rCWD33BxuypIKYU1xy+BSiazMnuc0wN8EM9RNIjGeapH/b9yO5QFF62IoIvT2pMVB1jcdC5LFZNYXAXp5ES/oXY046WHHu0gc/WqaSpQ8sd72Mh7mA1hBjeuAn6SfJLkUd+74RdWhqBi/+/UpTvFxjY3PtZonUFEHD5a+LzZZ0c3A0haZqwykf3kBklE4+fnKgbNc44MfOOnY8fDXg1atb1FPOxR1F/S78HhIjuVv+B8R7lj0MoQsJChZUDmGBQio/KhIoFYQei3DmC1t70rO6JZhnHXezmBmDVk5ixTWzh8SclXESh7i7voijDOKni/PriDx5g7xQswz4OeuOXG1IldgkuFKk/3w+Ib2KjCpmbw7eugpS1gcBy7F", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230025)(4636009)(39840400004)(376002)(346002)(396003)(136003)(366004)(451199018)(5660300002)(8936002)(44832011)(4326008)(450100002)(6916009)(8676002)(2906002)(66556008)(66946007)(66476007)(316002)(54906003)(6486002)(478600001)(107886003)(52116002)(6666004)(1076003)(186003)(6512007)(26005)(41300700001)(6506007)(86362001)(36756003)(2616005)(83380400001)(38350700002)(38100700002);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?93EpcdHsURbVyySay3edqiSmloHf?=\n\t=?utf-8?q?rsqHbJRZK9kEy+aa4kOwnxwRyDCKcinuUflBCAeT908F2lJ/f4kwUQTLPePVNcbHv?=\n\t=?utf-8?q?plt1+d1NUWrhAcD18jOVf/xnqacw0K9XWfGfGcPmBUZzsnZ8Dq/6cpfVelvCJ71Mk?=\n\t=?utf-8?q?cxo41EsiuPQUAtyZtol4Taalv52O2PZ7wyvAhRSTh9pl8+qw6Q1am9PH/w9T8tPE9?=\n\t=?utf-8?q?l2RuZ7PnOM4qNSvkw875/TFwN+BPa9KHP3ZAQwmfXVQilCUev3A5e+xzP4ATkUx7g?=\n\t=?utf-8?q?MAd5S7Zom22VUM6y9aHOp5jH/P0vnXRIWXke6z/Izh2a2M+m0quT2/7TNndUx0/85?=\n\t=?utf-8?q?P8KLrDor3p5I/p5wJfWbBqqaJd7iyRC5ueCTh37SxdI9f73gSag3m6wOLK4V2PW6u?=\n\t=?utf-8?q?57YaHElZTwzzjyK11ueB8ZBjUt5efRCozERw/xLnsxYR69XvIAmoBtASreKALQiKq?=\n\t=?utf-8?q?nwZTc1JB9/6cKYwzHlYG8IEPk1r2TwTEGuONZjF668ediiF+huBO+iLlNJ2ZyhZl7?=\n\t=?utf-8?q?9zxLbOUCtRiWN3kPan946nYF9iobILqOqdRuezBT0CbwMmwvwkkrQm1jgqXL3dtbJ?=\n\t=?utf-8?q?haLnzedD1s7DDvqz9Z3Uvakno1YYKg8h+WFSQuLvVVXUHCxWog0lCIeRE4CfAG2HQ?=\n\t=?utf-8?q?T+vh4rgJwmS2qn8ZHNN0/ZFGTyFj6UFUNgG1/RnxFlw9GGrzhj2xc9oRv5sux1AIC?=\n\t=?utf-8?q?yDEzbonAa8k1yuxD7WTWEHXOR120TAeNdUrj/91dRgXnl2EoqUlBlDJ+SNgBxvyL3?=\n\t=?utf-8?q?qoZij5DOrzikR9iaWgh2sjf2e6yA4xqWS0MH1m+gxLnC8rC2QLcXnW+1nkgML4JUm?=\n\t=?utf-8?q?evPZZjxFHPHGFrdaMu30cy469Vzu1bRnc0/IgnWqOPTc2UfdM9SrFv7dhWNGF6H5x?=\n\t=?utf-8?q?Mwb8SYxKKglgmeRyH+u3XbWbjs8E2SL4wJ4cmhblqIHPwUA/Ql8IuEIFZNgPtum1V?=\n\t=?utf-8?q?PjrrGe0kQbEIU5+gHjjsozYmeGeZqRKVBbQ76bwfhYShlDcYD9PRZO7OT8uuf+/VV?=\n\t=?utf-8?q?XBl2uZC+NaL3Rlo1TfHac+mNTE9nO1xBhc4sgRKvHl6W+CSMYvs9OWp8LDVEuK9Pf?=\n\t=?utf-8?q?nsdOp+Vk2rXjo9CWdTt6aVg+PqXz8GIHQMMfxGwQURXW8EDo4+BhJbLO/owge1cR2?=\n\t=?utf-8?q?/jPKvg6ox945Oh5ttGY0m4xfCtx3EGLs+/+Zjz4bkZgChqEtehmSO5qiKiaNcQHru?=\n\t=?utf-8?q?vMY+IsYEifJC8hyO0rgD3CQ85a/ye769aQnVPiHPhuEzyyFCscv0ngbsRM4XMk0Yx?=\n\t=?utf-8?q?aQjDtTPcCs11pQgkQVC926GOvTgt1si5l0mLkANSzQw7Vb7uUzNiSydp+smD4NCQt?=\n\t=?utf-8?q?FkAKcZ5iVUBc/I1rxcJAmzTEfwTj4bG7RvRLA0ryWH9W180WZ3vH87geFdlUqWLXk?=\n\t=?utf-8?q?7q46lXzMfTctfAO+Nddm9BmIuQNwUCSKjqitqnmDJ70iHj3ma5rZ5H7t5KbwPdMs4?=\n\t=?utf-8?q?akGGz7uvDPJlgvCtQ+r6FFGiK1IeUpCQ/sL7n9dJtQUiL0jh7rbqcs4CyBnojB3Ft?=\n\t=?utf-8?q?SilqgYM3WKliGPZdTCSd8vVun10rn1mvzw=3D=3D?=", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n a28f79c0-992c-471c-d894-08db13cfd811", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "21 Feb 2023 05:52:41.1169 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n e2ad2NNyQ+glV5ChokYnHvBFOa6djoqdazML5pRa/3VXECO5ocoAGGrEUJvIyMRM2eL0jFJlgY0iOBIe6+O0ZhMeDsqDJnlgtBLBHdYAec0=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SN4PR13MB5661", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Long Wu <long.wu@corigine.com>\n\n\"NFP_NET_CFG_RSS_IPV4\" and \"NFP_NET_CFG_RSS_IPV6\" represent that firmware\nwill calculate RSS base on l3 rather than udp or tcp information from\npackets. So the logic of return RSS configuration in driver is wrong.\nModify code to return the right configuration.\n\nFixes: 934e4c60fbff (\"nfp: add RSS\")\nCc: louis.peens@corigine.com\nCc: stable@dpdk.org\n\nSigned-off-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>\n---\n drivers/net/nfp/nfp_common.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c\nindex cfc38db65a..a025c67e3b 100644\n--- a/drivers/net/nfp/nfp_common.c\n+++ b/drivers/net/nfp/nfp_common.c\n@@ -1420,7 +1420,7 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev,\n \tcfg_rss_ctrl = nn_cfg_readl(hw, NFP_NET_CFG_RSS_CTRL);\n \n \tif (cfg_rss_ctrl & NFP_NET_CFG_RSS_IPV4)\n-\t\trss_hf |= RTE_ETH_RSS_NONFRAG_IPV4_TCP | RTE_ETH_RSS_NONFRAG_IPV4_UDP;\n+\t\trss_hf |= RTE_ETH_RSS_IPV4;\n \n \tif (cfg_rss_ctrl & NFP_NET_CFG_RSS_IPV4_TCP)\n \t\trss_hf |= RTE_ETH_RSS_NONFRAG_IPV4_TCP;\n@@ -1435,7 +1435,7 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev,\n \t\trss_hf |= RTE_ETH_RSS_NONFRAG_IPV6_UDP;\n \n \tif (cfg_rss_ctrl & NFP_NET_CFG_RSS_IPV6)\n-\t\trss_hf |= RTE_ETH_RSS_NONFRAG_IPV4_UDP | RTE_ETH_RSS_NONFRAG_IPV6_UDP;\n+\t\trss_hf |= RTE_ETH_RSS_IPV6;\n \n \tif (cfg_rss_ctrl & NFP_NET_CFG_RSS_IPV4_SCTP)\n \t\trss_hf |= RTE_ETH_RSS_NONFRAG_IPV4_SCTP;\n", "prefixes": [ "2/2" ] }