Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124229/?format=api
{ "id": 124229, "url": "http://patches.dpdk.org/api/patches/124229/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230220233556.168553-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230220233556.168553-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230220233556.168553-7-stephen@networkplumber.org", "date": "2023-02-20T23:35:40", "name": "[v8,06/22] acl: replace LOGTYPE_ACL with dynamic type", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ae36886d93bbadd87da7e3334d08aa63d15187eb", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230220233556.168553-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 27098, "url": "http://patches.dpdk.org/api/series/27098/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27098", "date": "2023-02-20T23:35:34", "name": "Convert static logtypes in libraries", "version": 8, "mbox": "http://patches.dpdk.org/series/27098/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/124229/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/124229/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 90D8641CF1;\n\tTue, 21 Feb 2023 00:36:34 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B0D1C43135;\n\tTue, 21 Feb 2023 00:36:11 +0100 (CET)", "from mail-pf1-f176.google.com (mail-pf1-f176.google.com\n [209.85.210.176])\n by mails.dpdk.org (Postfix) with ESMTP id BCEC043114\n for <dev@dpdk.org>; Tue, 21 Feb 2023 00:36:04 +0100 (CET)", "by mail-pf1-f176.google.com with SMTP id a7so1567370pfx.10\n for <dev@dpdk.org>; Mon, 20 Feb 2023 15:36:04 -0800 (PST)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n q19-20020a62e113000000b005a8dc935ec1sm8215908pfh.62.2023.02.20.15.36.02\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 20 Feb 2023 15:36:02 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=3ldJ1TGJozc5mJEWZuOvXWpF5n6V+gym2v8kL89wnvo=;\n b=j6+il5VfuOdANV7IBuZ5tFPkat6xY8MZkZtDU3wqFZeLggWdrY1/3aQVCIER5w2+tT\n vSwPcB3R8n3ab1zYVxUmHnDGg34gzGE9QoNkoV0XLCGN3HQIHvydq52kDmVv5hMg7T6G\n dxw9Dk0YRxQ6E5UfqxYDXnWpW1kgRq6plq2Fh1CxHFjf2N8EcRHw6MKPmWQdB1XHvphJ\n rdp8Z6bjz1nu4tcTLXi7Ni9C5bvwizo+JEc50xxTp8nI59pCS2E86q+LduWHpNHcJDn/\n GnE3VwXT+tFTB8xFL7NpIml/0Poe9+TcynL9rC+QfqQDLO0B7uP3/FRRtf/4rodthsCw\n iSpg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=3ldJ1TGJozc5mJEWZuOvXWpF5n6V+gym2v8kL89wnvo=;\n b=8Razo1YlJ8lkzMwZQUsL0ZwZ/lwJxJjZEzmdu5Xl7pw+BMGsWxVctcFNEf4lrJ80hu\n eNx1xpYn7TMBZHBjH9DPh/d3n2b2fFROL14M17KBTmw6CcftEmcE5oiUL4S9zlOo5mz0\n SpGTrWem82FrD8KQ8VOxRmGoPxf5WPgY3htGyBcF3yaywgYuLeOtLMgK74wBiMvo+kZg\n +gRJvjEgzue58CXrzyplF8Oza++g0J7h2gXZCLuoVE9vhrG+eYRJvEGenJbZLr5Im+7j\n bjp9CPhnUxOS1/1/ESGlsaIWSdvUEWukVDIs19F70yPQqP9u8UBLrmVCsT1FEq+Wd+0k\n OaWw==", "X-Gm-Message-State": "AO0yUKWxB1R8U+/kG+FSB4HDdXBTXpVc7xPLsnk+/YNhtBc0OUosp8cI\n FVDUOlDQw7bhc0oO+gwkdByNV2bmuVLPMojl7gQ=", "X-Google-Smtp-Source": "\n AK7set+GGvaMJtWrlhe2UTWD/I+5OBaBOiienl7a/IqH/1QtEjux3j1x6vakrfU/fA1HK/fLgK81+Q==", "X-Received": "by 2002:a62:6182:0:b0:5a8:ae6b:bdb0 with SMTP id\n v124-20020a626182000000b005a8ae6bbdb0mr2970941pfb.33.1676936163588;\n Mon, 20 Feb 2023 15:36:03 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v8 06/22] acl: replace LOGTYPE_ACL with dynamic type", "Date": "Mon, 20 Feb 2023 15:35:40 -0800", "Message-Id": "<20230220233556.168553-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230220233556.168553-1-stephen@networkplumber.org>", "References": "<20230207204151.1503491-1-stephen@networkplumber.org>\n <20230220233556.168553-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Get rid of RTE_LOGTYPE_ACL and RTE_LOGTYPE_MALLOC.\nFor ACL library use a dynamic type.\nThe one message using RTE_LOGTYPE_MALLOC should have been\nunder the ACL logtype anyway.\n\nThe test code should not have been using fixed log type\nso just change that to stderr.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test/test_acl.c | 3 ++-\n lib/acl/acl_bld.c | 1 +\n lib/acl/acl_gen.c | 1 +\n lib/acl/acl_log.h | 4 ++++\n lib/acl/rte_acl.c | 4 ++++\n lib/acl/tb_mem.c | 3 ++-\n lib/eal/common/eal_common_log.c | 2 --\n lib/eal/include/rte_log.h | 4 ++--\n 8 files changed, 16 insertions(+), 6 deletions(-)\n create mode 100644 lib/acl/acl_log.h", "diff": "diff --git a/app/test/test_acl.c b/app/test/test_acl.c\nindex 623f34682e69..75588978a720 100644\n--- a/app/test/test_acl.c\n+++ b/app/test/test_acl.c\n@@ -154,7 +154,8 @@ rte_acl_ipv4vlan_add_rules(struct rte_acl_ctx *ctx,\n \tfor (i = 0; i != num; i++) {\n \t\trc = acl_ipv4vlan_check_rule(rules + i);\n \t\tif (rc != 0) {\n-\t\t\tRTE_LOG(ERR, ACL, \"%s: rule #%u is invalid\\n\",\n+\t\t\tfprintf(stderr,\n+\t\t\t\t\"%s: rule #%u is invalid\\n\",\n \t\t\t\t__func__, i + 1);\n \t\t\treturn rc;\n \t\t}\ndiff --git a/lib/acl/acl_bld.c b/lib/acl/acl_bld.c\nindex 2816632803bd..f38e6478315f 100644\n--- a/lib/acl/acl_bld.c\n+++ b/lib/acl/acl_bld.c\n@@ -5,6 +5,7 @@\n #include <rte_acl.h>\n #include \"tb_mem.h\"\n #include \"acl.h\"\n+#include \"acl_log.h\"\n \n #define\tACL_POOL_ALIGN\t\t8\n #define\tACL_POOL_ALLOC_MIN\t0x800000\ndiff --git a/lib/acl/acl_gen.c b/lib/acl/acl_gen.c\nindex e759a2ca1598..54ec485d0c58 100644\n--- a/lib/acl/acl_gen.c\n+++ b/lib/acl/acl_gen.c\n@@ -4,6 +4,7 @@\n \n #include <rte_acl.h>\n #include \"acl.h\"\n+#include \"acl_log.h\"\n \n #define\tQRANGE_MIN\t((uint8_t)INT8_MIN)\n \ndiff --git a/lib/acl/acl_log.h b/lib/acl/acl_log.h\nnew file mode 100644\nindex 000000000000..b55573cbe207\n--- /dev/null\n+++ b/lib/acl/acl_log.h\n@@ -0,0 +1,4 @@\n+/* SPDX-License-Identifier: BSD-3-Clause */\n+\n+extern int acl_logtype;\n+#define RTE_LOGTYPE_ACL\tacl_logtype\ndiff --git a/lib/acl/rte_acl.c b/lib/acl/rte_acl.c\nindex a61c3ba188da..a29decb1f6ca 100644\n--- a/lib/acl/rte_acl.c\n+++ b/lib/acl/rte_acl.c\n@@ -6,8 +6,12 @@\n #include <rte_string_fns.h>\n #include <rte_acl.h>\n #include <rte_tailq.h>\n+#include <rte_log.h>\n \n #include \"acl.h\"\n+#include \"acl_log.h\"\n+\n+RTE_LOG_REGISTER_DEFAULT(acl_logtype, INFO);\n \n TAILQ_HEAD(rte_acl_list, rte_tailq_entry);\n \ndiff --git a/lib/acl/tb_mem.c b/lib/acl/tb_mem.c\nindex f14d7b4fa26e..6a9d96aaeda2 100644\n--- a/lib/acl/tb_mem.c\n+++ b/lib/acl/tb_mem.c\n@@ -3,6 +3,7 @@\n */\n \n #include \"tb_mem.h\"\n+#include \"acl_log.h\"\n \n /*\n * Memory management routines for temporary memory.\n@@ -25,7 +26,7 @@ tb_pool(struct tb_mem_pool *pool, size_t sz)\n \tsize = sz + pool->alignment - 1;\n \tblock = calloc(1, size + sizeof(*pool->block));\n \tif (block == NULL) {\n-\t\tRTE_LOG(ERR, MALLOC, \"%s(%zu)\\n failed, currently allocated \"\n+\t\tRTE_LOG(ERR, ACL, \"%s(%zu)\\n failed, currently allocated \"\n \t\t\t\"by pool: %zu bytes\\n\", __func__, sz, pool->alloc);\n \t\tsiglongjmp(pool->fail, -ENOMEM);\n \t\treturn NULL;\ndiff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c\nindex d4389e436913..9e853addb717 100644\n--- a/lib/eal/common/eal_common_log.c\n+++ b/lib/eal/common/eal_common_log.c\n@@ -349,14 +349,12 @@ struct logtype {\n \n static const struct logtype logtype_strings[] = {\n \t{RTE_LOGTYPE_EAL, \"lib.eal\"},\n-\t{RTE_LOGTYPE_MALLOC, \"lib.malloc\"},\n \t{RTE_LOGTYPE_RING, \"lib.ring\"},\n \t{RTE_LOGTYPE_MEMPOOL, \"lib.mempool\"},\n \t{RTE_LOGTYPE_PMD, \"pmd\"},\n \t{RTE_LOGTYPE_HASH, \"lib.hash\"},\n \t{RTE_LOGTYPE_LPM, \"lib.lpm\"},\n \t{RTE_LOGTYPE_KNI, \"lib.kni\"},\n-\t{RTE_LOGTYPE_ACL, \"lib.acl\"},\n \t{RTE_LOGTYPE_POWER, \"lib.power\"},\n \t{RTE_LOGTYPE_METER, \"lib.meter\"},\n \t{RTE_LOGTYPE_SCHED, \"lib.sched\"},\ndiff --git a/lib/eal/include/rte_log.h b/lib/eal/include/rte_log.h\nindex 941fbe51fd30..1408722b2c2f 100644\n--- a/lib/eal/include/rte_log.h\n+++ b/lib/eal/include/rte_log.h\n@@ -27,7 +27,7 @@ extern \"C\" {\n \n /* SDK log type */\n #define RTE_LOGTYPE_EAL 0 /**< Log related to eal. */\n-#define RTE_LOGTYPE_MALLOC 1 /**< Log related to malloc. */\n+\t\t\t\t /* was RTE_LOGTYPE_MALLOC */\n #define RTE_LOGTYPE_RING 2 /**< Log related to ring. */\n #define RTE_LOGTYPE_MEMPOOL 3 /**< Log related to mempool. */\n \t\t\t\t /* was RTE_LOGTYPE_TIMER */\n@@ -35,7 +35,7 @@ extern \"C\" {\n #define RTE_LOGTYPE_HASH 6 /**< Log related to hash table. */\n #define RTE_LOGTYPE_LPM 7 /**< Log related to LPM. */\n #define RTE_LOGTYPE_KNI 8 /**< Log related to KNI. */\n-#define RTE_LOGTYPE_ACL 9 /**< Log related to ACL. */\n+\t\t\t\t /* was RTE_LOGTYPE_ACL */\n #define RTE_LOGTYPE_POWER 10 /**< Log related to power. */\n #define RTE_LOGTYPE_METER 11 /**< Log related to QoS meter. */\n #define RTE_LOGTYPE_SCHED 12 /**< Log related to QoS port scheduler. */\n", "prefixes": [ "v8", "06/22" ] }