Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 124162,
    "url": "http://patches.dpdk.org/api/patches/124162/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230219231416.22524-8-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230219231416.22524-8-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230219231416.22524-8-stephen@networkplumber.org",
    "date": "2023-02-19T23:14:14",
    "name": "[v4,7/9] fib: enable on Windows",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "6068c2d50ad34dfbd181d2b413ab7c156410cc59",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230219231416.22524-8-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 27076,
            "url": "http://patches.dpdk.org/api/series/27076/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27076",
            "date": "2023-02-19T23:14:07",
            "name": "Enable building more libraries on Windows",
            "version": 4,
            "mbox": "http://patches.dpdk.org/series/27076/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/124162/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/124162/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 01CDD41CE4;\n\tMon, 20 Feb 2023 00:15:02 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3E32C42DB8;\n\tMon, 20 Feb 2023 00:14:35 +0100 (CET)",
            "from mail-pj1-f47.google.com (mail-pj1-f47.google.com\n [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id F12D542D82\n for <dev@dpdk.org>; Mon, 20 Feb 2023 00:14:26 +0100 (CET)",
            "by mail-pj1-f47.google.com with SMTP id ot9so1506930pjb.3\n for <dev@dpdk.org>; Sun, 19 Feb 2023 15:14:26 -0800 (PST)",
            "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n l10-20020a170902d34a00b00192fe452e17sm683336plk.162.2023.02.19.15.14.25\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 19 Feb 2023 15:14:25 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=XpjjUg+XGIk8i8zqgDx2zb0AHCW+0KwDkb6IUa23Ft8=;\n b=sld0wx59CZz5B76XP+UJGwMu5EG7xs4NnmNYqt0CVsER/YP68Ez1vvGQ6lKTLtihHD\n 3HjAWeSFHeva1+ocEBuwfAkvjHx2gTg+jaLTxN1snmgIqfSu8/bKS2qPLNw/CHzRNe1h\n P64npG+qwNdLCdR2cGbOtYgq63h1/VXDTan/IoNQEhvvb6HCQS3BpwH5irJBn744rKjg\n m1EcIk+/xZCT+JPptbhEc3M+4tL+bDeoVGkhgTlHPnbSxSm3CvoDtPo7MIE+igERv3AT\n 5lgMISWCVtDBygUL9lCqIA0wiji3g40270Rim2L1unL8NHYjYO5hZhxIGFnKw1kiwBDM\n NU5g==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=XpjjUg+XGIk8i8zqgDx2zb0AHCW+0KwDkb6IUa23Ft8=;\n b=1jKjRt3YUVxLvERnjzqsAzmE5VEWg4ggqP0XOejhw4LvGSv7u30d4/AeQqFJ+7RT8V\n 3UoqGcfzNa35BlcqHa7xogcAMn9WHW4fNQTee3E+SZVmqS8rSQKF4LUsroWkElrqca1m\n Oo5Xc3jPhrqRC3xQxu+SlXyHnzUMQmAEn2+dvtHvFzsBTl1Da4DMsOeS2QINzHMaVT92\n O1aK1qKYKbAEkqRJ8eKKZCwPPtfiS+ghZfBZREzob3I6VdBSt+2Gd2M5hJkPICeGT8SN\n GXXs84SBto3t82+IbhQLmC3orfXmjPvrZhK/Yx2XzaQOT+AQOYwzDYOiAbnfqBFf7+bD\n oIOA==",
        "X-Gm-Message-State": "AO0yUKV2D5Fc+RI/7IZh7dMSnL7yH+9zatPQinsW96HE3bxNrFJCDIsV\n ic0b/psIOPG2ZLUihY/huhhaZ5aeQahoXIjhe+A=",
        "X-Google-Smtp-Source": "\n AK7set9q9vX1tj806sD7xK8YAAykJe1smNRioz3bMZYqDQmhDY3A1pyhcwGJlc0Vo0X+ocRIfGDZhg==",
        "X-Received": "by 2002:a17:903:41c3:b0:19b:e73:809b with SMTP id\n u3-20020a17090341c300b0019b0e73809bmr435101ple.25.1676848466200;\n Sun, 19 Feb 2023 15:14:26 -0800 (PST)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>",
        "Subject": "[PATCH v4 7/9] fib: enable on Windows",
        "Date": "Sun, 19 Feb 2023 15:14:14 -0800",
        "Message-Id": "<20230219231416.22524-8-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.39.1",
        "In-Reply-To": "<20230219231416.22524-1-stephen@networkplumber.org>",
        "References": "<20230207001937.875608-1-stephen@networkplumber.org>\n <20230219231416.22524-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "The FIB library builds on Windows as long as sys/queue.h is defined.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n app/test/test_fib.c       | 22 +---------------------\n app/test/test_fib6.c      | 24 ++----------------------\n app/test/test_fib6_perf.c | 15 +--------------\n app/test/test_fib_perf.c  | 19 +++----------------\n lib/fib/meson.build       |  6 ------\n lib/fib/rte_fib.c         |  1 +\n lib/fib/rte_fib6.c        |  1 +\n 7 files changed, 9 insertions(+), 79 deletions(-)",
    "diff": "diff --git a/app/test/test_fib.c b/app/test/test_fib.c\nindex a2d1ea8f3abc..eb69d6e2fd4c 100644\n--- a/app/test/test_fib.c\n+++ b/app/test/test_fib.c\n@@ -9,28 +9,10 @@\n \n #include <rte_ip.h>\n #include <rte_log.h>\n+#include <rte_fib.h>\n \n #include \"test.h\"\n \n-#ifdef RTE_EXEC_ENV_WINDOWS\n-static int\n-test_fib(void)\n-{\n-\tprintf(\"fib not supported on Windows, skipping test\\n\");\n-\treturn TEST_SKIPPED;\n-}\n-\n-static int\n-test_slow_fib(void)\n-{\n-\tprintf(\"slow_fib not supported on Windows, skipping test\\n\");\n-\treturn TEST_SKIPPED;\n-}\n-\n-#else\n-\n-#include <rte_fib.h>\n-\n typedef int32_t (*rte_fib_test)(void);\n \n static int32_t test_create_invalid(void);\n@@ -433,7 +415,5 @@ test_slow_fib(void)\n \treturn unit_test_suite_runner(&fib_slow_tests);\n }\n \n-#endif /* !RTE_EXEC_ENV_WINDOWS */\n-\n REGISTER_TEST_COMMAND(fib_autotest, test_fib);\n REGISTER_TEST_COMMAND(fib_slow_autotest, test_slow_fib);\ndiff --git a/app/test/test_fib6.c b/app/test/test_fib6.c\nindex cd971e6ecdfb..15ad09178ae2 100644\n--- a/app/test/test_fib6.c\n+++ b/app/test/test_fib6.c\n@@ -9,29 +9,11 @@\n \n #include <rte_memory.h>\n #include <rte_log.h>\n-\n-#include \"test.h\"\n-\n-#ifdef RTE_EXEC_ENV_WINDOWS\n-static int\n-test_fib6(void)\n-{\n-\tprintf(\"fib not supported on Windows, skipping test\\n\");\n-\treturn TEST_SKIPPED;\n-}\n-\n-static int\n-test_slow_fib6(void)\n-{\n-\tprintf(\"slow_fib not supported on Windows, skipping test\\n\");\n-\treturn TEST_SKIPPED;\n-}\n-\n-#else\n-\n #include <rte_rib6.h>\n #include <rte_fib6.h>\n \n+#include \"test.h\"\n+\n typedef int32_t (*rte_fib6_test)(void);\n \n static int32_t test_create_invalid(void);\n@@ -442,7 +424,5 @@ test_slow_fib6(void)\n \treturn unit_test_suite_runner(&fib6_slow_tests);\n }\n \n-#endif /* !RTE_EXEC_ENV_WINDOWS */\n-\n REGISTER_TEST_COMMAND(fib6_autotest, test_fib6);\n REGISTER_TEST_COMMAND(fib6_slow_autotest, test_slow_fib6);\ndiff --git a/app/test/test_fib6_perf.c b/app/test/test_fib6_perf.c\nindex 21d2b65318e9..add20c2331b1 100644\n--- a/app/test/test_fib6_perf.c\n+++ b/app/test/test_fib6_perf.c\n@@ -10,21 +10,10 @@\n #include <rte_cycles.h>\n #include <rte_random.h>\n #include <rte_memory.h>\n+#include <rte_fib6.h>\n \n #include \"test.h\"\n \n-#ifdef RTE_EXEC_ENV_WINDOWS\n-static int\n-test_fib6_perf(void)\n-{\n-\tprintf(\"fib6_perf not supported on Windows, skipping test\\n\");\n-\treturn TEST_SKIPPED;\n-}\n-\n-#else\n-\n-#include <rte_fib6.h>\n-\n #include \"test_lpm6_data.h\"\n \n #define TEST_FIB_ASSERT(cond) do {\t\t\t\t\\\n@@ -167,6 +156,4 @@ test_fib6_perf(void)\n \treturn 0;\n }\n \n-#endif /*ifdef RTE_EXEC_ENV_WINDOWS*/\n-\n REGISTER_TEST_COMMAND(fib6_perf_autotest, test_fib6_perf);\ndiff --git a/app/test/test_fib_perf.c b/app/test/test_fib_perf.c\nindex 9787874cc9b7..b56293e64f41 100644\n--- a/app/test/test_fib_perf.c\n+++ b/app/test/test_fib_perf.c\n@@ -12,22 +12,11 @@\n #include <rte_random.h>\n #include <rte_branch_prediction.h>\n #include <rte_ip.h>\n+#include <rte_fib.h>\n \n #include \"test.h\"\n #include \"test_xmmt_ops.h\"\n \n-#ifdef RTE_EXEC_ENV_WINDOWS\n-static int\n-test_fib_perf(void)\n-{\n-\tprintf(\"fib_perf not supported on Windows, skipping test\\n\");\n-\treturn TEST_SKIPPED;\n-}\n-\n-#else\n-\n-#include <rte_fib.h>\n-\n #define TEST_FIB_ASSERT(cond) do {\t\t\t\t\\\n \tif (!(cond)) {\t\t\t\t\t\t\\\n \t\tprintf(\"Error at line %d:\\n\", __LINE__);\t\\\n@@ -246,7 +235,7 @@ static void generate_random_rule_prefix(uint32_t ip_class, uint8_t depth)\n \t/* Only generate rest bits except the most significant\n \t * fixed bits for IP address class\n \t */\n-\tstart = lrand48() & mask;\n+\tstart = rte_rand() & mask;\n \tptr_rule = &large_route_table[num_route_entries];\n \tfor (k = 0; k < rule_num; k++) {\n \t\tptr_rule->ip = (start << (RTE_FIB_MAX_DEPTH - depth))\n@@ -265,7 +254,7 @@ static void insert_rule_in_random_pos(uint32_t ip, uint8_t depth)\n \tstruct route_rule tmp;\n \n \tdo {\n-\t\tpos = lrand48();\n+\t\tpos = rte_rand();\n \t\ttry_count++;\n \t} while ((try_count < 10) && (pos > num_route_entries));\n \n@@ -420,6 +409,4 @@ test_fib_perf(void)\n \treturn 0;\n }\n \n-#endif /* !RTE_EXEC_ENV_WINDOWS */\n-\n REGISTER_TEST_COMMAND(fib_perf_autotest, test_fib_perf);\ndiff --git a/lib/fib/meson.build b/lib/fib/meson.build\nindex 9b848d08417c..ddcae0617a73 100644\n--- a/lib/fib/meson.build\n+++ b/lib/fib/meson.build\n@@ -2,12 +2,6 @@\n # Copyright(c) 2018 Vladimir Medvedkin <medvedkinv@gmail.com>\n # Copyright(c) 2019 Intel Corporation\n \n-if is_windows\n-    build = false\n-    reason = 'not supported on Windows'\n-    subdir_done()\n-endif\n-\n sources = files('rte_fib.c', 'rte_fib6.c', 'dir24_8.c', 'trie.c')\n headers = files('rte_fib.h', 'rte_fib6.h')\n deps += ['rib']\ndiff --git a/lib/fib/rte_fib.c b/lib/fib/rte_fib.c\nindex 8af4c4091908..0c3b20e00a5a 100644\n--- a/lib/fib/rte_fib.c\n+++ b/lib/fib/rte_fib.c\n@@ -5,6 +5,7 @@\n \n #include <stdint.h>\n #include <string.h>\n+#include <sys/queue.h>\n \n #include <rte_eal_memconfig.h>\n #include <rte_errno.h>\ndiff --git a/lib/fib/rte_fib6.c b/lib/fib/rte_fib6.c\nindex 4b8e22b142b9..28c69b38999f 100644\n--- a/lib/fib/rte_fib6.c\n+++ b/lib/fib/rte_fib6.c\n@@ -5,6 +5,7 @@\n \n #include <stdint.h>\n #include <string.h>\n+#include <sys/queue.h>\n \n #include <rte_eal_memconfig.h>\n #include <rte_tailq.h>\n",
    "prefixes": [
        "v4",
        "7/9"
    ]
}