Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124161/?format=api
{ "id": 124161, "url": "http://patches.dpdk.org/api/patches/124161/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230219231416.22524-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230219231416.22524-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230219231416.22524-7-stephen@networkplumber.org", "date": "2023-02-19T23:14:13", "name": "[v4,6/9] rib: enable on Windows", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "203ebfd3fef03ac7d906ce79a5cbb45b533813eb", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230219231416.22524-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 27076, "url": "http://patches.dpdk.org/api/series/27076/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27076", "date": "2023-02-19T23:14:07", "name": "Enable building more libraries on Windows", "version": 4, "mbox": "http://patches.dpdk.org/series/27076/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/124161/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/124161/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5BC2241CE4;\n\tMon, 20 Feb 2023 00:14:56 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 120D142D9C;\n\tMon, 20 Feb 2023 00:14:34 +0100 (CET)", "from mail-pj1-f54.google.com (mail-pj1-f54.google.com\n [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id 5AAE342D8A\n for <dev@dpdk.org>; Mon, 20 Feb 2023 00:14:26 +0100 (CET)", "by mail-pj1-f54.google.com with SMTP id pt11so145081pjb.1\n for <dev@dpdk.org>; Sun, 19 Feb 2023 15:14:26 -0800 (PST)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n l10-20020a170902d34a00b00192fe452e17sm683336plk.162.2023.02.19.15.14.24\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 19 Feb 2023 15:14:24 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=6zL2xjbD1mmWRggd1/eVrleId77cdCaSbEqFDtttXyo=;\n b=JqKVHI6aNDICd7GwiqF6ylJppK65jwBVZfOOEU2QE7EJKMnJ8LFZ6bB0maFFC3O54H\n EJEbk7tNHmc2uXX1A67RGo0dllPhGLv6N41L9c5sBN7XbXP+XxkJwiA4pJfUvLwmzrAt\n SF9j3lOjSGjPQ6nBBkrXEGhNzUxympDD7wVydnniS4NLxrZQxnpnSoG7eyDfCbZDIHVG\n kEyJSBiYMl5Jy8xjQaySjVOsd4Jl/1aqQxqFxD17DXQDU6MjfdkcG6K3F7kOdrp+Nbo/\n rSt/9epKEwJIwUDd2ln/GmNCPghm6Tg70WlowRVJZdu6D9I/CAB4sHnzNstKSlpQCC8w\n F1Hg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=6zL2xjbD1mmWRggd1/eVrleId77cdCaSbEqFDtttXyo=;\n b=l727HoHuL0Wrhge3Qn2+6Fw+59LCVgVEU3d2nsLAJ0PYiMsYOb6MzkeORddI1Yv/GE\n 9sGGxNHw2byw5iCoDDBYTKGDmH+HabLf8UBIDBwzOTXMe86ed/MZ9jbmUtu50xlOYy6a\n zAwAIzsXgQR6BXR5c9LzLyyRgzxHS+RJMnPJ6KqGWff7NYAEw87Uk7PzLwHg+Xm5MT36\n SdZmk6mVTUtP0aBE/oxtwqK6RTBYM62eXU1KS5Ng5ARnd4+wFOJx2a3AxLTEt7IzBJo6\n v85sW7LZp16egHAsGM1/Ele6E9dwZc6Kep73dYTWH7O2YM7RIglw3mygSF66vj8xVnZX\n 964Q==", "X-Gm-Message-State": "AO0yUKX3Jrm5A4c0oEJHdpbqN+pIfBzTXHtRpKiYAT0vYOom0SktXSGz\n puosYrSpa6V+kR3ZTrBry0/xos9Est+5p4vE7d0=", "X-Google-Smtp-Source": "\n AK7set/Xd1dLxAuSVAstjzmMu5CDnZ/gQgvLg24tSG3Iy/GuUXhO3C8ojHyC6SPfaHJ7E423tUqySA==", "X-Received": "by 2002:a17:902:da91:b0:19a:f02c:a05b with SMTP id\n j17-20020a170902da9100b0019af02ca05bmr3167564plx.3.1676848465204;\n Sun, 19 Feb 2023 15:14:25 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>", "Subject": "[PATCH v4 6/9] rib: enable on Windows", "Date": "Sun, 19 Feb 2023 15:14:13 -0800", "Message-Id": "<20230219231416.22524-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230219231416.22524-1-stephen@networkplumber.org>", "References": "<20230207001937.875608-1-stephen@networkplumber.org>\n <20230219231416.22524-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The RIB library builds on Windows as long as sys/queue.h is included\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n app/test/test_rib.c | 19 -------------------\n app/test/test_rib6.c | 24 ++----------------------\n lib/rib/meson.build | 6 ------\n lib/rib/rte_rib.c | 1 +\n lib/rib/rte_rib6.c | 1 +\n 5 files changed, 4 insertions(+), 47 deletions(-)", "diff": "diff --git a/app/test/test_rib.c b/app/test/test_rib.c\nindex 06058f8f7c52..65b685641094 100644\n--- a/app/test/test_rib.c\n+++ b/app/test/test_rib.c\n@@ -10,23 +10,6 @@\n #include <stdlib.h>\n \n #include <rte_ip.h>\n-\n-#ifdef RTE_EXEC_ENV_WINDOWS\n-static int\n-test_rib(void)\n-{\n-\tprintf(\"rib not supported on Windows, skipping test\\n\");\n-\treturn TEST_SKIPPED;\n-}\n-\n-static int\n-test_slow_rib(void)\n-{\n-\tprintf(\"slow_rib not supported on Windows, skipping test\\n\");\n-\treturn TEST_SKIPPED;\n-}\n-#else\n-\n #include <rte_rib.h>\n \n typedef int32_t (*rte_rib_test)(void);\n@@ -380,7 +363,5 @@ test_slow_rib(void)\n \treturn unit_test_suite_runner(&rib_slow_tests);\n }\n \n-#endif /* !RTE_EXEC_ENV_WINDOWS */\n-\n REGISTER_TEST_COMMAND(rib_autotest, test_rib);\n REGISTER_TEST_COMMAND(rib_slow_autotest, test_slow_rib);\ndiff --git a/app/test/test_rib6.c b/app/test/test_rib6.c\nindex ba79aedea5f7..336b779d2e1e 100644\n--- a/app/test/test_rib6.c\n+++ b/app/test/test_rib6.c\n@@ -3,32 +3,14 @@\n * Copyright(c) 2019 Intel Corporation\n */\n \n-#include \"test.h\"\n-\n #include <stdio.h>\n #include <stdint.h>\n #include <stdlib.h>\n-\n #include <rte_ip.h>\n-\n-#ifdef RTE_EXEC_ENV_WINDOWS\n-static int\n-test_rib6(void)\n-{\n-\tprintf(\"rib6 not supported on Windows, skipping test\\n\");\n-\treturn TEST_SKIPPED;\n-}\n-\n-static int\n-test_slow_rib6(void)\n-{\n-\tprintf(\"slow_rib6 not supported on Windows, skipping test\\n\");\n-\treturn TEST_SKIPPED;\n-}\n-#else\n-\n #include <rte_rib6.h>\n \n+#include \"test.h\"\n+\n typedef int32_t (*rte_rib6_test)(void);\n \n static int32_t test_create_invalid(void);\n@@ -385,7 +367,5 @@ test_slow_rib6(void)\n \treturn unit_test_suite_runner(&rib6_slow_tests);\n }\n \n-#endif /* !RTE_EXEC_ENV_WINDOWS */\n-\n REGISTER_TEST_COMMAND(rib6_autotest, test_rib6);\n REGISTER_TEST_COMMAND(rib6_slow_autotest, test_slow_rib6);\ndiff --git a/lib/rib/meson.build b/lib/rib/meson.build\nindex bda7f576e976..7bacbb453592 100644\n--- a/lib/rib/meson.build\n+++ b/lib/rib/meson.build\n@@ -2,12 +2,6 @@\n # Copyright(c) 2018 Vladimir Medvedkin <medvedkinv@gmail.com>\n # Copyright(c) 2019 Intel Corporation\n \n-if is_windows\n- build = false\n- reason = 'not supported on Windows'\n- subdir_done()\n-endif\n-\n sources = files('rte_rib.c', 'rte_rib6.c')\n headers = files('rte_rib.h', 'rte_rib6.h')\n deps += ['mempool']\ndiff --git a/lib/rib/rte_rib.c b/lib/rib/rte_rib.c\nindex b0794edf66f5..812a2597d117 100644\n--- a/lib/rib/rte_rib.c\n+++ b/lib/rib/rte_rib.c\n@@ -5,6 +5,7 @@\n \n #include <stdbool.h>\n #include <stdint.h>\n+#include <sys/queue.h>\n \n #include <rte_eal_memconfig.h>\n #include <rte_errno.h>\ndiff --git a/lib/rib/rte_rib6.c b/lib/rib/rte_rib6.c\nindex 19e4ff97c479..ae44281ae105 100644\n--- a/lib/rib/rte_rib6.c\n+++ b/lib/rib/rte_rib6.c\n@@ -5,6 +5,7 @@\n \n #include <stdbool.h>\n #include <stdint.h>\n+#include <sys/queue.h>\n \n #include <rte_eal_memconfig.h>\n #include <rte_errno.h>\n", "prefixes": [ "v4", "6/9" ] }